Commit c39540c6 authored by Ravishankar N's avatar Ravishankar N Committed by Linus Torvalds

fat: fix incorrect function comment

fat_search_long() returns 0 on success, -ENOENT/ENOMEM on failure.
Change the function comment accordingly.

While at it, fix some trivial typos.
Signed-off-by: default avatarRavishankar N <cyberax82@gmail.com>
Signed-off-by: default avatarNamjae Jeon <linkinjeon@gmail.com>
Acked-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 99bbb2b0
...@@ -461,8 +461,7 @@ static int fat_parse_short(struct super_block *sb, ...@@ -461,8 +461,7 @@ static int fat_parse_short(struct super_block *sb,
} }
/* /*
* Return values: negative -> error, 0 -> not found, positive -> found, * Return values: negative -> error/not found, 0 -> found.
* value is the total amount of slots, including the shortname entry.
*/ */
int fat_search_long(struct inode *inode, const unsigned char *name, int fat_search_long(struct inode *inode, const unsigned char *name,
int name_len, struct fat_slot_info *sinfo) int name_len, struct fat_slot_info *sinfo)
...@@ -1255,7 +1254,7 @@ int fat_add_entries(struct inode *dir, void *slots, int nr_slots, ...@@ -1255,7 +1254,7 @@ int fat_add_entries(struct inode *dir, void *slots, int nr_slots,
sinfo->nr_slots = nr_slots; sinfo->nr_slots = nr_slots;
/* First stage: search free direcotry entries */ /* First stage: search free directory entries */
free_slots = nr_bhs = 0; free_slots = nr_bhs = 0;
bh = prev = NULL; bh = prev = NULL;
pos = 0; pos = 0;
......
...@@ -1344,7 +1344,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat, ...@@ -1344,7 +1344,7 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
sbi->dir_entries = get_unaligned_le16(&b->dir_entries); sbi->dir_entries = get_unaligned_le16(&b->dir_entries);
if (sbi->dir_entries & (sbi->dir_per_block - 1)) { if (sbi->dir_entries & (sbi->dir_per_block - 1)) {
if (!silent) if (!silent)
fat_msg(sb, KERN_ERR, "bogus directroy-entries per block" fat_msg(sb, KERN_ERR, "bogus directory-entries per block"
" (%u)", sbi->dir_entries); " (%u)", sbi->dir_entries);
brelse(bh); brelse(bh);
goto out_invalid; goto out_invalid;
......
...@@ -135,6 +135,10 @@ int fat_chain_add(struct inode *inode, int new_dclus, int nr_cluster) ...@@ -135,6 +135,10 @@ int fat_chain_add(struct inode *inode, int new_dclus, int nr_cluster)
} }
if (ret < 0) if (ret < 0)
return ret; return ret;
/*
* FIXME:Although we can add this cache, fat_cache_add() is
* assuming to be called after linear search with fat_cache_id.
*/
// fat_cache_add(inode, new_fclus, new_dclus); // fat_cache_add(inode, new_fclus, new_dclus);
} else { } else {
MSDOS_I(inode)->i_start = new_dclus; MSDOS_I(inode)->i_start = new_dclus;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment