Commit c46a131c authored by Al Viro's avatar Al Viro Committed by Alex Elder

xfs: fix ->mknod() return value on xfs_get_acl() failure

->mknod() should return negative on errors and PTR_ERR() gives
already negative value...
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
parent 59c5f46f
...@@ -182,7 +182,7 @@ xfs_vn_mknod( ...@@ -182,7 +182,7 @@ xfs_vn_mknod(
if (IS_POSIXACL(dir)) { if (IS_POSIXACL(dir)) {
default_acl = xfs_get_acl(dir, ACL_TYPE_DEFAULT); default_acl = xfs_get_acl(dir, ACL_TYPE_DEFAULT);
if (IS_ERR(default_acl)) if (IS_ERR(default_acl))
return -PTR_ERR(default_acl); return PTR_ERR(default_acl);
if (!default_acl) if (!default_acl)
mode &= ~current_umask(); mode &= ~current_umask();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment