Commit c4ede561 authored by Pavan Holla's avatar Pavan Holla Committed by Greg Kroah-Hartman

usb: typec: ucsi: Wait 20ms before reading CCI after a reset

The PPM might take time to process a reset. Allow 20ms for the reset to
be processed before reading the CCI.

This should not slow down existing implementations because they would
not set any bits in the CCI after a reset, and would take a 20ms delay
to read the CCI anyway. This change makes the delay explicit, and
reduces a CCI read. Based on the spec, the PPM has 10ms to set busy, so,
20ms seems like a reasonable delay before we read the CCI.
Signed-off-by: default avatarPavan Holla <pholla@chromium.org>
Reviewed-by: default avatarPrashant Malani <pmalani@chromium.org>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240409-ucsi-reset-delay-v3-1-8440710b012b@chromium.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0fb782b5
......@@ -1337,6 +1337,9 @@ static int ucsi_reset_ppm(struct ucsi *ucsi)
goto out;
}
/* Give the PPM time to process a reset before reading CCI */
msleep(20);
ret = ucsi->ops->read(ucsi, UCSI_CCI, &cci, sizeof(cci));
if (ret)
goto out;
......@@ -1350,7 +1353,6 @@ static int ucsi_reset_ppm(struct ucsi *ucsi)
goto out;
}
msleep(20);
} while (!(cci & UCSI_CCI_RESET_COMPLETE));
out:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment