Commit c7242a45 authored by Amir Goldstein's avatar Amir Goldstein

ovl: fix NULL pointer defer when encoding non-decodable lower fid

A wrong return value from ovl_check_encode_origin() would cause
ovl_dentry_to_fid() to try to encode fid from NULL upper dentry.

Reported-by: syzbot+2208f82282740c1c8915@syzkaller.appspotmail.com
Fixes: 16aac5ad ("ovl: support encoding non-decodable file handles")
Signed-off-by: default avatarAmir Goldstein <amir73il@gmail.com>
parent a535116d
...@@ -188,7 +188,7 @@ static int ovl_check_encode_origin(struct dentry *dentry) ...@@ -188,7 +188,7 @@ static int ovl_check_encode_origin(struct dentry *dentry)
/* Lower file handle for non-upper non-decodable */ /* Lower file handle for non-upper non-decodable */
if (!ovl_dentry_upper(dentry) && !decodable) if (!ovl_dentry_upper(dentry) && !decodable)
return 0; return 1;
/* Upper file handle for pure upper */ /* Upper file handle for pure upper */
if (!ovl_dentry_lower(dentry)) if (!ovl_dentry_lower(dentry))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment