Commit c810b31e authored by John Fastabend's avatar John Fastabend Committed by Alexei Starovoitov

bpf, selftests: Fix warning in snprintf_btf where system() call unchecked

On my systems system() calls are marked with warn_unused_result
apparently. So without error checking we get this warning,

./prog_tests/snprintf_btf.c:30:9: warning: ignoring return value
   of ‘system’, declared with attribute warn_unused_result[-Wunused-result]

Also it seems like a good idea to check the return value anyways
to ensure ping exists even if its seems unlikely.

Fixes: 076a95f5 ("selftests/bpf: Add bpf_snprintf_btf helper tests")
Signed-off-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/160141006897.25201.12095049414156293265.stgit@john-Precision-5820-Tower
parent 93b8713d
...@@ -27,7 +27,9 @@ void test_snprintf_btf(void) ...@@ -27,7 +27,9 @@ void test_snprintf_btf(void)
goto cleanup; goto cleanup;
/* generate receive event */ /* generate receive event */
(void) system("ping -c 1 127.0.0.1 > /dev/null"); err = system("ping -c 1 127.0.0.1 > /dev/null");
if (CHECK(err, "system", "ping failed: %d\n", err))
goto cleanup;
if (bss->skip) { if (bss->skip) {
printf("%s:SKIP:no __builtin_btf_type_id\n", __func__); printf("%s:SKIP:no __builtin_btf_type_id\n", __func__);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment