Commit c9c1fd62 authored by Dejin Zheng's avatar Dejin Zheng Committed by David S. Miller

net: phy: mdio-mux-bcm-iproc: use readl_poll_timeout() to simplify code

use readl_poll_timeout() to replace the poll codes for simplify
iproc_mdio_wait_for_idle() function
Signed-off-by: default avatarDejin Zheng <zhengdejin5@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5ef8c665
...@@ -10,6 +10,7 @@ ...@@ -10,6 +10,7 @@
#include <linux/phy.h> #include <linux/phy.h>
#include <linux/mdio-mux.h> #include <linux/mdio-mux.h>
#include <linux/delay.h> #include <linux/delay.h>
#include <linux/iopoll.h>
#define MDIO_RATE_ADJ_EXT_OFFSET 0x000 #define MDIO_RATE_ADJ_EXT_OFFSET 0x000
#define MDIO_RATE_ADJ_INT_OFFSET 0x004 #define MDIO_RATE_ADJ_INT_OFFSET 0x004
...@@ -78,18 +79,11 @@ static void mdio_mux_iproc_config(struct iproc_mdiomux_desc *md) ...@@ -78,18 +79,11 @@ static void mdio_mux_iproc_config(struct iproc_mdiomux_desc *md)
static int iproc_mdio_wait_for_idle(void __iomem *base, bool result) static int iproc_mdio_wait_for_idle(void __iomem *base, bool result)
{ {
unsigned int timeout = 1000; /* loop for 1s */
u32 val; u32 val;
do { return readl_poll_timeout(base + MDIO_STAT_OFFSET, val,
val = readl(base + MDIO_STAT_OFFSET); (val & MDIO_STAT_DONE) == result,
if ((val & MDIO_STAT_DONE) == result) 2000, 1000000);
return 0;
usleep_range(1000, 2000);
} while (timeout--);
return -ETIMEDOUT;
} }
/* start_miim_ops- Program and start MDIO transaction over mdio bus. /* start_miim_ops- Program and start MDIO transaction over mdio bus.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment