Commit ce2927e9 authored by Giedrius Statkevičius's avatar Giedrius Statkevičius Committed by Greg Kroah-Hartman

staging: dgnc: don't forget to check if ->channels[i] is NULL in dgnc_tty_uninit()

Add a check if ->channels[i] is NULL because a NULL pointer may be dereferenced
in case one of the allocations failed
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarGiedrius Statkevičius <giedrius.statkevicius@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fa52d96c
...@@ -403,7 +403,9 @@ void dgnc_tty_uninit(struct dgnc_board *brd) ...@@ -403,7 +403,9 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
dgnc_BoardsByMajor[brd->SerialDriver.major] = NULL; dgnc_BoardsByMajor[brd->SerialDriver.major] = NULL;
brd->dgnc_Serial_Major = 0; brd->dgnc_Serial_Major = 0;
for (i = 0; i < brd->nasync; i++) { for (i = 0; i < brd->nasync; i++) {
dgnc_remove_tty_sysfs(brd->channels[i]->ch_tun.un_sysfs); if (brd->channels[i])
dgnc_remove_tty_sysfs(brd->channels[i]->
ch_tun.un_sysfs);
tty_unregister_device(&brd->SerialDriver, i); tty_unregister_device(&brd->SerialDriver, i);
} }
tty_unregister_driver(&brd->SerialDriver); tty_unregister_driver(&brd->SerialDriver);
...@@ -414,7 +416,9 @@ void dgnc_tty_uninit(struct dgnc_board *brd) ...@@ -414,7 +416,9 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
dgnc_BoardsByMajor[brd->PrintDriver.major] = NULL; dgnc_BoardsByMajor[brd->PrintDriver.major] = NULL;
brd->dgnc_TransparentPrint_Major = 0; brd->dgnc_TransparentPrint_Major = 0;
for (i = 0; i < brd->nasync; i++) { for (i = 0; i < brd->nasync; i++) {
dgnc_remove_tty_sysfs(brd->channels[i]->ch_pun.un_sysfs); if (brd->channels[i])
dgnc_remove_tty_sysfs(brd->channels[i]->
ch_pun.un_sysfs);
tty_unregister_device(&brd->PrintDriver, i); tty_unregister_device(&brd->PrintDriver, i);
} }
tty_unregister_driver(&brd->PrintDriver); tty_unregister_driver(&brd->PrintDriver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment