Commit ce3b32ec authored by ChunTao Tso's avatar ChunTao Tso Committed by Alex Deucher

drm/amd/display: amend HPD handler for Replay

[Why]
For Replay, if we receive HPD, it doesn’t need to reboot the display.
We don’t need to return anything exactly.

[How]
Return nothing just because we don’t need to reboot the display.
Signed-off-by: default avatarChunTao Tso <chuntao.tso@amd.com>
Acked-by: default avatarHersen Wu <hersenxs.wu@amd.com>
Reviewed-by: default avatarJerry Zuo <jerry.zuo@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 39ad51cb
...@@ -184,17 +184,17 @@ static bool handle_hpd_irq_psr_sink(struct dc_link *link) ...@@ -184,17 +184,17 @@ static bool handle_hpd_irq_psr_sink(struct dc_link *link)
return false; return false;
} }
static bool handle_hpd_irq_replay_sink(struct dc_link *link) static void handle_hpd_irq_replay_sink(struct dc_link *link)
{ {
union dpcd_replay_configuration replay_configuration; union dpcd_replay_configuration replay_configuration;
/*AMD Replay version reuse DP_PSR_ERROR_STATUS for REPLAY_ERROR status.*/ /*AMD Replay version reuse DP_PSR_ERROR_STATUS for REPLAY_ERROR status.*/
union psr_error_status replay_error_status; union psr_error_status replay_error_status;
if (link->replay_settings.config.force_disable_desync_error_check) if (link->replay_settings.config.force_disable_desync_error_check)
return true; return;
if (!link->replay_settings.replay_feature_enabled) if (!link->replay_settings.replay_feature_enabled)
return false; return;
dm_helpers_dp_read_dpcd( dm_helpers_dp_read_dpcd(
link->ctx, link->ctx,
...@@ -246,7 +246,6 @@ static bool handle_hpd_irq_replay_sink(struct dc_link *link) ...@@ -246,7 +246,6 @@ static bool handle_hpd_irq_replay_sink(struct dc_link *link)
edp_set_replay_allow_active(link, &allow_active, true, false, NULL); edp_set_replay_allow_active(link, &allow_active, true, false, NULL);
} }
} }
return true;
} }
void dp_handle_link_loss(struct dc_link *link) void dp_handle_link_loss(struct dc_link *link)
...@@ -427,9 +426,7 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link, ...@@ -427,9 +426,7 @@ bool dp_handle_hpd_rx_irq(struct dc_link *link,
/* PSR-related error was detected and handled */ /* PSR-related error was detected and handled */
return true; return true;
if (handle_hpd_irq_replay_sink(link)) handle_hpd_irq_replay_sink(link);
/* Replay-related error was detected and handled */
return true;
/* If PSR-related error handled, Main link may be off, /* If PSR-related error handled, Main link may be off,
* so do not handle as a normal sink status change interrupt. * so do not handle as a normal sink status change interrupt.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment