Commit cf736ea6 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Eduardo Valentin

thermal: power_allocator: do not use devm* interfaces

The code in question is called outside of standard driver
probe()/remove() callbacks and thus will not benefit from use of devm*
infrastructure.
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: default avatarEduardo Valentin <edubezval@gmail.com>
parent 7ddab733
...@@ -334,7 +334,7 @@ static int allocate_power(struct thermal_zone_device *tz, ...@@ -334,7 +334,7 @@ static int allocate_power(struct thermal_zone_device *tz,
max_allocatable_power, current_temp, max_allocatable_power, current_temp,
(s32)control_temp - (s32)current_temp); (s32)control_temp - (s32)current_temp);
devm_kfree(&tz->device, req_power); kfree(req_power);
unlock: unlock:
mutex_unlock(&tz->lock); mutex_unlock(&tz->lock);
...@@ -426,7 +426,7 @@ static int power_allocator_bind(struct thermal_zone_device *tz) ...@@ -426,7 +426,7 @@ static int power_allocator_bind(struct thermal_zone_device *tz)
return -EINVAL; return -EINVAL;
} }
params = devm_kzalloc(&tz->device, sizeof(*params), GFP_KERNEL); params = kzalloc(sizeof(*params), GFP_KERNEL);
if (!params) if (!params)
return -ENOMEM; return -ENOMEM;
...@@ -468,14 +468,14 @@ static int power_allocator_bind(struct thermal_zone_device *tz) ...@@ -468,14 +468,14 @@ static int power_allocator_bind(struct thermal_zone_device *tz)
return 0; return 0;
free: free:
devm_kfree(&tz->device, params); kfree(params);
return ret; return ret;
} }
static void power_allocator_unbind(struct thermal_zone_device *tz) static void power_allocator_unbind(struct thermal_zone_device *tz)
{ {
dev_dbg(&tz->device, "Unbinding from thermal zone %d\n", tz->id); dev_dbg(&tz->device, "Unbinding from thermal zone %d\n", tz->id);
devm_kfree(&tz->device, tz->governor_data); kfree(tz->governor_data);
tz->governor_data = NULL; tz->governor_data = NULL;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment