Commit d120198b authored by Luca Fancellu's avatar Luca Fancellu Committed by Boris Ostrovsky

xen/evtchn: Change irq_info lock to raw_spinlock_t

Unmask operation must be called with interrupt disabled,
on preempt_rt spin_lock_irqsave/spin_unlock_irqrestore
don't disable/enable interrupts, so use raw_* implementation
and change lock variable in struct irq_info from spinlock_t
to raw_spinlock_t

Cc: stable@vger.kernel.org
Fixes: 25da4618 ("xen/events: don't unmask an event channel when an eoi is pending")
Signed-off-by: default avatarLuca Fancellu <luca.fancellu@arm.com>
Reviewed-by: default avatarJulien Grall <jgrall@amazon.com>
Reviewed-by: default avatarWei Liu <wei.liu@kernel.org>
Link: https://lore.kernel.org/r/20210406105105.10141-1-luca.fancellu@arm.comSigned-off-by: default avatarBoris Ostrovsky <boris.ostrovsky@oracle.com>
parent a846738f
...@@ -110,7 +110,7 @@ struct irq_info { ...@@ -110,7 +110,7 @@ struct irq_info {
unsigned short eoi_cpu; /* EOI must happen on this cpu-1 */ unsigned short eoi_cpu; /* EOI must happen on this cpu-1 */
unsigned int irq_epoch; /* If eoi_cpu valid: irq_epoch of event */ unsigned int irq_epoch; /* If eoi_cpu valid: irq_epoch of event */
u64 eoi_time; /* Time in jiffies when to EOI. */ u64 eoi_time; /* Time in jiffies when to EOI. */
spinlock_t lock; raw_spinlock_t lock;
union { union {
unsigned short virq; unsigned short virq;
...@@ -312,7 +312,7 @@ static int xen_irq_info_common_setup(struct irq_info *info, ...@@ -312,7 +312,7 @@ static int xen_irq_info_common_setup(struct irq_info *info,
info->evtchn = evtchn; info->evtchn = evtchn;
info->cpu = cpu; info->cpu = cpu;
info->mask_reason = EVT_MASK_REASON_EXPLICIT; info->mask_reason = EVT_MASK_REASON_EXPLICIT;
spin_lock_init(&info->lock); raw_spin_lock_init(&info->lock);
ret = set_evtchn_to_irq(evtchn, irq); ret = set_evtchn_to_irq(evtchn, irq);
if (ret < 0) if (ret < 0)
...@@ -472,28 +472,28 @@ static void do_mask(struct irq_info *info, u8 reason) ...@@ -472,28 +472,28 @@ static void do_mask(struct irq_info *info, u8 reason)
{ {
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&info->lock, flags); raw_spin_lock_irqsave(&info->lock, flags);
if (!info->mask_reason) if (!info->mask_reason)
mask_evtchn(info->evtchn); mask_evtchn(info->evtchn);
info->mask_reason |= reason; info->mask_reason |= reason;
spin_unlock_irqrestore(&info->lock, flags); raw_spin_unlock_irqrestore(&info->lock, flags);
} }
static void do_unmask(struct irq_info *info, u8 reason) static void do_unmask(struct irq_info *info, u8 reason)
{ {
unsigned long flags; unsigned long flags;
spin_lock_irqsave(&info->lock, flags); raw_spin_lock_irqsave(&info->lock, flags);
info->mask_reason &= ~reason; info->mask_reason &= ~reason;
if (!info->mask_reason) if (!info->mask_reason)
unmask_evtchn(info->evtchn); unmask_evtchn(info->evtchn);
spin_unlock_irqrestore(&info->lock, flags); raw_spin_unlock_irqrestore(&info->lock, flags);
} }
#ifdef CONFIG_X86 #ifdef CONFIG_X86
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment