Commit d1c754a9 authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab

[media] V4L2: drivers implementing vidioc_default should also return -ENOTTY

If the vidioc_default implementation doesn't support the ioctl, then drivers
must return -ENOTTY instead of -EINVAL.
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent ee71e7b3
...@@ -1137,7 +1137,7 @@ static long cx18_default(struct file *file, void *fh, bool valid_prio, ...@@ -1137,7 +1137,7 @@ static long cx18_default(struct file *file, void *fh, bool valid_prio,
} }
default: default:
return -EINVAL; return -ENOTTY;
} }
return 0; return 0;
} }
......
...@@ -1761,7 +1761,7 @@ static long vpfe_param_handler(struct file *file, void *priv, ...@@ -1761,7 +1761,7 @@ static long vpfe_param_handler(struct file *file, void *priv,
} }
break; break;
default: default:
ret = -EINVAL; ret = -ENOTTY;
} }
unlock_out: unlock_out:
mutex_unlock(&vpfe_dev->lock); mutex_unlock(&vpfe_dev->lock);
......
...@@ -1827,7 +1827,7 @@ static long ivtv_default(struct file *file, void *fh, bool valid_prio, ...@@ -1827,7 +1827,7 @@ static long ivtv_default(struct file *file, void *fh, bool valid_prio,
return ivtv_decoder_ioctls(file, cmd, (void *)arg); return ivtv_decoder_ioctls(file, cmd, (void *)arg);
default: default:
return -EINVAL; return -ENOTTY;
} }
return 0; return 0;
} }
......
...@@ -1570,7 +1570,7 @@ static long vidioc_default(struct file *file, void *fh, bool valid_prio, ...@@ -1570,7 +1570,7 @@ static long vidioc_default(struct file *file, void *fh, bool valid_prio,
return meyeioc_stilljcapt((int *) arg); return meyeioc_stilljcapt((int *) arg);
default: default:
return -EINVAL; return -ENOTTY;
} }
} }
......
...@@ -688,7 +688,7 @@ static long vidioc_default(struct file *file, void *fh, bool valid_prio, ...@@ -688,7 +688,7 @@ static long vidioc_default(struct file *file, void *fh, bool valid_prio,
/* /*
DEB2(pr_err("does not handle this ioctl\n")); DEB2(pr_err("does not handle this ioctl\n"));
*/ */
return -ENOIOCTLCMD; return -ENOTTY;
} }
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment