Commit d2ad0a62 authored by Gao Pan's avatar Gao Pan Committed by Mark Brown

spi: fsl-lpspi: use wait_for_completion_timeout() while waiting transfer done

It's a potential problem to use wait_for_completion() because the
completion condition may never come. Thus, it's better to repalce
wait_for_completion() with wait_for_completion_timeout().
Signed-off-by: default avatarGao Pan <pandy.gao@nxp.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 14de3918
......@@ -348,7 +348,12 @@ static int fsl_lpspi_transfer_one(struct spi_master *master,
reinit_completion(&fsl_lpspi->xfer_done);
fsl_lpspi_write_tx_fifo(fsl_lpspi);
wait_for_completion(&fsl_lpspi->xfer_done);
ret = wait_for_completion_timeout(&fsl_lpspi->xfer_done, HZ);
if (!ret) {
dev_dbg(fsl_lpspi->dev, "wait for completion timeout\n");
return -ETIMEDOUT;
}
ret = fsl_lpspi_txfifo_empty(fsl_lpspi);
fsl_lpspi_read_rx_fifo(fsl_lpspi);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment