Commit d5c71a7c authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman

fib_rules: fix error in backport of e9919a24 ("fib_rules: return 0...")

When commit e9919a24 ("fib_rules: return 0 directly if an exactly
same rule exists when NLM_F_EXCL not supplied") was backported to 4.9.y,
it changed the logic a bit as err should have been reset before exiting
the test, like it happens in the original logic.

If this is not set, errors happen :(
Reported-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reported-by: default avatarDavid Ahern <dsahern@gmail.com>
Reported-by: default avatarFlorian Westphal <fw@strlen.de>
Cc: Hangbin Liu <liuhangbin@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7f9290f7
......@@ -430,6 +430,7 @@ int fib_nl_newrule(struct sk_buff *skb, struct nlmsghdr *nlh)
goto errout_free;
if (rule_exists(ops, frh, tb, rule)) {
err = 0;
if (nlh->nlmsg_flags & NLM_F_EXCL)
err = -EEXIST;
goto errout_free;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment