Commit d74c23d3 authored by Joe Perches's avatar Joe Perches Committed by Felipe Balbi

usb: gadget: s3c2410_udc: Remove static char buffer, use vsprintf extension %pV

Using unnecessary static char buffers isn't good.
Use the %pV extension instead.

Miscellanea:

o the dprintk return value is unused, make it void
o add __printf format and argument verification
Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent db978e28
...@@ -92,40 +92,38 @@ static struct s3c2410_udc_mach_info *udc_info; ...@@ -92,40 +92,38 @@ static struct s3c2410_udc_mach_info *udc_info;
static uint32_t s3c2410_ticks = 0; static uint32_t s3c2410_ticks = 0;
static int dprintk(int level, const char *fmt, ...) __printf(2, 3)
static void dprintk(int level, const char *fmt, ...)
{ {
static char printk_buf[1024];
static long prevticks; static long prevticks;
static int invocation; static int invocation;
struct va_format vaf;
va_list args; va_list args;
int len;
if (level > USB_S3C2410_DEBUG_LEVEL) if (level > USB_S3C2410_DEBUG_LEVEL)
return 0; return;
va_start(args, fmt);
vaf.fmt = fmt;
vaf.va = &args;
if (s3c2410_ticks != prevticks) { if (s3c2410_ticks != prevticks) {
prevticks = s3c2410_ticks; prevticks = s3c2410_ticks;
invocation = 0; invocation = 0;
} }
len = scnprintf(printk_buf, pr_debug("%1lu.%02d USB: %pV", prevticks, invocation++, &vaf);
sizeof(printk_buf), "%1lu.%02d USB: ",
prevticks, invocation++);
va_start(args, fmt);
len = vscnprintf(printk_buf+len,
sizeof(printk_buf)-len, fmt, args);
va_end(args); va_end(args);
pr_debug("%s", printk_buf);
return len;
} }
#else #else
static int dprintk(int level, const char *fmt, ...) __printf(2, 3)
static void dprintk(int level, const char *fmt, ...)
{ {
return 0;
} }
#endif #endif
static int s3c2410_udc_debugfs_seq_show(struct seq_file *m, void *p) static int s3c2410_udc_debugfs_seq_show(struct seq_file *m, void *p)
{ {
u32 addr_reg, pwr_reg, ep_int_reg, usb_int_reg; u32 addr_reg, pwr_reg, ep_int_reg, usb_int_reg;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment