Commit d958939a authored by Christian König's avatar Christian König Committed by Alex Deucher

drm/amdgpu: fix amdgpu_vm_pasid_fault_credit

As soon as the lock is dropped the VM pointer can be invalid.
Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
Reviewed-by: default avatarChunming Zhou <david1.zhou@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e2721595
...@@ -2478,17 +2478,21 @@ bool amdgpu_vm_pasid_fault_credit(struct amdgpu_device *adev, ...@@ -2478,17 +2478,21 @@ bool amdgpu_vm_pasid_fault_credit(struct amdgpu_device *adev,
spin_lock(&adev->vm_manager.pasid_lock); spin_lock(&adev->vm_manager.pasid_lock);
vm = idr_find(&adev->vm_manager.pasid_idr, pasid); vm = idr_find(&adev->vm_manager.pasid_idr, pasid);
spin_unlock(&adev->vm_manager.pasid_lock); if (!vm) {
if (!vm)
/* VM not found, can't track fault credit */ /* VM not found, can't track fault credit */
spin_unlock(&adev->vm_manager.pasid_lock);
return true; return true;
}
/* No lock needed. only accessed by IRQ handler */ /* No lock needed. only accessed by IRQ handler */
if (!vm->fault_credit) if (!vm->fault_credit) {
/* Too many faults in this VM */ /* Too many faults in this VM */
spin_unlock(&adev->vm_manager.pasid_lock);
return false; return false;
}
vm->fault_credit--; vm->fault_credit--;
spin_unlock(&adev->vm_manager.pasid_lock);
return true; return true;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment