Commit d99ba446 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Jason Cooper

irqchip: brcmstb-l2: Fix error handling of irq_of_parse_and_map

Return value of irq_of_parse_and_map() is unsigned int, with 0
indicating failure, so testing for negative result never works.
Signed-off-by: default avatarDmitry Torokhov <dtor@chromium.org>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Tested-by: Kevin Cernekee <cernekee@gmail.com> 
Link: https://lkml.kernel.org/r/20141114221642.GA37468@dtor-wsSigned-off-by: default avatarJason Cooper <jason@lakedaemon.net>
parent 714710e1
...@@ -135,9 +135,9 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np, ...@@ -135,9 +135,9 @@ int __init brcmstb_l2_intc_of_init(struct device_node *np,
__raw_writel(0xffffffff, data->base + CPU_CLEAR); __raw_writel(0xffffffff, data->base + CPU_CLEAR);
data->parent_irq = irq_of_parse_and_map(np, 0); data->parent_irq = irq_of_parse_and_map(np, 0);
if (data->parent_irq < 0) { if (!data->parent_irq) {
pr_err("failed to find parent interrupt\n"); pr_err("failed to find parent interrupt\n");
ret = data->parent_irq; ret = -EINVAL;
goto out_unmap; goto out_unmap;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment