Commit dabf24d1 authored by Ivan Vecera's avatar Ivan Vecera Committed by David S. Miller

bna: fill the magic in bnad_get_eeprom() instead of validating

A driver should fill magic field of ethtool_eeprom struct in .get_eeprom
and validate it in .set_eeprom. The bna incorrectly validates it in both
and this makes its .get_eeprom interface unusable.
Signed-off-by: default avatarIvan Vecera <ivecera@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 26bcd8b7
...@@ -997,10 +997,8 @@ bnad_get_eeprom(struct net_device *netdev, struct ethtool_eeprom *eeprom, ...@@ -997,10 +997,8 @@ bnad_get_eeprom(struct net_device *netdev, struct ethtool_eeprom *eeprom,
unsigned long flags = 0; unsigned long flags = 0;
int ret = 0; int ret = 0;
/* Check if the flash read request is valid */ /* Fill the magic value */
if (eeprom->magic != (bnad->pcidev->vendor | eeprom->magic = bnad->pcidev->vendor | (bnad->pcidev->device << 16);
(bnad->pcidev->device << 16)))
return -EFAULT;
/* Query the flash partition based on the offset */ /* Query the flash partition based on the offset */
flash_part = bnad_get_flash_partition_by_offset(bnad, flash_part = bnad_get_flash_partition_by_offset(bnad,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment