Commit dd51d3a3 authored by Maxime Ripard's avatar Maxime Ripard

drm/vc4: hdmi: Fix hdmi_enable_4kp60 detection

In order to support higher HDMI frequencies, users have to set the
hdmi_enable_4kp60 parameter in their config.txt file.

We were detecting this so far by calling clk_round_rate() on the core
clock with the frequency we're supposed to run at when one of those
modes is enabled. Whether or not the parameter was enabled could then be
inferred by the returned rate since the maximum clock rate reported by
the firmware was one of the side effect of setting that parameter.

However, the recent clock rework we did changed what clk_round_rate()
was returning to always return the minimum allowed, and thus this test
wasn't reliable anymore.

Let's use the new clk_get_max_rate() function to reliably determine the
maximum rate allowed on that clock and fix the 4k@60Hz output.

Fixes: e9d6cea2 ("clk: bcm: rpi: Run some clocks at the minimum rate allowed")
Reviewed-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
Link: https://lore.kernel.org/r/20220815-rpi-fix-4k-60-v5-4-fe9e7ac8b111@cerno.techSigned-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
parent 40c31955
...@@ -46,6 +46,7 @@ ...@@ -46,6 +46,7 @@
#include <linux/pm_runtime.h> #include <linux/pm_runtime.h>
#include <linux/rational.h> #include <linux/rational.h>
#include <linux/reset.h> #include <linux/reset.h>
#include <soc/bcm2835/raspberrypi-clocks.h>
#include <sound/dmaengine_pcm.h> #include <sound/dmaengine_pcm.h>
#include <sound/hdmi-codec.h> #include <sound/hdmi-codec.h>
#include <sound/pcm_drm_eld.h> #include <sound/pcm_drm_eld.h>
...@@ -3429,7 +3430,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data) ...@@ -3429,7 +3430,7 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
if (variant->max_pixel_clock == 600000000) { if (variant->max_pixel_clock == 600000000) {
struct vc4_dev *vc4 = to_vc4_dev(drm); struct vc4_dev *vc4 = to_vc4_dev(drm);
long max_rate = clk_round_rate(vc4->hvs->core_clk, 550000000); unsigned int max_rate = rpi_firmware_clk_get_max_rate(vc4->hvs->core_clk);
if (max_rate < 550000000) if (max_rate < 550000000)
vc4_hdmi->disable_4kp60 = true; vc4_hdmi->disable_4kp60 = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment