Commit dfea1898 authored by Elbert Mai's avatar Elbert Mai Committed by Greg Kroah-Hartman

usb: Clarify expected behavior of dev_bin_attrs_are_visible()

The commit "usb: Export BOS descriptor to sysfs" added a binary attribute
group to sysfs. It doesn't check if the descriptors attribute should be
visible, which is by design and not an oversight. Update a comment so that
it better explains this in the dev_bin_attrs_are_visible() function.
Signed-off-by: default avatarElbert Mai <code@elbertmai.com>
Link: https://lore.kernel.org/r/20240306001503.313028-1-code@elbertmai.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 28cbed49
......@@ -929,8 +929,11 @@ static umode_t dev_bin_attrs_are_visible(struct kobject *kobj,
struct device *dev = kobj_to_dev(kobj);
struct usb_device *udev = to_usb_device(dev);
/* All USB devices have a device descriptor, so the descriptors
* attribute always exists. No need to check for its visibility.
/*
* There's no need to check if the descriptors attribute should
* be visible because all devices have a device descriptor. The
* bos_descriptors attribute should be visible if and only if
* the device has a BOS, so check if it exists here.
*/
if (a == &bin_attr_bos_descriptors) {
if (udev->bos == NULL)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment