Commit e250fab6 authored by YueHaibing's avatar YueHaibing Committed by Marcel Holtmann

Bluetooth: 6lowpan: Fix debugfs_simple_attr.cocci warnings

Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
for debugfs files.

Semantic patch information:
Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
imposes some significant overhead as compared to
DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().

Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 5c0a1001
...@@ -1108,8 +1108,8 @@ static int lowpan_enable_get(void *data, u64 *val) ...@@ -1108,8 +1108,8 @@ static int lowpan_enable_get(void *data, u64 *val)
return 0; return 0;
} }
DEFINE_SIMPLE_ATTRIBUTE(lowpan_enable_fops, lowpan_enable_get, DEFINE_DEBUGFS_ATTRIBUTE(lowpan_enable_fops, lowpan_enable_get,
lowpan_enable_set, "%llu\n"); lowpan_enable_set, "%llu\n");
static ssize_t lowpan_control_write(struct file *fp, static ssize_t lowpan_control_write(struct file *fp,
const char __user *user_buffer, const char __user *user_buffer,
...@@ -1278,9 +1278,10 @@ static struct notifier_block bt_6lowpan_dev_notifier = { ...@@ -1278,9 +1278,10 @@ static struct notifier_block bt_6lowpan_dev_notifier = {
static int __init bt_6lowpan_init(void) static int __init bt_6lowpan_init(void)
{ {
lowpan_enable_debugfs = debugfs_create_file("6lowpan_enable", 0644, lowpan_enable_debugfs = debugfs_create_file_unsafe("6lowpan_enable",
bt_debugfs, NULL, 0644, bt_debugfs,
&lowpan_enable_fops); NULL,
&lowpan_enable_fops);
lowpan_control_debugfs = debugfs_create_file("6lowpan_control", 0644, lowpan_control_debugfs = debugfs_create_file("6lowpan_control", 0644,
bt_debugfs, NULL, bt_debugfs, NULL,
&lowpan_control_fops); &lowpan_control_fops);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment