Commit e2858fa6 authored by Alex Dewar's avatar Alex Dewar Committed by Mauro Carvalho Chehab

media: staging: media: atomisp: Don't do unnecessary zeroing of memory

In a few places in pci/sh_css_params.c, memset is used to zero memory
immediately before it is freed. As none of these structs appear to
contain sensitive information, just remove the calls to memset.
Suggested-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 9e76f2cf
...@@ -4378,7 +4378,6 @@ ia_css_3a_statistics_free(struct ia_css_3a_statistics *me) ...@@ -4378,7 +4378,6 @@ ia_css_3a_statistics_free(struct ia_css_3a_statistics *me)
if (me) { if (me) {
kvfree(me->rgby_data); kvfree(me->rgby_data);
kvfree(me->data); kvfree(me->data);
memset(me, 0, sizeof(struct ia_css_3a_statistics));
kvfree(me); kvfree(me);
} }
} }
...@@ -4417,7 +4416,6 @@ ia_css_dvs_statistics_free(struct ia_css_dvs_statistics *me) ...@@ -4417,7 +4416,6 @@ ia_css_dvs_statistics_free(struct ia_css_dvs_statistics *me)
if (me) { if (me) {
kvfree(me->hor_proj); kvfree(me->hor_proj);
kvfree(me->ver_proj); kvfree(me->ver_proj);
memset(me, 0, sizeof(struct ia_css_dvs_statistics));
kvfree(me); kvfree(me);
} }
} }
...@@ -4459,7 +4457,6 @@ ia_css_dvs_coefficients_free(struct ia_css_dvs_coefficients *me) ...@@ -4459,7 +4457,6 @@ ia_css_dvs_coefficients_free(struct ia_css_dvs_coefficients *me)
if (me) { if (me) {
kvfree(me->hor_coefs); kvfree(me->hor_coefs);
kvfree(me->ver_coefs); kvfree(me->ver_coefs);
memset(me, 0, sizeof(struct ia_css_dvs_coefficients));
kvfree(me); kvfree(me);
} }
} }
...@@ -4551,7 +4548,6 @@ ia_css_dvs2_statistics_free(struct ia_css_dvs2_statistics *me) ...@@ -4551,7 +4548,6 @@ ia_css_dvs2_statistics_free(struct ia_css_dvs2_statistics *me)
kvfree(me->ver_prod.odd_imag); kvfree(me->ver_prod.odd_imag);
kvfree(me->ver_prod.even_real); kvfree(me->ver_prod.even_real);
kvfree(me->ver_prod.even_imag); kvfree(me->ver_prod.even_imag);
memset(me, 0, sizeof(struct ia_css_dvs2_statistics));
kvfree(me); kvfree(me);
} }
} }
...@@ -4635,7 +4631,6 @@ ia_css_dvs2_coefficients_free(struct ia_css_dvs2_coefficients *me) ...@@ -4635,7 +4631,6 @@ ia_css_dvs2_coefficients_free(struct ia_css_dvs2_coefficients *me)
kvfree(me->ver_coefs.odd_imag); kvfree(me->ver_coefs.odd_imag);
kvfree(me->ver_coefs.even_real); kvfree(me->ver_coefs.even_real);
kvfree(me->ver_coefs.even_imag); kvfree(me->ver_coefs.even_imag);
memset(me, 0, sizeof(struct ia_css_dvs2_coefficients));
kvfree(me); kvfree(me);
} }
} }
...@@ -4710,7 +4705,6 @@ ia_css_dvs2_6axis_config_free(struct ia_css_dvs_6axis_config *dvs_6axis_config) ...@@ -4710,7 +4705,6 @@ ia_css_dvs2_6axis_config_free(struct ia_css_dvs_6axis_config *dvs_6axis_config)
kvfree(dvs_6axis_config->ycoords_y); kvfree(dvs_6axis_config->ycoords_y);
kvfree(dvs_6axis_config->xcoords_uv); kvfree(dvs_6axis_config->xcoords_uv);
kvfree(dvs_6axis_config->ycoords_uv); kvfree(dvs_6axis_config->ycoords_uv);
memset(dvs_6axis_config, 0, sizeof(struct ia_css_dvs_6axis_config));
kvfree(dvs_6axis_config); kvfree(dvs_6axis_config);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment