Commit e34d0497 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Bjorn Andersson

arm64: dts: qcom: sm7225-fp4: Revert "arm64: dts: qcom: sm7225-fairphone-fp4: Add AW8695 haptics"

This reverts commit 413821b7 because it
was never reviewed, was buggy (report from kernel test robot:
https://lore.kernel.org/all/202204090333.QZXMI2tu-lkp@intel.com/) and
used undocumented, broken bindings.  Half of the properties in this
device are questioned, thus adding DTS node causes only errors and does
not make the device usable without the bindings and driver part:

  sm7225-fairphone-fp4.dtb: haptics@5a: failed to match any schema with compatible: ['awinic,aw8695']
  sm7225-fairphone-fp4.dtb: haptics@5a: awinic,tset: b'\x12' is not of type 'object', 'array', 'boolean', 'null'
  sm7225-fairphone-fp4.dtb: haptics@5a: awinic,r-spare: b'h' is not of type 'object', 'array', 'boolean', 'null'

Since bindings were abandoned (4 months since review), revert the commit
to avoid false sense of supporting something which is not supported.

Cc: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Acked-by: default avatarKonrad Dybcio <konrad.dybcio@linaro.org>
Acked-by: default avatarLuca Weiss <luca.weiss@fairphone.com>
Link: https://lore.kernel.org/r/20230827122842.63741-3-krzysztof.kozlowski@linaro.orgSigned-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 50888774
......@@ -387,36 +387,10 @@ &i2c8 {
};
&i2c10 {
clock-frequency = <400000>;
status = "okay";
/* PM8008 PMIC @ 8 and 9 */
/* PX8618 @ 26 */
/* SMB1395 PMIC @ 34 */
haptics@5a {
compatible = "awinic,aw8695";
reg = <0x5a>;
interrupts-extended = <&tlmm 85 IRQ_TYPE_EDGE_FALLING>;
reset-gpios = <&tlmm 90 GPIO_ACTIVE_HIGH>;
awinic,f0-preset = <2350>;
awinic,f0-coefficient = <260>;
awinic,f0-calibration-percent = <7>;
awinic,drive-level = <125>;
awinic,f0-detection-play-time = <5>;
awinic,f0-detection-wait-time = <3>;
awinic,f0-detection-repeat = <2>;
awinic,f0-detection-trace = <15>;
awinic,boost-debug = /bits/ 8 <0x30 0xeb 0xd4>;
awinic,tset = /bits/ 8 <0x12>;
awinic,r-spare = /bits/ 8 <0x68>;
awinic,bemf-upper-threshold = <4104>;
awinic,bemf-lower-threshold = <1016>;
};
/* awinic,aw8695 @ 5a */
};
&ipa {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment