Commit eb2b9874 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by David S. Miller

liquidio: lio_main: remove unnecessary static in setup_io_queues()

Remove unnecessary static on local variables cpu_id_modulus and cpu_id.
Such variables are initialized before being used, on every execution
path throughout the function. The static has no benefit and, removing
it reduces the object file size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

In the following log you can see a significant difference in the object
file size. Also, there is a significant difference in the bss segment.
This log is the output of the size command, before and after the code
change:

before:
   text    data     bss     dec     hex filename
  78689   15272   27808  121769   1dba9 drivers/net/ethernet/cavium/liquidio/lio_main.o

after:
   text    data     bss     dec     hex filename
  78667   15128   27680  121475   1da83 drivers/net/ethernet/cavium/liquidio/lio_main.o
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: default avatarFelix Manlunas <felix.manlunas@cavium.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 93fe07e5
...@@ -2544,8 +2544,8 @@ static inline int setup_io_queues(struct octeon_device *octeon_dev, ...@@ -2544,8 +2544,8 @@ static inline int setup_io_queues(struct octeon_device *octeon_dev,
{ {
struct octeon_droq_ops droq_ops; struct octeon_droq_ops droq_ops;
struct net_device *netdev; struct net_device *netdev;
static int cpu_id; int cpu_id;
static int cpu_id_modulus; int cpu_id_modulus;
struct octeon_droq *droq; struct octeon_droq *droq;
struct napi_struct *napi; struct napi_struct *napi;
int q, q_no, retval = 0; int q, q_no, retval = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment