Commit ec9230b1 authored by Yonghong Song's avatar Yonghong Song Committed by Daniel Borkmann

selftests/bpf: Fix a selftest compilation error with CONFIG_SMP=n

Kernel test robot reported bpf selftest build failure when CONFIG_SMP
is not set. The error message looks below:

  >> progs/rcu_read_lock.c:256:34: error: no member named 'last_wakee' in 'struct task_struct'
             last_wakee = task->real_parent->last_wakee;
                          ~~~~~~~~~~~~~~~~~  ^
     1 error generated.

When CONFIG_SMP is not set, the field 'last_wakee' is not available in struct
'task_struct'. Hence the above compilation failure. To fix the issue, let us
choose another field 'group_leader' which is available regardless of
CONFIG_SMP set or not.

Fixes: fe147956 ("bpf/selftests: Add selftests for new task kfuncs")
Fixes: 48671232 ("selftests/bpf: Add tests for bpf_rcu_read_lock()")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarDavid Vernet <void@manifault.com>
Signed-off-by: default avatarYonghong Song <yhs@fb.com>
Signed-off-by: default avatarAndrii Nakryiko <andrii@kernel.org>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarDavid Vernet <void@manifault.com>
Link: https://lore.kernel.org/bpf/20221213012224.379581-1-yhs@fb.com
parent d2b497a9
...@@ -288,13 +288,13 @@ int nested_rcu_region(void *ctx) ...@@ -288,13 +288,13 @@ int nested_rcu_region(void *ctx)
SEC("?fentry.s/" SYS_PREFIX "sys_getpgid") SEC("?fentry.s/" SYS_PREFIX "sys_getpgid")
int task_untrusted_non_rcuptr(void *ctx) int task_untrusted_non_rcuptr(void *ctx)
{ {
struct task_struct *task, *last_wakee; struct task_struct *task, *group_leader;
task = bpf_get_current_task_btf(); task = bpf_get_current_task_btf();
bpf_rcu_read_lock(); bpf_rcu_read_lock();
/* the pointer last_wakee marked as untrusted */ /* the pointer group_leader marked as untrusted */
last_wakee = task->real_parent->last_wakee; group_leader = task->real_parent->group_leader;
(void)bpf_task_storage_get(&map_a, last_wakee, 0, 0); (void)bpf_task_storage_get(&map_a, group_leader, 0, 0);
bpf_rcu_read_unlock(); bpf_rcu_read_unlock();
return 0; return 0;
} }
......
...@@ -73,7 +73,7 @@ int BPF_PROG(task_kfunc_acquire_trusted_walked, struct task_struct *task, u64 cl ...@@ -73,7 +73,7 @@ int BPF_PROG(task_kfunc_acquire_trusted_walked, struct task_struct *task, u64 cl
struct task_struct *acquired; struct task_struct *acquired;
/* Can't invoke bpf_task_acquire() on a trusted pointer obtained from walking a struct. */ /* Can't invoke bpf_task_acquire() on a trusted pointer obtained from walking a struct. */
acquired = bpf_task_acquire(task->last_wakee); acquired = bpf_task_acquire(task->group_leader);
bpf_task_release(acquired); bpf_task_release(acquired);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment