Commit f7b1a8dc authored by Axel Lin's avatar Axel Lin Committed by Mark Brown

regulator: s2mpa01: Don't check enable_shift before setting enable ramp rate

Current code misses updating the register when enable_shift is 0.
e.g. S2MPA01_BUCK4_RAMP_EN_SHIFT is 0.
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Acked-by: default avatarSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent 5481b348
...@@ -192,13 +192,11 @@ static int s2mpa01_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay) ...@@ -192,13 +192,11 @@ static int s2mpa01_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
if (!ramp_enable) if (!ramp_enable)
goto ramp_disable; goto ramp_disable;
if (enable_shift) { ret = regmap_update_bits(rdev->regmap, S2MPA01_REG_RAMP1,
ret = regmap_update_bits(rdev->regmap, S2MPA01_REG_RAMP1, 1 << enable_shift, 1 << enable_shift);
1 << enable_shift, 1 << enable_shift); if (ret) {
if (ret) { dev_err(&rdev->dev, "failed to enable ramp rate\n");
dev_err(&rdev->dev, "failed to enable ramp rate\n"); return ret;
return ret;
}
} }
ramp_val = get_ramp_delay(ramp_delay); ramp_val = get_ramp_delay(ramp_delay);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment