Commit fbd2d733 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thierry Reding

pwm: lpc18xx-sct: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThierry Reding <thierry.reding@gmail.com>
parent ed60a877
...@@ -449,7 +449,7 @@ static int lpc18xx_pwm_probe(struct platform_device *pdev) ...@@ -449,7 +449,7 @@ static int lpc18xx_pwm_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int lpc18xx_pwm_remove(struct platform_device *pdev) static void lpc18xx_pwm_remove(struct platform_device *pdev)
{ {
struct lpc18xx_pwm_chip *lpc18xx_pwm = platform_get_drvdata(pdev); struct lpc18xx_pwm_chip *lpc18xx_pwm = platform_get_drvdata(pdev);
u32 val; u32 val;
...@@ -461,8 +461,6 @@ static int lpc18xx_pwm_remove(struct platform_device *pdev) ...@@ -461,8 +461,6 @@ static int lpc18xx_pwm_remove(struct platform_device *pdev)
val | LPC18XX_PWM_CTRL_HALT); val | LPC18XX_PWM_CTRL_HALT);
clk_disable_unprepare(lpc18xx_pwm->pwm_clk); clk_disable_unprepare(lpc18xx_pwm->pwm_clk);
return 0;
} }
static struct platform_driver lpc18xx_pwm_driver = { static struct platform_driver lpc18xx_pwm_driver = {
...@@ -471,7 +469,7 @@ static struct platform_driver lpc18xx_pwm_driver = { ...@@ -471,7 +469,7 @@ static struct platform_driver lpc18xx_pwm_driver = {
.of_match_table = lpc18xx_pwm_of_match, .of_match_table = lpc18xx_pwm_of_match,
}, },
.probe = lpc18xx_pwm_probe, .probe = lpc18xx_pwm_probe,
.remove = lpc18xx_pwm_remove, .remove_new = lpc18xx_pwm_remove,
}; };
module_platform_driver(lpc18xx_pwm_driver); module_platform_driver(lpc18xx_pwm_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment