Commit fcca143d authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller

rtnetlink: fix error return code in rtnl_link_fill()

Fix to return a negative error code from the error handling case
instead of 0(possible overwrite to 0 by ops->fill_xstats call),
as returned elsewhere in this function.
Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 14109a59
...@@ -496,8 +496,10 @@ static int rtnl_link_fill(struct sk_buff *skb, const struct net_device *dev) ...@@ -496,8 +496,10 @@ static int rtnl_link_fill(struct sk_buff *skb, const struct net_device *dev)
} }
if (ops->fill_info) { if (ops->fill_info) {
data = nla_nest_start(skb, IFLA_INFO_DATA); data = nla_nest_start(skb, IFLA_INFO_DATA);
if (data == NULL) if (data == NULL) {
err = -EMSGSIZE;
goto err_cancel_link; goto err_cancel_link;
}
err = ops->fill_info(skb, dev); err = ops->fill_info(skb, dev);
if (err < 0) if (err < 0)
goto err_cancel_data; goto err_cancel_data;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment