1. 23 Jan, 2008 15 commits
    • Tejun Heo's avatar
      libata: implement ATA_DFLAG_DUBIOUS_XFER · 00115e0f
      Tejun Heo authored
      ATA_DFLAG_DUBIOUS_XFER is set whenever data transfer speed or method
      changes and gets cleared when data transfer command succeeds in the
      newly configured transfer mode.
      
      This will be used to improve speed down logic.
      
      Signed-off-by: Tejun Heo <htejun@gmail.com<
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      00115e0f
    • Tejun Heo's avatar
      libata: adjust speed down rules · 663f99b8
      Tejun Heo authored
      Speed down rules were too conservative.  Adjust them a bit.
      
      * More than 10 timeouts can't happen in 5 minutes as command timeout
        is 30secs.  Lower the limit for rule #1 to 6.
      
      * 10 timeouts is too high for rule #3 too.  Lower it to 6.
      
      * SATAPI can benefit from falling back to PIO too.  Allow SATAPI
        devices to fall back to PIO.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      663f99b8
    • Tejun Heo's avatar
      libata: clean up EH speed down implementation · 3884f7b0
      Tejun Heo authored
      Clean up EH speed down implementation.
      
      * is_io boolean variable is replaced eflags.  is_io is ATA_EFLAG_IS_IO.
      
      * Error categories now have names.
      
      * Better comments.
      
      * Reorder 5min and 10min rules in ata_eh_speed_down_verdict()
      
      * Use local variable @link to cache @dev->link in ata_eh_speed_down()
      
      These changes are to improve readability and ease further changes.
      This patch doesn't introduce any behavior change.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      3884f7b0
    • Tejun Heo's avatar
      libata: move ata_set_mode() to libata-eh.c · 6f1d1e3a
      Tejun Heo authored
      Move ata_set_mode() to libata-eh.c.  ata_set_mode() is surely an EH
      action and will be more tightly coupled with the rest of error
      handling.  Move it to libata-eh.c.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      6f1d1e3a
    • Tejun Heo's avatar
      libata: factor out ata_eh_schedule_probe() · 02c05a27
      Tejun Heo authored
      Factor out ata_eh_schedule_probe() from ata_eh_handle_dev_fail() and
      ata_eh_recover().  This is to improve maintainability and make future
      changes easier.
      
      In the previous revision, ata_dev_enabled() test was accidentally
      dropped while factoring out.  This problem was spotted by Bartlomiej.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      02c05a27
    • Tejun Heo's avatar
      libata: implement protocol tests · 405e66b3
      Tejun Heo authored
      Implement protocol tests - ata_is_atapi(), ata_is_nodata(),
      ata_is_pio(), ata_is_dma(), ata_is_ncq() and ata_is_data() and use
      them to replace is_atapi_taskfile() and hard coded protocol tests.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      405e66b3
    • Tejun Heo's avatar
      libata: rearrange ATA_DFLAG_* · f20ded38
      Tejun Heo authored
      Area for DFLAGs which are cleared on INIT is full.  Extend it by 8
      bits.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      f20ded38
    • Jeff Garzik's avatar
      libata: checkpatch fixes · 11b7becc
      Jeff Garzik authored
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      11b7becc
    • Tejun Heo's avatar
      ahci: update PCS programming · 49f29090
      Tejun Heo authored
      For intel ones, ahci unconditionally OR'd 0xf to PCS.  This isn't
      correct for the following cases.
      
      * ich6/7m's which only implement P0 and P2 (0xf works fine tho)
      
      * ich8/9's which have six ports and needs 0x3f to enable all ports
      
      This patch updates PCS programming such that...
      
      * port_map determined by ahci_save_initial_config() is OR'd instead of 0xf
      
      * PCS is updated only if necessary (there are turned off enable bits)
      
      port_map is determined from PORTS_IMPL PCI register which is
      implemented as write or write-once register.  If the register isn't
      programmed, ahci automatically generates it from number of ports,
      which is good enough for PCS programming.  ICH6/7M are probably the
      only ones where non-contiguous enable bits are necessary && PORTS_IMPL
      isn't programmed properly but they're proven to work reliably with 0xf
      anyway.
      Signed-off-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      49f29090
    • Alan Cox's avatar
      pata_ninja32: Cardbus ATA initial support · 51dbd490
      Alan Cox authored
      Lots of work needed to bring it up to scratch but it does work so you can
      now use the card. That makes it at least useful, especially as the other
      cardbus cards are usually INIC162x which aren't yet supported well.
      Signed-off-by: default avatarAlan Cox <alan@redhat.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      51dbd490
    • Alan Cox's avatar
      libata-sff: tf_load · 76548eda
      Alan Cox authored
      Jeff said he preferred that the SFF tf_load followed the spec and we
      documented that anyone who needed different overrode it, rather than it
      using the ->check_status methods. No driver relies on the current behaviour.
      Signed-off-by: default avatarAlan Cox <alan@redhat.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      76548eda
    • Alan Cox's avatar
      libata: IORDY handling · b9f8ab2d
      Alan Cox authored
      I believe this version meets all Sergei's objections
      
      Correct the logic for when we issue a set features for transfer mode
      
      - If the device has IORDY and the controller has IORDY - set the mode
      - If the device has IORDY and the controller does not - turn IORDY off
      - If neither has IORDY do nothing
      Signed-off-by: default avatarAlan Cox <alan@redhat.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      b9f8ab2d
    • Shaohua Li's avatar
      libata-acpi: add ACPI _PSx method · bd3adca5
      Shaohua Li authored
      ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx
      methods. As recently most PATA drivers use libata, this patch adds _PSx
      method support in libata. ACPI spec doesn't mention if SATA requires the
      same _PSx method.
      Signed-off-by: default avatarShaohua Li <shaohua.li@intel.com>
      Acked-by: default avatarLen Brown <len.brown@intel.com>
      Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
      bd3adca5
    • Alan Cox's avatar
      libata: Disable ATA8-ACS proposed Trusted Computing features by default · ae8d4ee7
      Alan Cox authored
      Historically word 48 in the identify data was used to mean 32bit I/O
      was supported for VLB IDE etc. ATA8 reassigns this word to the Trusted
      Computing Group, where it is used for TCG features. This means that
      an ATA8 TCG drive is going to trigger 32bit I/O on some systems which
      will be funny.
      
      Anyway we need to sort this out ready for ATA8 so:
      - Reorder the ata.h header a bit so the ata_version function occurs early
        in it
      - Make dword_io check the ATA version
      - Add an ATA8 version checking TCG presence test
      
      While we are at it the current drafts have a flaw where it may not be
      possible to disable TCG features at boot (and opt out of the trusted
      model) as TCG intends because it relies on presence of a different
      optional feature (DCS). Handle this in software by refusing the TCG
      commands if libata.allow_tpm is not set. (We must make it possible
      as some environments such as proprietary VDR devices will doubtless
      want to use it to lock up content)
      
      Finally as with CPRM print a warning so that the user knows they may
      not be able to full access and use the device.
      Signed-off-by: default avatarAlan Cox <alan@redhat.com>
      ae8d4ee7
    • Peter Schwenke's avatar
      ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list. · ffe188dd
      Peter Schwenke authored
      Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.  Matt
      Piermarini reported and provided the M6 patch.  This is from OSDL bug 7780.
      Signed-off-by: default avatarPeter Schwenke <peter@bluetoad.com.au>
      Cc: Matt Piermarini <mattpiermarini@yahoo.com>
      Acked-by: default avatarTejun Heo <htejun@gmail.com>
      Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
      ffe188dd
  2. 22 Jan, 2008 24 commits
  3. 21 Jan, 2008 1 commit