1. 28 Oct, 2012 25 commits
    • Mauro Carvalho Chehab's avatar
      [media] anysee: fix a warning · 03ad9fe4
      Mauro Carvalho Chehab authored
      drivers/media/usb/dvb-usb-v2/anysee.c:1179:5: warning: 'tmp' may be used uninitialized in this function [-Wmaybe-uninitialized]
      
      Cc: Antti Palosaari <crope@iki.fi>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      03ad9fe4
    • Mauro Carvalho Chehab's avatar
      [media] tua9001: fix a warning · 59e54059
      Mauro Carvalho Chehab authored
      drivers/media/tuners/tua9001.c:211:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
      
      Cc: Antti Palosaari <crope@iki.fi>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      59e54059
    • Mauro Carvalho Chehab's avatar
    • Mauro Carvalho Chehab's avatar
      [media] fmdrv: better define fmdbg() macro to avoid warnings · 7226d8eb
      Mauro Carvalho Chehab authored
      drivers/media/radio/wl128x/fmdrv_common.c:1619:47: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      7226d8eb
    • Mauro Carvalho Chehab's avatar
      [media] tlg2300: index is unsigned, so never below zero · 1ab90587
      Mauro Carvalho Chehab authored
      drivers/media/usb/tlg2300/pd-video.c:891:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/usb/tlg2300/pd-video.c:926:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      
      Cc: Huang Shijie <shijie8@gmail.com>
      Cc: Kang Yong <kangyong@telegent.com>
      Cc: Zhang Xiaobing <xbzhang@telegent.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      1ab90587
    • Mauro Carvalho Chehab's avatar
      [media] m2m-deinterlace: remove unused vars · 2869a318
      Mauro Carvalho Chehab authored
      drivers/media/platform/m2m-deinterlace.c:229:15: warning: variable 'd_size' set but not used [-Wunused-but-set-variable]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      2869a318
    • Mauro Carvalho Chehab's avatar
      [media] meye: fix a warning · 83fa235b
      Mauro Carvalho Chehab authored
      drivers/media/pci/meye/meye.c:1948:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      83fa235b
    • Mauro Carvalho Chehab's avatar
      [media] saa7134,saa7164: warning: comparison of unsigned fixes · 3eeba4a7
      Mauro Carvalho Chehab authored
      drivers/media/pci/saa7134/saa7134-core.c:947:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/saa7164/saa7164-core.c:413:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/pci/saa7164/saa7164-core.c:489:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/pci/saa7134/saa7134-video.c:2514:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      3eeba4a7
    • Mauro Carvalho Chehab's avatar
      [media] ngene: better comment unused code to avoid warnings · 2827a440
      Mauro Carvalho Chehab authored
      get rid of a few warnings about empty body:
      drivers/media/pci/ngene/ngene-core.c:756:3: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
      drivers/media/pci/ngene/ngene-cards.c:429:5: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
      Those are due to some commented code.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      2827a440
    • Mauro Carvalho Chehab's avatar
      [media] soc_camera/ov2640: Don't use a temp var for an unused value · ba400892
      Mauro Carvalho Chehab authored
      drivers/media/i2c/soc_camera/ov2640.c:899:32: warning: variable 'win' set but not used [-Wunused-but-set-variable]
      
      Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      ba400892
    • Mauro Carvalho Chehab's avatar
      [media] dvb-frontends: get rid of some "always false" warnings · 830e4b55
      Mauro Carvalho Chehab authored
      On gcc, enums are generally unsigned, except if a negative value
      is declared. Due to that, warnings may happen there:
      drivers/media/dvb-frontends/cx22700.c:142:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/cx22700.c:155:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/cx24123.c:341:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/l64781.c:183:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/l64781.c:187:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/mt312.c:552:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/mt312.c:560:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      As other compilers might be using signed values, the better is to
      keep the checks there, casting the value to avoid the warning.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      830e4b55
    • Mauro Carvalho Chehab's avatar
      [media] drxk: get rid of some unused vars · 5a70972e
      Mauro Carvalho Chehab authored
      drivers/media/dvb-frontends/drxk_hard.c:68:13: warning: 'IsA1WithPatchCode' defined but not used [-Wunused-function]
      drivers/media/dvb-frontends/drxk_hard.c:73:13: warning: 'IsA1WithRomCode' defined but not used [-Wunused-function]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      5a70972e
    • Mauro Carvalho Chehab's avatar
      [media] dmxdev: fix a comparition of unsigned expression warning · 31becf09
      Mauro Carvalho Chehab authored
      drivers/media/dvb-core/dmxdev.c: In function 'dvb_dmxdev_pes_filter_set':
      drivers/media/dvb-core/dmxdev.c:880:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      31becf09
    • Mauro Carvalho Chehab's avatar
      [media] cx88: get rid of a warning at dprintk() macro · db613710
      Mauro Carvalho Chehab authored
      drivers/media/pci/cx88/cx88-mpeg.c: In function 'cx8802_mpeg_irq':
      drivers/media/pci/cx88/cx88-mpeg.c:419:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-mpeg.c: In function 'cx8802_irq':
      drivers/media/pci/cx88/cx88-mpeg.c:453:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-alsa.c: In function 'snd_cx88_create':
      drivers/media/pci/cx88/cx88-alsa.c:818:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-alsa.c:837:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-alsa.c: In function 'cx88_audio_initdev':
      drivers/media/pci/cx88/cx88-alsa.c:912:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_mbox_func':
      drivers/media/pci/cx88/cx88-blackbird.c:327:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:333:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:360:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_find_mailbox':
      drivers/media/pci/cx88/cx88-blackbird.c:421:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_load_firmware':
      drivers/media/pci/cx88/cx88-blackbird.c:444:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:451:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:453:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:459:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:466:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:487:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:492:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:503:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_initialize_codec':
      drivers/media/pci/cx88/cx88-blackbird.c:560:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:566:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:569:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      db613710
    • Mauro Carvalho Chehab's avatar
      [media] cx88: reorder inline to prevent a gcc warning · 34206439
      Mauro Carvalho Chehab authored
      drivers/media/pci/cx88/cx88.h:97:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88.h:103:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:649:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:654:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:659:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:664:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:684:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:695:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      34206439
    • Mauro Carvalho Chehab's avatar
      [media] dvb_frontend: Don't declare values twice at a table · e6ea0b91
      Mauro Carvalho Chehab authored
      drivers/media/dvb-core/dvb_frontend.c:1032:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1032:2: warning: (near initialization for 'dtv_cmds[36]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1033:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1033:2: warning: (near initialization for 'dtv_cmds[37]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1034:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1034:2: warning: (near initialization for 'dtv_cmds[38]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1035:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1035:2: warning: (near initialization for 'dtv_cmds[39]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1036:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1036:2: warning: (near initialization for 'dtv_cmds[40]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1037:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1037:2: warning: (near initialization for 'dtv_cmds[60]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1045:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1045:2: warning: (near initialization for 'dtv_cmds[46]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1051:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1051:2: warning: (near initialization for 'dtv_cmds[52]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1060:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1060:2: warning: (near initialization for 'dtv_cmds[61]') [-Woverride-init]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      e6ea0b91
    • Mauro Carvalho Chehab's avatar
      [media] go7007-v4l2: warning fix: index is unsigned, so it will never be below 0 · 902e4575
      Mauro Carvalho Chehab authored
      drivers/staging/media/go7007/go7007-v4l2.c: In function 'vidioc_qbuf':
      drivers/staging/media/go7007/go7007-v4l2.c:815:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      902e4575
    • Mauro Carvalho Chehab's avatar
      [media] dt3155v4l: vb2_queue_init() can now fail. Check is required · 067d8513
      Mauro Carvalho Chehab authored
      drivers/staging/media/dt3155v4l/dt3155v4l.c: In function 'dt3155_open':
      drivers/staging/media/dt3155v4l/dt3155v4l.c:399:17: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      067d8513
    • Mauro Carvalho Chehab's avatar
      [media] gspca: warning fix: index is unsigned, so it will never be below 0 · 3a70c3fb
      Mauro Carvalho Chehab authored
      drivers/media/usb/gspca/gspca.c: In function 'vidioc_querybuf':
      drivers/media/usb/gspca/gspca.c:1590:6: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      
      Cc: Hans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      3a70c3fb
    • Mauro Carvalho Chehab's avatar
      [media] jeilinj: fix return of the response code · 9825f376
      Mauro Carvalho Chehab authored
      drivers/media/usb/gspca/jeilinj.c: In function 'jlj_read1':
      drivers/media/usb/gspca/jeilinj.c:117:66: warning: parameter 'response' set but not used [-Wunused-but-set-parameter]
      The code still doesn't make much sense, as response is never tested
      there.
      
      Cc: Hans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      9825f376
    • Mauro Carvalho Chehab's avatar
      [media] gscpa: get rid of warning: suggest braces around empty body · ede4c3a5
      Mauro Carvalho Chehab authored
      There are hundreds of messages like this one, when GSPCA debug is
      disabled, when compiled with W=1:
      drivers/media/usb/gspca/spca500.c:725:46: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
      Get rid of it, especially as it might actually cause troubles on
      some places.
      
      Cc: Hans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      ede4c3a5
    • Mauro Carvalho Chehab's avatar
      [media] dib9000: get rid of warning: no previous prototype · 2e8c1e56
      Mauro Carvalho Chehab authored
      drivers/media/dvb-frontends/dib9000.h:100:5: warning: no previous prototype for 'dib9000_remove_slave_frontend' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      2e8c1e56
    • Mauro Carvalho Chehab's avatar
      [media] pwc-if: must check vb2_queue_init() success · eda94710
      Mauro Carvalho Chehab authored
      drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe':
      drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]
      In the past, it used to have a logic there at queue init that would
      BUG() on errors. This logic got removed. Drivers are now required
      to explicitly handle the queue initialization errors, or very bad
      things may happen.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      eda94710
    • Mauro Carvalho Chehab's avatar
      [media] pwc-if: get rid of warning: no previous prototype · 0dc6eb9f
      Mauro Carvalho Chehab authored
      drivers/media/usb/pwc/pwc-if.c:158:23: warning: no previous prototype for 'pwc_get_next_fill_buf' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      0dc6eb9f
    • Mauro Carvalho Chehab's avatar
      [media] pvrusb2: get rid of warning: no previous prototype · f4a51222
      Mauro Carvalho Chehab authored
      drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:199:5: warning: no previous prototype for 'pvr2_s_std' [-Wmissing-prototypes]
      drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:368:5: warning: no previous prototype for 'pvr2_s_frequency' [-Wmissing-prototypes]
      Acked-by: default avatarMike Isely <isely@pobox.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      f4a51222
  2. 27 Oct, 2012 15 commits