- 14 Feb, 2011 4 commits
-
-
Dan Williams authored
-
Dan Williams authored
-
Dan Williams authored
-
Anatolij Gustschin authored
Currently when two or more buffers are queued by the camera driver and so the double buffering is enabled in the idmac, we lose one frame comming from CSI since the reporting of arrival of the first frame is deferred by the DMAIC_7_EOF interrupt handler and reporting of the arrival of the last frame is not done at all. So when requesting N frames from the image sensor we actually receive N - 1 frames in user space. The reason for this behaviour is that the DMAIC_7_EOF interrupt handler misleadingly assumes that the CUR_BUF flag is pointing to the buffer used by the IDMAC. Actually it is not the case since the CUR_BUF flag will be flipped by the FSU when the FSU is sending the <TASK>_NEW_FRM_RDY signal when new frame data is delivered by the CSI. When sending this singal, FSU updates the DMA_CUR_BUF and the DMA_BUFx_RDY flags: the DMA_CUR_BUF is flipped, the DMA_BUFx_RDY is cleared, indicating that the frame data is beeing written by the IDMAC to the pointed buffer. DMA_BUFx_RDY is supposed to be set to the ready state again by the MCU, when it has handled the received data. DMAIC_7_CUR_BUF flag won't be flipped here by the IPU, so waiting for this event in the EOF interrupt handler is wrong. Actually there is no spurious interrupt as described in the comments, this is the valid DMAIC_7_EOF interrupt indicating reception of the frame from CSI. The patch removes code that waits for flipping of the DMAIC_7_CUR_BUF flag in the DMAIC_7_EOF interrupt handler. As the comment in the current code denotes, this waiting doesn't help anyway. As a result of this removal the reporting of the first arrived frame is not deferred to the time of arrival of the next frame and the drivers software flag 'ichan->active_buffer' is in sync with DMAIC_7_CUR_BUF flag, so the reception of all requested frames works. This has been verified on the hardware which is triggering the image sensor by the programmable state machine, allowing to obtain exact number of frames. On this hardware we do not tolerate losing frames. This patch also removes resetting the DMA_BUFx_RDY flags of all channels in ipu_disable_channel() since transfers on other DMA channels might be triggered by other running tasks and the buffers should always be ready for data sending or reception. Signed-off-by:
Anatolij Gustschin <agust@denx.de> Reviewed-by:
Guennadi Liakhovetski <g.liakhovetski@gmx.de> Tested-by:
Dan Williams <dan.j.williams@intel.com>
-
- 31 Jan, 2011 36 commits
-
-
Sascha Hauer authored
-
Sascha Hauer authored
-
Shawn Guo authored
As per the reference manual, bit "L" should be set while bit "C" should be cleared for the last buffer descriptor in the non-cyclic chain, so that sdma can stop trying to find the next BD and end the transfer. In case of sdma_prep_slave_sg(), BD_LAST needs to be set and BD_CONT be cleared for the last BD. Signed-off-by:
Shawn Guo <shawn.guo@freescale.com> Signed-off-by:
Sascha Hauer <s.hauer@pengutronix.de>
-
Shawn Guo authored
sdma_handle_channel_loop() is the handler of cyclic tx. One period success does not really mean the success of the tx. Instead of DMA_SUCCESS, DMA_IN_PROGRESS should be the one to tell. Signed-off-by:
-
Shawn Guo authored
The sdmac->status was designed to reflect the status of the tx, so simply return it in sdma_tx_status(). Then dma client can call dma_async_is_tx_complete() to know the status of the tx. Signed-off-by:
-
Shawn Guo authored
sdma_prep_dma_cyclic() sets sdmac->status to DMA_ERROR in err_out, and sdma_prep_slave_sg() needs to do the same. Otherwise, sdmac->status stays at DMA_IN_PROGRESS, which will make the function return immediately next time it gets called. Signed-off-by:
-
Shawn Guo authored
This is a leftover from the time that the driver did not have sdma_prep_dma_cyclic callback and implemented sound dma as a looped sg chain. And it can be removed now. Signed-off-by:
-
Sascha Hauer authored
The capabilities are device specific fields, not channel specific fields. Signed-off-by: -
Sascha Hauer authored
Signed-off-by: -
Sascha Hauer authored
Signed-off-by: -
Sascha Hauer authored
Signed-off-by: -
Sascha Hauer authored
We need channel 0 of the sdma engine for internal purposes. We accomplished this by calling dma_request_channel() in the probe function. This does not work when multiple dma engines are present which is the case when IPU support for i.MX31/35 is compiled in. So instead of registering channel 0 and reserving it afterwards simply do not register it in the first place. With this the dmaengine channel counting does not match sdma channel counting anymore, so we have to use sdma channel counting in the driver. Signed-off-by: -
Sascha Hauer authored
The capabilities are device specific fields, not channel specific fields. Signed-off-by: -
Sascha Hauer authored
This is bogus as the dmaengine core will overwrite this field. Signed-off-by: -
Sascha Hauer authored
This patch lets sdma_prep_slave_sg fail if the entries of an sg list do not start on multiples of the word size or if the lengths are not multiple of the word size. Also, catch the previously unhandled DMA_SLAVE_BUSWIDTH_8_BYTES and DMA_SLAVE_BUSWIDTH_UNDEFINED cases. Signed-off-by: -
Sascha Hauer authored
Signed-off-by: -
Rabin Vincent authored
Support cyclic transfers, which are useful for ALSA drivers. Acked-by:
Per Forlin <per.forlin@stericsson.com> Acked-by:
Jonas Aaberg <jonas.aberg@stericsson.com> Signed-off-by:
Rabin Vincent <rabin.vincent@stericsson.com> Signed-off-by:
Linus Walleij <linus.walleij@stericsson.com> Signed-off-by:
-
Rabin Vincent authored
The current implementation of DMA_TERMINATE_ALL leaves ongoing transfers running. Fix it. Acked-by:
-
Rabin Vincent authored
The DMA_SG cap is enabled on the wrong channel, and the pointers are repeatedly set incorrectly. Fix it and combine the ops settings to a common function. Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
These register writes are better placed in the main source file rather than ll.c. Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
The dmaengine framework has the API for this now. Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
Acked-by:
-
Rabin Vincent authored
The desc init code can be shared between the mem and slave prep routines. Acked-by:
-
Rabin Vincent authored
To simplify the code. Acked-by:
-
Rabin Vincent authored
Acked-by:
-
