1. 17 Dec, 2020 1 commit
    • Jiri Olsa's avatar
      tools build: Add missing libcap to test-all.bin target · 09d59c2f
      Jiri Olsa authored
      We're missing -lcap in test-all.bin target, so in case it's the only
      library missing (if more are missing test-all.bin fails anyway), we will
      falsely claim that we detected it and fail build, like:
      
        $ make
        ...
        Auto-detecting system features:
        ...                         dwarf: [ on  ]
        ...            dwarf_getlocations: [ on  ]
        ...                         glibc: [ on  ]
        ...                        libbfd: [ on  ]
        ...                libbfd-buildid: [ on  ]
        ...                        libcap: [ on  ]
        ...                        libelf: [ on  ]
        ...                       libnuma: [ on  ]
        ...        numa_num_possible_cpus: [ on  ]
        ...                       libperl: [ on  ]
        ...                     libpython: [ on  ]
        ...                     libcrypto: [ on  ]
        ...                     libunwind: [ on  ]
        ...            libdw-dwarf-unwind: [ on  ]
        ...                          zlib: [ on  ]
        ...                          lzma: [ on  ]
        ...                     get_cpuid: [ on  ]
        ...                           bpf: [ on  ]
        ...                        libaio: [ on  ]
        ...                       libzstd: [ on  ]
        ...        disassembler-four-args: [ on  ]
      
        ...
      
          CC       builtin-ftrace.o
      
        In file included from builtin-ftrace.c:29:
        util/cap.h:11:10: fatal error: sys/capability.h: No such file or directory
           11 | #include <sys/capability.h>
              |          ^~~~~~~~~~~~~~~~~~
        compilation terminated.
      
      Fixes: 74d5f3d0 ("tools build: Add capability-related feature detection")
      Signed-off-by: default avatarJiri Olsa <jolsa@kernel.org>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Igor Lubashev <ilubashe@akamai.com>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Michael Petlan <mpetlan@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lore.kernel.org/lkml/20201203230836.3751981-1-jolsa@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      09d59c2f
  2. 15 Dec, 2020 1 commit
    • Kajol Jain's avatar
      perf test: Fix metric parsing test · b2ce5dbc
      Kajol Jain authored
      Commit e1c92a7f ("perf tests: Add another metric parsing test") add
      another test for metric parsing. The test goes through all metrics
      compiled for arch within pmu events and try to parse them.
      
      Right now this test is failing in powerpc machine.
      
      Result in power9 platform:
      
        [command]# ./perf test 10
        10: PMU events                                                      :
        10.1: PMU event table sanity                                        : Ok
        10.2: PMU event map aliases                                         : Ok
        10.3: Parsing of PMU event table metrics                            : Skip (some metrics failed)
        10.4: Parsing of PMU event table metrics with fake PMUs             : FAILED!
      
      Issue is we are passing different runtime parameter value in
      "expr__find_other" and "expr__parse" function which is called from
      function `metric_parse_fake`.  And because of this parsing of hv-24x7
      metrics is failing.
      
        [command]# ./perf test 10 -vv
        .....
        hv_24x7/pm_mcs01_128b_rd_disp_port01,chip=1/ not found
        expr__parse failed
        test child finished with -1
        ---- end ----
        PMU events subtest 4: FAILED!
      
      This patch fix this issue and change runtime parameter value to '0' in
      expr__parse function.
      
      Result in power9 platform after this patch:
      
        [command]# ./perf test 10
        10: PMU events                                                      :
        10.1: PMU event table sanity                                        : Ok
        10.2: PMU event map aliases                                         : Ok
        10.3: Parsing of PMU event table metrics                            : Skip (some metrics failed)
        10.4: Parsing of PMU event table metrics with fake PMUs             : Ok
      
      Fixes: e1c92a7f ("perf tests: Add another metric parsing test")
      Signed-off-by: default avatarKajol Jain <kjain@linux.ibm.com>
      Acked-by: default avatarIan Rogers <irogers@google.com>
      Acked-by: default avatarJiri Olsa <jolsa@redhat.com>
      Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
      Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
      Link: http://lore.kernel.org/lkml/20201119152411.46041-1-kjain@linux.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      b2ce5dbc
  3. 30 Nov, 2020 33 commits
  4. 29 Nov, 2020 5 commits