- 21 Sep, 2010 4 commits
-
-
Jarkko Nikula authored
rtd->dev.init_name is set twice in soc_probe_dai_link. I removed the first assignement from dai_link->stream_name since then there won't be sysfs name changes and usually dai_link->name seems to fit anyway better for a sysfs directory name. Signed-off-by:
Jarkko Nikula <jhnikula@gmail.com> Acked-by:
Liam Girdwood <lrg@slimlogic.co.uk> Signed-off-by:
Mark Brown <broonie@opensource.wolfsonmicro.com>
-
Mark Brown authored
Let's not add the core controls twice. Signed-off-by:
-
Mark Brown authored
Helps with diagnostics. Signed-off-by:
-
Mark Brown authored
So machine drivers can see the declaration. Signed-off-by:
Jassi Brar <jassi.brar@samsung.com> Acked-by:
-
- 20 Sep, 2010 3 commits
-
-
Kuninori Morimoto authored
Current FSI driver had data push/pop functions. But the main operation of these 2 were very similar. This mean it is possible to merge these to 1 function. Signed-off-by:
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by:
-
Kuninori Morimoto authored
Current FSI driver is using data-length / width / number / offset for variables. But it was a very confusing name. This patch rename them to easy to understand, and add new functions for it. Signed-off-by:
-
Mark Brown authored
Standardise on 'wm8978' as the name for the CODEC. Reported-by:
Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by:
-
- 19 Sep, 2010 8 commits
-
-
Kuninori Morimoto authored
Signed-off-by:
-
Kuninori Morimoto authored
Signed-off-by:
-
Kuninori Morimoto authored
Signed-off-by:
-
Guennadi Liakhovetski authored
This patch fixes multiple bugs and a typo, occurred during the multi- component transition. Signed-off-by:
-
Guennadi Liakhovetski authored
Recent ASoC changes unified all PCM names, fix the platform code to match. Signed-off-by:
-
Guennadi Liakhovetski authored
The sh/siu ASoC driver doesn't compile because of a function defined static in the source and extern in a header. Remove the unneeded declaration in the header. Signed-off-by:
-
Mark Brown authored
-
Guennadi Liakhovetski authored
The clkdev API doesn't use .name and .id members of struct clk for clock lookup. Instead clocks should be added to a lookup list. Without this patch audio om the Migo-R board fails silently. Signed-off-by:
-
- 17 Sep, 2010 1 commit
-
-
Dzianis Kahanovich authored
Signed-off-by:
Dzianis Kahanovich <mahatma@eu.by> [Modified to move the location of the table] Signed-off-by:
-
- 16 Sep, 2010 5 commits
-
-
Kuninori Morimoto authored
Signed-off-by:
-
Kuninori Morimoto authored
Signed-off-by:
-
Mark Brown authored
List registered platforms in debugfs to improve debugability of machine drivers. Signed-off-by:
-
Mark Brown authored
Allow the user to inspect the list of registered DAIs at runtime to improve diagnostics for machine driver setup. Signed-off-by:
-
Mark Brown authored
Help with diagnostics for machine driver setup by listing all the registered CODECs in debugfs. Signed-off-by:
-
- 15 Sep, 2010 3 commits
-
-
Dimitris Papastamos authored
The WM8985 is a low power, high quality, feature-rich stereo CODEC designed for portable multimedia applications that require low power consumption and high quality audio. Signed-off-by:
Dimitris Papastamos <dp@opensource.wolfsonmicro.com> Acked-by:
-
Arnaud Patard (Rtp) authored
Like other coworkers, I'm about leave Mandriva/Edge-It so I'm changing my mail address to use my personal one. Signed-off-by:
Arnaud Patard <arnaud.patard@rtp-net.org> Signed-off-by:
Arnaud Patard <apatard@mandriva.com> Acked-by:
Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by:
-
Jarkko Nikula authored
This assignment is done by the snd_soc_register_codec so there is no need to redo it in probe function of a codec driver. Signed-off-by:
-
- 14 Sep, 2010 3 commits
-
-
Jassi Brar authored
Each of the two PCM controllers need to be registered during probe with appropriate 'name' of the dai driver. Signed-off-by:
-
Mark Brown authored
Since the SMDK64xx boards have two audio subsystems using the board name as the card name by itself isn't so user friendly as it might be. Signed-off-by:
-
Kuninori Morimoto authored
Signed-off-by:
-
- 11 Sep, 2010 3 commits
-
-
Seungwhan Youn authored
This patch modify FIFO_DIPSTICK value of PCM TX FIFO to be a optimal one. Privious value (0x20) did not support 'Almost_full' of PCM FIFO for the DMA request. Signed-off-by:
Seungwhan Youn <sw.youn@samsung.com> Acked-by:
-
Seungwhan Youn authored
When PCM capture, sound recorded abnormally because of RX FIFO threshold settings are missing. So, This patch modify PCM RX FIFO setting codes same as TX. And for DMA, if PCM RXFIFO_DIPSTICK is not '0', it doesn't effect to DMA request, because DMA refer RX_FIFO_EMPTY flag as the DMA request. Signed-off-by:
-
Dimitris Papastamos authored
This is a simple off-by-one bug, the size of the register cache is incorrectly set to the maximum register index. Fix it by adding one. Signed-off-by:
-
- 10 Sep, 2010 10 commits
-
-
Dimitris Papastamos authored
The reg_cache_size is the number of elements in the register cache, not the size of the cache itself. This is not a problem if the size of each element of the cache is 1 byte but it matters in any other case. Signed-off-by:
-
Axel Lin authored
Signed-off-by:
Axel Lin <axel.lin@gmail.com> Acked-by:
-
Kuninori Morimoto authored
This patch solve compile error when .config doesn't have CONFIG_SND_SOC which is needed for HDMI sound. It was reported by Guennadi as follows Besides, I think, this will not link without CONFIG_SND_SOC. Reported-by:
-
Kuninori Morimoto authored
This patch solve below report from Guennadi. But I didn't remove #include <sound/sh_fsi.h>. Because it have FSI_PORT_B define which is used on this file. > +#include <linux/platform_device.h> > +#include <sound/sh_fsi.h> > +#include <video/sh_mobile_hdmi.h> Now that everything is done with strings - do you still need these headers? Reported-by:
-
Kuninori Morimoto authored
This patch solve below report from Guennadi > /* External video parameter settings */ > static void hdmi_external_video_param(struct sh_hdmi *hdmi) > { > @@ -804,6 +862,11 @@ static int __init sh_hdmi_probe(struct platform_device *pdev) > return -ENOMEM; > } > > + ret = snd_soc_register_codec(&pdev->dev, > + &soc_codec_dev_sh_hdmi, &sh_hdmi_dai, 1); > + if (ret < 0) > + goto egetclk; > + > hdmi->dev = &pdev->dev; > > hdmi->hdmi_clk = clk_get(&pdev->dev, "ick"); NAK. This breaks the error path and has to be fixed. Firstly, please, use a new label like "esndreg," secondly, you have to add clk_disable(hdmi->hdmi_clk); erate: clk_put(hdmi->hdmi_clk); egetclk: + snd_soc_unregister_codec(&pdev->dev); +esndreg: mutex_destroy(&hdmi->mutex); kfree(hdmi); Reported-by: -
Kuninori Morimoto authored
This patch solve below report from Guennadi > +static struct snd_soc_dai_driver sh_hdmi_dai = { > + .name = "sh_mobile_hdmi-hifi", > + .playback = { > + .stream_name = "Playback", > + .channels_min = 1, Can it actually do mono? Maybe at probe time you could look at audio flags from your previous patch and, e.g., for SPDIF set channels_min to 2? > + .channels_max = 2, That's the "smallest max," yes. With some other interfaces (I2S, DSD) it can support up to 8 channels... > + .rates = SNDRV_PCM_RATE_8000_48000, Hm, in the datasheet I see supported frequencies 32kHz to 192kHz. And if you promise support for multiple frequencies, don't you want to implement .hw_params? Besides, not all of these frequencies will be available, depending on your supplied clock and your willingness to implement downsampling. Reported-by: -
Kuninori Morimoto authored
This patch solve below report from Guennadi 1) > +/* Audio source select */ > +#define HDMI_SRC_MASK (0xF << 0) > +#define HDMI_SRC_I2S (0 << 0) /* default */ > +#define HDMI_SRC_SPDIF (1 << 0) > +#define HDMI_SRC_DSD (2 << 0) > +#define HDMI_SRC_HBR (3 << 0) I would be more specific with these macro names, i.e., include "AUDIO" or "SND" or something similar in them, e.g., HDMI_AUDIO_SRC_I2S. 2) > + case HDMI_SRC_I2S: > + data = (0x0 << 3); > + break; > + case HDMI_SRC_SPDIF: > + data = (0x1 << 3); > + break; > + case HDMI_SRC_DSD: > + data = (0x2 << 3); > + break; > + case HDMI_SRC_HBR: > + data = (0x3 << 3); In all above cases parenthesis are superfluous. Reported-by:
-
Kuninori Morimoto authored
This patch solve below report from Guennadi 1) > - hdmi_write(hdmi, 0x00, HDMI_AUDIO_SETTING_1); > + switch (pdata->flags & HDMI_SRC_MASK) { > + default: > + /* FALL THROUGH */ I'm not sure I like the capitalisation here - no reason to shout;) 2) > +/************************************************************************ > + > + > + HDMI sound > + > + > +************************************************************************/ I don't think this comment deserves 7 lines of text, besides breaking the multiline comment style. If you think, one line like /* HDMI sound */ is not enough how about just /* * HDMI sound */ 3) > +/************************************************************************ > + > + > + HDMI video > + > + > +************************************************************************/ See above - 7 lines seem to be an overkill to me. Reported-by: -
Jassi Brar authored
The PCM controller platform devices are registered by the name 'samsung-pcm', so use the same in the CPU driver. Signed-off-by:
-
Jassi Brar authored
Drop the invalid -dai suffix appended to the Samsung AC97 CPU DAI. Signed-off-by:
-
