- 15 May, 2024 1 commit
-
-
Nathan Chancellor authored
When building without CONFIG_F2FS_FAULT_INJECTION, there is a warning from each file that includes f2fs.h because the stub for f2fs_build_fault_attr() is missing inline: In file included from fs/f2fs/segment.c:21: fs/f2fs/f2fs.h:4605:12: warning: 'f2fs_build_fault_attr' defined but not used [-Wunused-function] 4605 | static int f2fs_build_fault_attr(struct f2fs_sb_info *sbi, unsigned long rate, | ^~~~~~~~~~~~~~~~~~~~~ Add the missing inline to resolve all of the warnings for this configuration. Fixes: 4ed886b1 ("f2fs: check validation of fault attrs in f2fs_build_fault_attr()") Signed-off-by:Nathan Chancellor <nathan@kernel.org> Reviewed-by:
Chao Yu <chao@kernel.org> Signed-off-by:
Jaegeuk Kim <jaegeuk@kernel.org>
-
- 11 May, 2024 3 commits
-
-
Zhiguo Niu authored
After commit d7e9a903 ("f2fs: Support Block Size == Page Size"), Some comments are confused and just correct with block size is 4KB. Signed-off-by:
Zhiguo Niu <zhiguo.niu@unisoc.com> Signed-off-by:
-
Chao Yu authored
During gc_data_segment(), if inode state is abnormal, it missed to call iput(), fix it. Fixes: b73e5282 ("f2fs: reposition unlock_new_inode to prevent accessing invalid inode") Fixes: 9056d648 ("f2fs: fix to do sanity check on inode type during garbage collection") Signed-off-by:
-
Daeho Jeong authored
Following the semantic for dirty segments in checkpoint disabled mode, apply the same rule to dirty sections. Signed-off-by:
Daeho Jeong <daehojeong@google.com> Signed-off-by:
-
- 10 May, 2024 6 commits
-
-
Chao Yu authored
f2fs image may be corrupted after below testcase: - mkfs.f2fs -O extra_attr,compression -f /dev/vdb - mount /dev/vdb /mnt/f2fs - touch /mnt/f2fs/file - f2fs_io setflags compression /mnt/f2fs/file - dd if=/dev/zero of=/mnt/f2fs/file bs=4k count=4 - f2fs_io release_cblocks /mnt/f2fs/file - truncate -s 8192 /mnt/f2fs/file - umount /mnt/f2fs - fsck.f2fs /dev/vdb [ASSERT] (fsck_chk_inode_blk:1256) --> ino: 0x5 has i_blocks: 0x00000002, but has 0x3 blocks [FSCK] valid_block_count matching with CP [Fail] [0x4, 0x5] [FSCK] other corrupted bugs [Fail] The reason is: partial truncation assume compressed inode has reserved blocks, after partial truncation, valid block count may change w/o .i_blocks and .total_valid_block_count update, result in corruption. This patch only allow cluster size aligned truncation on released compress inode for fixing. Fixes: c6140415 ("f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit") Signed-off-by:
-
Chao Yu authored
It missed to call dec_valid_node_count() to release node block count in error path, fix it. Fixes: 141170b7 ("f2fs: fix to avoid use f2fs_bug_on() in f2fs_new_node_page()") Signed-off-by:
-
Chao Yu authored
It needs to cover {reserve,release}_compress_blocks() w/ cp_rwsem lock to avoid racing with checkpoint, otherwise, filesystem metadata including blkaddr in dnode, inode fields and .total_valid_block_count may be corrupted after SPO case. Fixes: ef8d563f ("f2fs: introduce F2FS_IOC_RELEASE_COMPRESS_BLOCKS") Fixes: c75488fb ("f2fs: introduce F2FS_IOC_RESERVE_COMPRESS_BLOCKS") Signed-off-by: -
Chao Yu authored
If inc_valid_block_count() can not allocate all requested blocks, it needs to release block count in .total_valid_block_count and resevation blocks in inode. Fixes: 54607494 ("f2fs: compress: fix to avoid inconsistence bewteen i_blocks and dnode") Signed-off-by:
-
Chao Yu authored
s/released/reserved. Signed-off-by:
-
Chao Yu authored
Previously, we account reserved blocks and compressed blocks into @compr_blocks, then, f2fs_i_compr_blocks_update(,compr_blocks) will update i_compr_blocks incorrectly, fix it. Meanwhile, for the case all blocks in cluster were reserved, fix to update dn->ofs_in_node correctly. Fixes: eb8fbaa5 ("f2fs: compress: fix to check unreleased compressed cluster") Signed-off-by:
-
- 09 May, 2024 5 commits
-
-
Chao Yu authored
- It missed to check validation of fault attrs in parse_options(), let's fix to add check condition in f2fs_build_fault_attr(). - Use f2fs_build_fault_attr() in __sbi_store() to clean up code. Signed-off-by:
-
Chao Yu authored
type of f2fs_inode.i_gc_failures, f2fs_inode_info.i_gc_failures, and f2fs_sb_info.gc_pin_file_threshold is __le16, unsigned int, and u64, so it will cause truncation during comparison and persistence. Unifying variable of these three variables to unsigned short, and add an upper boundary limitation for gc_pin_file_threshold. Signed-off-by:
-
Chao Yu authored
After commit 3db1de0e ("f2fs: change the current atomic write way"), we removed all GC_FAILURE_ATOMIC usage, let's change i_gc_failures[] array to i_pin_failure for cleanup. Meanwhile, let's define i_current_depth and i_gc_failures as union variable due to they won't be valid at the same time. Signed-off-by:
-
Chao Yu authored
Commit b1c9d3f8 ("f2fs: support printk_ratelimited() in f2fs_printk()") missed some cases, cover all remains for cleanup. Signed-off-by:
-
Wu Bo authored
As for zoned-UFS, f2fs section size is forced to zone size. And zone size may not aligned to pow2. Fixes: 859fca6b ("f2fs: swap: support migrating swapfile in aligned write mode") Signed-off-by:
Liao Yuanhong <liaoyuanhong@vivo.com> Signed-off-by:
Wu Bo <bo.wu@vivo.com> Reviewed-by:
-
- 29 Apr, 2024 4 commits
-
-
Chao Yu authored
Otherwise, it breaks pinfile's sematics. Cc: Daeho Jeong <daeho43@gmail.com> Signed-off-by:
-
Chao Yu authored
syzbot reports a kernel bug as below: F2FS-fs (loop0): Mounted with checkpoint version = 48b305e4 ================================================================== BUG: KASAN: slab-out-of-bounds in f2fs_test_bit fs/f2fs/f2fs.h:2933 [inline] BUG: KASAN: slab-out-of-bounds in current_nat_addr fs/f2fs/node.h:213 [inline] BUG: KASAN: slab-out-of-bounds in f2fs_get_node_info+0xece/0x1200 fs/f2fs/node.c:600 Read of size 1 at addr ffff88807a58c76c by task syz-executor280/5076 CPU: 1 PID: 5076 Comm: syz-executor280 Not tainted 6.9.0-rc5-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 print_address_description mm/kasan/report.c:377 [inline] print_report+0x169/0x550 mm/kasan/report.c:488 kasan_report+0x143/0x180 mm/kasan/report.c:601 f2fs_test_bit fs/f2fs/f2fs.h:2933 [inline] current_nat_addr fs/f2fs/node.h:213 [inline] f2fs_get_node_info+0xece/0x1200 fs/f2fs/node.c:600 f2fs_xattr_fiemap fs/f2fs/data.c:1848 [inline] f2fs_fiemap+0x55d/0x1ee0 fs/f2fs/data.c:1925 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x1c07/0x2e50 fs/ioctl.c:838 __do_sys_ioctl fs/ioctl.c:902 [inline] __se_sys_ioctl+0x81/0x170 fs/ioctl.c:890 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f The root cause is we missed to do sanity check on i_xattr_nid during f2fs_iget(), so that in fiemap() path, current_nat_addr() will access nat_bitmap w/ offset from invalid i_xattr_nid, result in triggering kasan bug report, fix it. Reported-and-tested-by: syzbot+3694e283cf5c40df6d14@syzkaller.appspotmail.com Closes: https://lore.kernel.org/linux-f2fs-devel/00000000000094036c0616e72a1d@google.comSigned-off-by:
-
Chao Yu authored
If active_log is not 6, we never use WARM_DATA segment, let's avoid allocating WARM_DATA segment for direct IO. Signed-off-by:
Yunlei He <heyunlei@oppo.com> Signed-off-by:
-
Yifan Zhao authored
is_next_segment_free() takes a redundant `type` parameter. Remove it. Signed-off-by:
Yifan Zhao <zhaoyifan@sjtu.edu.cn> Reviewed-by:
-
- 25 Apr, 2024 3 commits
-
-
Wu Bo authored
To make code clean, use blk_zone_cond_str() to print debug information. Signed-off-by:
-
Jaegeuk Kim authored
f2fs_ra_meta_pages can try to read ahead on invalid block address which is not the corruption case. Cc: <stable@kernel.org> # v6.9+ Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218770 Fixes: 31f85ccc ("f2fs: unify the error handling of f2fs_is_valid_blkaddr") Reviewed-by:
-
Jaegeuk Kim authored
Let's stop issuing compressed writes and clear their writeback flags. Reviewed-by:
-
- 19 Apr, 2024 7 commits
-
-
Chao Yu authored
After commit d7e9a903 ("f2fs: Support Block Size == Page Size"), F2FS_BLKSIZE equals to PAGE_SIZE, remove unnecessary check condition. Signed-off-by:
-
Chao Yu authored
Commit d7e9a903 ("f2fs: Support Block Size == Page Size") missed to adjust comment in sanity_check_raw_super(), fix it. Signed-off-by:
-
Chao Yu authored
Convert f2fs__page tracepoint class() and its instances to use folio and related functionality, and rename it to f2fs__folio(). Signed-off-by:
-
Chao Yu authored
Convert f2fs_read_inline_data() to use folio and related functionality, and also convert its caller to use folio. Signed-off-by:
-
Chao Yu authored
Convert f2fs_read_single_page() to use folio and related functionality. Signed-off-by:
-
Chao Yu authored
Convert f2fs_mpage_readpages() to use folio and related functionality. Signed-off-by:
-
Jaegeuk Kim authored
This reverts commit 930e2607 ("f2fs: remove obsolete whint_mode"), as we decide to pass write hints to the disk. Cc: Hyunchul Lee <cheol.lee@lge.com> Signed-off-by:
-
- 14 Apr, 2024 2 commits
-
-
Daeho Jeong authored
Since the allocation happens in conventional LU for zoned storage, we can allow direct io for that. Signed-off-by:
-
Daeho Jeong authored
In a case writing without fallocate(), we can't guarantee it's allocated in the conventional area for zoned stroage. To make it consistent across storage devices, we disallow it regardless of storage device types. Signed-off-by:
-
- 12 Apr, 2024 8 commits
-
-
Jaegeuk Kim authored
Let's convert PageWriteback to folio_test_writeback. Reviewed-by:
-
Zhiguo Niu authored
some user behaviors requested filesystem operations, which will cause filesystem not idle. Meanwhile adjust some f2fs_update_time(REQ_TIME) positions. Signed-off-by:
-
Daeho Jeong authored
While do not allocating a new section in advance for file pinning area, I missed that we should write the sum block for the last segment of a file pinning section. Fixes: 9703d69d ("f2fs: support file pinning for zoned devices") Signed-off-by:
-
Jaegeuk Kim authored
Shutdown does not check the error of thaw_super due to readonly, which causes a deadlock like below. f2fs_ioc_shutdown(F2FS_GOING_DOWN_FULLSYNC) issue_discard_thread - bdev_freeze - freeze_super - f2fs_stop_checkpoint() - f2fs_handle_critical_error - sb_start_write - set RO - waiting - bdev_thaw - thaw_super_locked - return -EINVAL, if sb_rdonly() - f2fs_stop_discard_thread -> wait for kthread_stop(discard_thread); Reported-by:"Light Hsieh (謝明燈)" <Light.Hsieh@mediatek.com> Reviewed-by:
-
Chao Yu authored
ioctl(F2FS_IOC_MOVE_RANGE) can truncate or punch hole on pinned file, fix to disallow it. Fixes: 5fed0be8 ("f2fs: do not allow partial truncation on pinned file") Signed-off-by:
-
Chao Yu authored
compress and pinfile flag should be checked after inode lock held to avoid race condition, fix it. Fixes: 4c8ff709 ("f2fs: support data compression") Fixes: 5fed0be8 ("f2fs: do not allow partial truncation on pinned file") Signed-off-by:
-
Chao Yu authored
Compress flag should be checked after inode lock held to avoid racing w/ f2fs_setflags_common() , fix it. Fixes: 5fdb322f ("f2fs: add F2FS_IOC_DECOMPRESS_FILE and F2FS_IOC_COMPRESS_FILE") Reported-by:
-
Chao Yu authored
Compress flag should be checked after inode lock held to avoid racing w/ f2fs_setflags_common(), fix it. Fixes: 4c8ff709 ("f2fs: support data compression") Reported-by:
-
- 09 Apr, 2024 1 commit
-
-
Wenjie Qi authored
If the max open zones of zoned devices are less than the active logs of F2FS, the device may error due to insufficient zone resources when multiple active logs are being written at the same time. Signed-off-by:
Wenjie Qi <qwjhust@gmail.com> Signed-off-by:
-
