- 05 May, 2022 16 commits
-
-
Martin Kaiser authored
OnAction_tbl has only three entries. It's simpler to use a switch statement instead of iterating over the table. We can then remove the table itself and struct action_handler, which was used only for the table entries. Signed-off-by:
Martin Kaiser <martin@kaiser.cx> Link: https://lore.kernel.org/r/20220502200652.143665-7-martin@kaiser.cxSigned-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Martin Kaiser authored
RTW_WLAN_CATEGORY_TDLS is not used. Remove the define. Signed-off-by:
-
Martin Kaiser authored
Remove the unused str component from struct action_handler and the corresponding entries in OnAction_tbl. Signed-off-by:
-
Martin Kaiser authored
For some action categories, we removed the handler function, but we forgot the prototypes. Remove them as well. Signed-off-by:
-
Martin Kaiser authored
The r8188eu driver does not handle the wmm action category. Remove the empty handler function, the entry in OnAction_tbl and the define for the category. Signed-off-by:
-
Martin Kaiser authored
The r8188eu driver does not handle the ht action category. Remove the empty handler function, the entry in OnAction_tbl and the define for the category. Signed-off-by:
-
Philipp Hortmann authored
Replace unused return value with u64 to increase readability, reduce address and dereference operators and omit pqwCurrTSF that uses CamelCase which is not accepted by checkpatch.pl Signed-off-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/62c83d78627196ec0ce2f5a562cb080a1c87a05a.1651435890.git.philipp.g.hortmann@gmail.comSigned-off-by:
-
Philipp Hortmann authored
The name of the function uses CamelCase which is not accepted by checkpatch.pl Signed-off-by:
-
Philipp Hortmann authored
Added missing big-endian support in CARDbGetCurrentTSF. Reported-by:
David Laight <David.Laight@ACULAB.COM> Signed-off-by:
-
Philipp Hortmann authored
Replace macro VNSvInPortD with ioread32 and as it was the only user, it can now be removed. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
-
Charlie Sands authored
Removes broken and unsafe rtw_p2p_get function and all of the code associated with it from the r8188eu driver. Signed-off-by:
Charlie Sands <charlies256@protonmail.com> Link: https://lore.kernel.org/r/Ymy7C/A2q+VzfBhO@sckzor-linux.localdomainSigned-off-by:
-
Vihas Makwana authored
There's a NULL check on pmlmepriv in rtw_mlme.c:112 which makes no sense as rtw_free_mlme_priv_ie_data() dereferences it unconditionally and it would have already crashed at this point. Remove this redundant check. Signed-off-by:
Vihas Makwana <makvihas@gmail.com> Link: https://lore.kernel.org/r/20220427165748.10584-1-makvihas@gmail.comSigned-off-by:
-
Jaehee Park authored
rtw_select_and_join_from_scanned_queue() cannot return '2' so this else condition is unused. Remove this unnecessary else statement. Suggested-by:
Pavel Skripkin <paskripkin@gmail.com> Signed-off-by:
Jaehee Park <jhpark1013@gmail.com> Link: https://lore.kernel.org/r/20220427153203.GA503502@jaehee-ThinkPad-X1-ExtremeSigned-off-by:
-
Vihas Makwana authored
The semaphore allrxreturnevt of struct recv_priv is initialized but not used anywhere in the code. Remove the initialization and the structure member. Signed-off-by:
-
Nickalas Cason authored
Correct misspelling in comment. Issue found with checkpatch. Signed-off-by:
Nickalas Cason <nickalas@cason.dev> Link: https://lore.kernel.org/r/20220430230139.7i772mvejlhevamn@desktopSigned-off-by:
-
Andy Shevchenko authored
Instead of custom data type re-use generic struct s32_fract. No changes intended. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20220504092915.72021-1-andriy.shevchenko@linux.intel.comSigned-off-by:
-
- 27 Apr, 2022 2 commits
-
-
Philipp Hortmann authored
Replace macro MACvReadISR with VNSvInPortD and as it was the only user, it can now be removed. Signed-off-by:
-
Philipp Hortmann authored
Replace macro MACvReadMIBCounter with VNSvInPortD and as it was the only user, it can now be removed. Signed-off-by:
-
- 26 Apr, 2022 18 commits
-
-
Philipp Hortmann authored
Replace macro VNSvInPortW with ioread16. The name of macro and the arguments use CamelCase which is not accepted by checkpatch.pl Signed-off-by:
-
Solomon Tan authored
Remove explicit u16 cast of the function Mk16 return value. The variable hi does not need to be casted explicitly to u16 as it will already be casted implicitly. Signed-off-by:
Solomon Tan <wjsota@gmail.com> Link: https://lore.kernel.org/r/20220423130150.161903-8-wjsota@gmail.comSigned-off-by:
-
Solomon Tan authored
The explicit u16 cast is not necessary because rtl92e_eeprom_read's second parameter is defined to be u32. Signed-off-by:
-
Solomon Tan authored
Remove the explicit u16 casts for u16 argument in the function call. This function has declared its parameter to be of type u16, so the argument given to that parameter will be automatically coerced to u16. Therefore, an explicit cast is unnecessary. Signed-off-by:
-
Solomon Tan authored
Remove the explicit casts in assignment statements for u16 variables. Because these variables are declared as u16, there is implicit conversion to u16 during the assignment, so an explicit cast is unnecessary. Signed-off-by:
-
Solomon Tan authored
Since the macro VERSION_8190_BD is defined to be 0x3, and the structure members card_8192_version and IC_Cut are both u8, an explicit u8 cast is unnecessary. Signed-off-by:
-
Solomon Tan authored
Remove the unnecessary explicit u8 casts for u8 arguments in function calls. These functions have declared their parameters to be of type u8, so the arguments given to those parameters will be automatically coerced to u8. Therefore, an explicit cast is unnecessary. Signed-off-by:
-
Solomon Tan authored
Remove the explicit casts in assignment statements for u8 variables. Because these variables are declared as u8, there is implicit conversion to u8 during the assignment, so an explicit cast is unnecessary. Signed-off-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_dequeue_cmd and move its logic to rtw_dequeue_cmd. Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_alloc_network and move its logic to rtw_alloc_network. Reviewed-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_free_mlme_priv and move its logic to rtw_free_mlme_priv. Reviewed-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_init_mlme_priv and move its logic to rtw_init_mlme_priv. Reviewed-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_init_evt_priv and move its logic to rtw_init_evt_priv. Reviewed-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_init_cmd_priv and move its logic to rtw_init_cmd_priv. Reviewed-by:
-
Vihas Makwana authored
Drop unnecessary wrapper _rtw_free_cmd_priv and move its logic to rtw_free_cmd_priv. Reviewed-by:
-
Vaibhav Nagare authored
Fixed the spelling mistake of appendation to appending. Signed-off-by:
Vaibhav Nagare <vnagare@redhat.com> Link: https://lore.kernel.org/r/20220425133111.118257-1-vnagare@redhat.comSigned-off-by:
-
Geert Uytterhoeven authored
Thanks to stubs for the NO_DMA=y case, drivers that use the DMA API can be compile-tested on systems that do not support DMA. Hence the dependency of BCM2835_VCHIQ on HAS_DMA was dropped to increase compile coverage. Unfortunately compilers became smarter, leading to new failures. E.g. for a CONFIG_SUN3=y allmodconfig kernel with gcc 9.4.0: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c: In function ‘free_pagelist’: arch/m68k/include/asm/string.h:72:25: warning: argument 2 null where non-null expected [-Wnonnull] 72 | #define memcpy(d, s, n) __builtin_memcpy(d, s, n) | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:614:4: note: in expansion of macro ‘memcpy’ 614 | memcpy((char *)kmap(pages[0]) + | ^~~~~~ arch/m68k/include/asm/string.h:72:25: note: in a call to built-in function ‘__builtin_memcpy’ 72 | #define memcpy(d, s, n) __builtin_memcpy(d, s, n) | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c:614:4: note: in expansion of macro ‘memcpy’ 614 | memcpy((char *)kmap(pages[0]) + | ^~~~~~ This happens because the compiler can trace back the source pointer to a allocation by dma_alloc_attrs(), which always returns NULL if NO_DMA=y. Avoid this reinstating the dependency of the BCM2835_VCHIQ symbol on HAS_DMA, and by restricting the selection of BCM2835_VCHIQ. Signed-off-by:Geert Uytterhoeven <geert@linux-m68k.org> Link: https://lore.kernel.org/r/da55bd87eebf1a969dc8ccd807843319833f6c40.1650888813.git.geert@linux-m68k.orgSigned-off-by:
-
Solomon Tan authored
This reverts commit 0afaa121 as changing rtw_ieee80211_channel to ieee80211_channel causes a memcpy bug as reported in: https://lore.kernel.org/linux-staging/67e2d10b-7f0f-9c5a-ce31-376b83ffba9e@gmail.com/ due to their size differences. Fixes: 0afaa121 ("staging: r8188eu: use in-kernel ieee channel") Reported-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
- 22 Apr, 2022 4 commits
-
-
Adrien Thierry authored
Delete TODO since all tasks were completed: 1 - fixed here: https://lore.kernel.org/all/20220408150359.26661-1-athierry@redhat.com/ 2 - there are no remaining checkpatch.pl errors or warnings Signed-off-by:
Adrien Thierry <athierry@redhat.com> Link: https://lore.kernel.org/r/20220420174401.305964-1-athierry@redhat.comSigned-off-by:
-
Haowen Bai authored
The ieee80211_check_auth_response() function has a signedness bug because it's a declared as a u16 but it return -ENOMEM. When you look at it more closely it returns a mix of error codes including 0xcafe, -ENOMEM, and a->status which is WLAN_STATUS_NOT_SUPPORTED_AUTH_ALG. This is a mess. Clean it up to just return standard kernel error codes. We can print out the a->status before returning a regular error code. The printks in the caller need to be adjusted as well. Signed-off-by:
Haowen Bai <baihaowen@meizu.com> Link: https://lore.kernel.org/r/1650593435-9017-1-git-send-email-baihaowen@meizu.comSigned-off-by:
-
Wan Jiabing authored
Fix the following coccicheck error: drivers/staging/r8188eu/os_dep/usb_intf.c:202:5-8: Unneeded variable: "ret". Return "0" on line 242 Signed-off-by:
Wan Jiabing <wanjiabing@vivo.com> Link: https://lore.kernel.org/r/20220422021046.121870-1-wanjiabing@vivo.comSigned-off-by:
-
Christophe JAILLET authored
If device_register() fails, device_unregister() should not be called because it will free some resources that are not allocated. put_device() should be used instead. Fixes: 308ee87a ("staging: fieldbus: anybus-s: support HMS Anybus-S bus") Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/5401a519608d6e1a4e7435c20f4f20b0c5c36c23.1650610082.git.christophe.jaillet@wanadoo.frSigned-off-by:
-
