- 23 Jul, 2015 40 commits
-
-
Neil Horman authored
All it does is return no supported. Removing the function entirely accomplishes the same thing Signed-off-by:
Neil Horman <nhorman@redhat.com> Signed-off-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Neil Horman authored
dev_trans_start does this for us now Signed-off-by:
-
Neil Horman authored
Using NETDEV_TX_BUSY is tricky. Its meant for situations where the error in question is transient and quickly resolved. But the driver rarely is able to know that to a certainty. And in the case of visornic, it just uses it without any care for that, in the hopes that it won't loose frames, even if the problem is that the skb is somehow malformed for the hardware. If we get one of those kinds of skbs, NETDEV_TX_BUSY will just cause us to spin, processing the same error over and over. Fix it by dropping the frame, stopping the queue where appropriate, and returning NETDEV_TX_OK Signed-off-by:
-
Neil Horman authored
If we put them in the enable and disable paths, we don't need them in several other places Signed-off-by:
-
Neil Horman authored
I don't see why the server should stop responding, or that we should just give up if it does. Wait forever when enabling/disabling the visornic Signed-off-by:
-
Neil Horman authored
I don't see why serverdown should be async on a workqueue. Just make it synchronous, and remove some code in the process Signed-off-by:
-
Neil Horman authored
Theres a lot of code duplication going on in visornic_serverdown_complete. We should just be able to send it through the dev_close path and have it do the right things. Signed-off-by:
-
Neil Horman authored
Its possible to overwrite the old task pointer in visornic_resume. Add a check to guard against that and a warning if we find that its already running Signed-off-by:
-
Neil Horman authored
Remove the has_stopped completion as theres already one available internally. Correct the while loops Remove the while loop in drain_queue as it already exists in the top level loop Signed-off-by:
-
Neil Horman authored
If we can't fit an skb into a frag array, linaraize it so we don't have to Signed-off-by:
-
Neil Horman authored
We precheck that we have enough space in an iochannel prior to writing to it when we send in a fragmented skb. Given that there is no recovery from this condition that I can see, turn it into a BUG halt Signed-off-by:
-
Neil Horman authored
One call site for visor_copy_fragsinfo_from_skb was checking for an rc of -1, but thhe function doesn't return that, it returns -errno. Correct it Signed-off-by:
-
Neil Horman authored
As pointed out in a recent review, the num_visornic_open array didn't do anything useful, and it exposed a potential race in the visornic code that could arise while taking down a net interface while reading from the debugfs files. Fix that by removing the array entirely, and just iterating over all the registered netdevs in a given namespace, filtering on them having visornic ops (to identify which are ours), and having their queues not be stopped (identifying that they are up). This should prevent any oops conditions happening due to changing state in that array, and save us a bunch of code too. Signed-off-by:
Neil Horman <nhorman@tuxdriver.com> Signed-off-by:
-
Steve Pennington authored
Repaced calls to htons and memcpy with a single call to put_unaligned_be16 to fix the following sparse warning: drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: warning: incorrect type in assignment (different base types) drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: expected unsigned short [unsigned] [assigned] [usertype] len drivers/staging/rtl8723au/core/rtw_recv.c:1557:21: got restricted __be16 [usertype] <noident> Signed-off-by:
Steve Pennington <sgpenn@gmail.com> Signed-off-by:
-
Jon Medhurst (Tixy) authored
Use dma_get_sgtable rather than dma_common_get_sgtable so a device's dma_ops aren't bypassed. This is essential in situations where a device uses an IOMMU and the physical memory is not contiguous (as the common function assumes). Signed-off-by:
Jon Medhurst <tixy@linaro.org> Reviewed-by:
Robin Murphy <robin.murphy@arm.com> Signed-off-by:
-
Stuart Yoder authored
update TODO list to provide more detail on remaining work Signed-off-by:
Stuart Yoder <stuart.yoder@freescale.com> Signed-off-by:
-
Dan Carpenter authored
The pointer math here was totally wrong so we were reading nonsense information from beyond the end of the buffer. It could lead to an oops if that memory wasn't mapped. The "pReasonCode" pointer is assigned but never used so I deleted it. With-Fix-From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Tested-by:
-
Luis de Bethencourt authored
bool Reval is set to match the value of bHalfWirelessN24GMode just to this. The value can be returned directly. Removing uneeded bool. Signed-off-by:
Luis de Bethencourt <luis@debethencourt.com> Suggested-by:
Joe Perches <joe@perches.com> Suggested-by:
Franks Klaver <fransklaver@gmail.com> Signed-off-by:
-
Luis de Bethencourt authored
Remove explicit true/false comparisons to bool variables. Signed-off-by:
-
Dan Carpenter authored
Smatch complains because "delba" is a pointer to struct rtl_80211_hdr_3addr so the "delba += sizeof(struct rtl_80211_hdr_3addr);" is clearly wrong. We are reading nonsense data from beyond the end of the buffer and could oops if that memory isn't mapped. It turns out the next two statements are also wrong. We should delete the += sizeof() statement and "delba+2" should be "&delba->payload[2]". "pReasonCode" isn't used so I deleted that. With-Fix-From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> Signed-off-by:
-
Sudip Mukherjee authored
Multiple blank lines should be avoided. Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Sudip Mukherjee authored
Success and error path was mixed. Separate them by directly returning 0 from the success path. In the process remove the variable which became unused. Signed-off-by:
-
Sudip Mukherjee authored
Check for kzalloc failure and directly return from the error patch thus simplifying the success path. Suggested-by:
-
Sudip Mukherjee authored
Directly return NULL instead of using another label and goto. Signed-off-by:
-
Sudip Mukherjee authored
_HCI_INTF_C_ was only defined here but not being used anywhere. Signed-off-by:
-
Antoine BLIN authored
Fix up "line over 80 characters" warning found by the checkpatch.pl script. Signed-off-by:
Antoine BLIN <antoine.blin@lip6.fr> Signed-off-by:
-
Aaron Ouellette authored
fixed checkpatch.pl error: ERROR: return is not a function, parentheses are not needed Signed-off-by:
Aaron Ouellette <aouellette2016@gmail.com> Signed-off-by:
-
Bernd Porr authored
urb->interval is deprecated and thus I've changed the driver that it now always assumes interval=1 which means every frame in USB 1.1 and every uframe in USB 2.0. However we still need to have different sampling rates which are still multiples of the interval which is now transmitted to the firmware. The firmware transmits either zero length packets or none every (u)frame. This is checked in the completion handler and any packet at zero length is discarded so that comedi again sees the data coming in at the interval specified. This also then gives the ADC the necessary time to convert. For example 16 channels require about 700us and in this period no packet could be transmitted. In this case this is padded up to 1ms so that we have then 7 zero length packets and one packet with the ADC data. Signed-off-by:
Bernd Porr <mail@berndporr.me.uk> Signed-off-by:
-
Bernd Porr authored
Changed my e-mail address to mail@berndporr.me.uk. The old one is no longer used. Signed-off-by:
-
Chandra S Gorentla authored
Checkpatch.pl warning - suspect code indent for conditional statements - is corrected Signed-off-by:
Chandra S Gorentla <csgorentla@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Malcolm Priestley authored
Remove these unsed structures. typedef struct tagSTxSyncDesc typedef struct tagSRrvTime_atim typedef struct tagSTxBufHead typedef struct tagSBEACONCtl typedef struct tagSSecretKey typedef struct tagSKeyEntry Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
vnt_tx_fifo_head has now replaced STxBufHead Signed-off-by:
-
Malcolm Priestley authored
The device is limited to 32 bit address space. Signed-off-by:
-
Malcolm Priestley authored
should be __le16 Signed-off-by:
-
Malcolm Priestley authored
Should be __le16 and do and correct endian conversion. Signed-off-by:
-
Malcolm Priestley authored
Should always be __le32 Signed-off-by:
-
Malcolm Priestley authored
Should always be __le32. Signed-off-by:
-
Malcolm Priestley authored
variable is assigned a value that is never used. Signed-off-by:
-
Malcolm Priestley authored
Should always be __le32 type Signed-off-by:
-
Malcolm Priestley authored
Should always be __le32 type Signed-off-by:
-
