1. 11 Apr, 2022 4 commits
    • Zheyu Ma's avatar
      video: fbdev: tridentfb: Error out if 'pixclock' equals zero · 16844e58
      Zheyu Ma authored
      The userspace program could pass any values to the driver through
      ioctl() interface. If the driver doesn't check the value of 'pixclock',
      it may cause divide error.
      
      Fix this by checking whether 'pixclock' is zero.
      
      The following log reveals it:
       divide error: 0000 [#1] PREEMPT SMP KASAN PTI
       RIP: 0010:tridentfb_check_var+0x853/0xe60
       Call Trace:
        <TASK>
        fb_set_var+0x367/0xeb0
        do_fb_ioctl+0x234/0x670
        fb_ioctl+0xdd/0x130
        do_syscall_64+0x3b/0x90
      Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
      Signed-off-by: default avatarHelge Deller <deller@gmx.de>
      16844e58
    • Zheyu Ma's avatar
      video: fbdev: vt8623fb: Error out if 'pixclock' equals zero · f2bfd792
      Zheyu Ma authored
      The userspace program could pass any values to the driver through
      ioctl() interface. If the driver doesn't check the value of 'pixclock',
      it may cause divide error.
      
      Fix this by checking whether 'pixclock' is zero in the function
      vt8623fb_check_var().
      
      The following log reveals it:
       divide error: 0000 [#1] PREEMPT SMP KASAN PTI
       RIP: 0010:vt8623fb_set_par+0xecd/0x2210
       Call Trace:
        <TASK>
        fb_set_var+0x604/0xeb0
        do_fb_ioctl+0x234/0x670
        fb_ioctl+0xdd/0x130
        do_syscall_64+0x3b/0x90
      Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
      Signed-off-by: default avatarHelge Deller <deller@gmx.de>
      f2bfd792
    • Zheyu Ma's avatar
      video: fbdev: kyro: Error out if 'lineclock' equals zero · 213e2df4
      Zheyu Ma authored
      The userspace program could pass any values to the driver through
      ioctl() interface. If the driver doesn't check the value of 'lineclock',
      it may cause divide error.
      
      Fix this by checking whether 'lineclock' is zero.
      
      The following log reveals it:
       divide error: 0000 [#1] PREEMPT SMP KASAN PTI
       RIP: 0010:kyrofb_set_par+0x30d/0xd80
       Call Trace:
        <TASK>
        fb_set_var+0x604/0xeb0
        do_fb_ioctl+0x234/0x670
        fb_ioctl+0xdd/0x130
        do_syscall_64+0x3b/0x90
      Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
      Signed-off-by: default avatarHelge Deller <deller@gmx.de>
      213e2df4
    • Zheyu Ma's avatar
      video: fbdev: neofb: Fix the check of 'var->pixclock' · 85ec038b
      Zheyu Ma authored
      The previous check against 'var->pixclock' doesn't return -EINVAL when
      it equals zero, but the driver uses it again, causing the divide error.
      
      Fix this by returning when 'var->pixclock' is zero.
      
      The following log reveals it:
       divide error: 0000 [#1] PREEMPT SMP KASAN PTI
       RIP: 0010:neofb_set_par+0x190f/0x49a0
       Call Trace:
        <TASK>
        fb_set_var+0x604/0xeb0
        do_fb_ioctl+0x234/0x670
        fb_ioctl+0xdd/0x130
        do_syscall_64+0x3b/0x90
      Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
      Signed-off-by: default avatarHelge Deller <deller@gmx.de>
      85ec038b
  2. 07 Apr, 2022 1 commit
  3. 04 Apr, 2022 8 commits
  4. 03 Apr, 2022 8 commits
  5. 02 Apr, 2022 19 commits