- 12 Mar, 2010 40 commits
-
-
Joe Perches authored
Print the function name not the pointer address where useful and possible Signed-off-by:
Joe Perches <joe@perches.com> Cc: Stephen Hemminger <shemminger@vyatta.com> Cc: Jens Axboe <jens.axboe@oracle.com> Cc: Marcin Slusarz <marcin.slusarz@gmail.com> Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Joe Perches authored
Add and use __func__ to is_alive. Use __func__ in some DPRINTs. Signed-off-by:
-
Joe Perches authored
Move DPRINT macro definition above 1st use Consolidate a format string (>80 columns) Add a newline to an unterminated message Comment neatened Signed-off-by:
-
Joe Perches authored
The code could not be compiled without the #define, so just remove it and the #ifdef/#endif lines. Signed-off-by:
-
Joe Perches authored
Prior to patch "drivers/block/floppy.c: Use pr_<level>" only reschedule_timeout(,"request done"...) printed a numeric value after a reschedule_timeout event message. Restore that behavior and remove the now unnecessary argument. Signed-off-by:
-
Joe Perches authored
Change for(;;) with continue; to label: goto label Reduces indentation and adds a bit of clarity. Signed-off-by:
-
Joe Perches authored
Macros with hidden flow changes aren't nice. Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Used a couple of times, might simplify the code a bit. Signed-off-by:
-
Joe Perches authored
Don't initialize initialized either. Default is false. Signed-off-by:
-
Joe Perches authored
Use it directly in the one place it's used. Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Various functions use int where bool is appropriate lock_fdc, wait_til_done, poll_drive, user_reset_fdc Convert to bool. Signed-off-by:
-
Joe Perches authored
Obfuscating macros with embedded returns are not nice Signed-off-by:
-
Joe Perches authored
Remove these obfuscating macros with hidden returns Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Use clear_bit, set_bit, and test_bit functions directly Signed-off-by:
-
Joe Perches authored
Converted #ifdef DCL_DEBUG if (test) DPRINTK(...); #endif to debug_dcl(test, ...); Signed-off-by:
-
Joe Perches authored
Macros with hidden returns aren't nice. Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Remove ugly IN/OUT macros, use direct case and code Add missing semicolon after ECALL Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Spacing, column alignment and a for loop with a naked semicolon converted to an assign and while Signed-off-by:
-
Joe Perches authored
Macros with hidden returns are not nice. Convert the 2 uses to use direct code. Signed-off-by:
-
Joe Perches authored
Move assigns above if()s Remove unnecessary parentheses from returns Use a temporary for a duplicated test Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Convert bare printk to pr_info and pr_cont Convert printk(KERN_ERR to pr_err Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Joe Perches authored
Signed-off-by:
-
Wu Fengguang authored
- introduce dump_page() to print the page info for debugging some error condition. - convert three mm users: bad_page(), print_bad_pte() and memory offline failure. - print an extra field: the symbolic names of page->flags Example dump_page() output: [ 157.521694] page:ffffea0000a7cba8 count:2 mapcount:1 mapping:ffff88001c901791 index:0x147 [ 157.525570] page flags: 0x100000000100068(uptodate|lru|active|swapbacked) Signed-off-by:
Wu Fengguang <fengguang.wu@intel.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Alex Chiang <achiang@hp.com> Cc: Rik van Riel <riel@redhat.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: Mel Gorman <mel@linux.vnet.ibm.com> Cc: Christoph Lameter <cl@linux-foundation.org> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by:
-
Julia Lawall authored
The few lines below the kfree of hdr_buf may go to the label err_free which will also free hdr_buf. The most straightforward solution seems to be to just move the kfree of hdr_buf after these gotos. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ identifier E; expression E1; iterator I; statement S; @@ *kfree(E); ... when != E = E1 when != I(E,...) S when != &E *kfree(E); // </smpl> Signed-off-by:
Julia Lawall <julia@diku.dk> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: <stable@kernel.org> Signed-off-by:
-
Thomas Gleixner authored
__zone_pcp_update() iterates over NR_CPUS instead of limiting the access to the possible cpus. This might result in access to uninitialized areas as the per cpu allocator only populates the per cpu memory for possible cpus. This problem was created as a result of the dynamic allocation of pagesets from percpu memory that went in during the merge window - commit 99dcc3e5 ("this_cpu: Page allocator conversion"). Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Acked-by:
Pekka Enberg <penberg@cs.helsinki.fi> Acked-by:
Tejun Heo <tj@kernel.org> Acked-by:
Christoph Lameter <cl@linux-foundation.org> Acked-by:
Mel Gorman <mel@csn.ul.ie> Reviewed-by:
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by:
-
KAMEZAWA Hiroyuki authored
Commit 34e55232 ("mm: avoid false sharing of mm_counter") added sync_mm_rss() for syncing loosely accounted rss counters. It's for CONFIG_MMU but sync_mm_rss is called even in NOMMU enviroment (kerne/exit.c, fs/exec.c). Above commit doesn't handle it well. This patch changes SPLIT_RSS_COUNTING depends on SPLIT_PTLOCKS && CONFIG_MMU And for avoid unnecessary function calls, sync_mm_rss changed to be inlined noop function in header file. Reported-by:
David Howells <dhowells@redhat.com> Signed-off-by:
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Signed-off-by:
Mike Frysinger <vapier@gentoo.org> Signed-off-by:
Michal Simek <monstr@monstr.eu> Signed-off-by:
-
Mike Frysinger authored
Signed-off-by:
-
Albert Herranz authored
SDIO Simplified Specification V2.00 states that it is strongly recommended that the host executes either a power reset or issues a CMD52 (I/O Reset) to re-initialize an I/O only card or the I/O portion of a combo card. Additionally, the CMD52 must be issued first because it cannot be issued after a CMD0. With this patch the Nintendo Wii SDIO-based WLAN card is detected after a system reset, without requiring a complete system powercycle. Signed-off-by:
Albert Herranz <albert_herranz@yahoo.es> Cc: <linux-mmc@vger.kernel.org> Signed-off-by:
-
Uwe Kleine-König authored
Without this patch /sys/class/rtc/$CONFIG_RTC_HCTOSYS_DEVICE/hctosys contains a 1 (meaning "This rtc was used to initialize the system clock") even if reading the time at bootup failed. Moreover change error handling in rtc_hctosys() to use goto and so reduce the indention level. Signed-off-by:
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Paul Gortmaker <p_gortmaker@yahoo.com> Acked-by:
Alessandro Zummo <a.zummo@towertech.it> Signed-off-by:
-
Richard Kennedy authored
When using slub, having a kmem_cache constructor forces slub to add a free pointer to the size of the cached object, which can have a significant impact to the number of small objects that can fit into a slab. As buffer_head is relatively small and we can have large numbers of them, removing the constructor is a definite win. On x86_64 removing the constructor gives me 39 objects/slab, 3 more than without the patch. And on x86_32 73 objects/slab, which is 9 more. As alloc_buffer_head() already initializes each new object there is very little difference in actual code run. Signed-off-by:
Richard Kennedy <richard@rsk.demon.co.uk> Cc: Alexander Viro <viro@zeniv.linux.org.uk> Cc: Jens Axboe <jens.axboe@oracle.com> Acked-by:
Nick Piggin <npiggin@suse.de> Cc: "Theodore Ts'o" <tytso@mit.edu> Reviewed-by:
Rik van Riel <riel@redhat.com> Signed-off-by:
-
Joe Perches authored
Signed-off-by:
Joel Becker <joel.becker@oracle.com> Signed-off-by:
-
