- 13 Jun, 2019 6 commits
-
-
Nishka Dasgupta authored
Change the return values of function r8712_setdatarate_cmd from _SUCCESS and _FAIL to 0 and -ENOMEM respectively. Change the return type of the function from u8 to int to reflect this. Change the call site of the function to check for 0 instead of _SUCCESS. Return the value at the call site directly instead of storing it in a return variable. Remove now-unused return variable. Signed-off-by:
Nishka Dasgupta <nishkadg.linux@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Jeremy Sowden authored
The existing implementation for doing DMA via asynchronous IO didn't work and there was no longer a use-case for it. Removed it. Fixed a few checkpatch warnings about too-long lines and extraneous braces in the process. Reported-by:
Matt Sickler <matt.sickler@daktronics.com> Signed-off-by:
Jeremy Sowden <jeremy@azazel.net> Signed-off-by:
-
Simon Sandström authored
Much of the code comments in kp2000_pcie_probe just repeats the code and does not add any additional information. Delete them and make sure that comments still left in the function all use the same style. Signed-off-by:
Simon Sandström <simon@nikanor.nu> Signed-off-by:
-
Simon Sandström authored
Use self-explanatory label names instead of the generic numbered ones, to make it easier to follow and understand the code. Signed-off-by:
-
YueHaibing authored
Fix sparse warnings: drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:46:6: warning: symbol 'kpc_dma_del_device' was not declared. Should it be static? drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:84:1: warning: symbol 'dev_attr_engine_regs' was not declared. Should it be static? drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:91:14: warning: symbol 'kpc_dma_class' was not declared. Should it be static? drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c:199:24: warning: symbol 'kpc_dma_plat_driver_i' was not declared. Should it be static? Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
YueHaibing <yuehaibing@huawei.com> Signed-off-by:
-
Rishiraj Manwatkar authored
This patch removes the Sparse generated warnings. Following warnings are reported by Sparse: drivers/staging/kpc2000//kpc_dma/kpc_dma_driver.c:46:6: warning: symbol 'kpc_dma_del_device' was not declared. Should it be static? drivers/staging/kpc2000//kpc_dma/kpc_dma_driver.c:91:14: warning: symbol 'kpc_dma_class' was not declared. Should it be static? drivers/staging/kpc2000//kpc_dma/kpc_dma_driver.c:199:24: warning: symbol 'kpc_dma_plat_driver_i' was not declared. Should it be static? Signed-off-by:
Rishiraj Manwatkar <manwatkar@outlook.com> Signed-off-by:
-
- 10 Jun, 2019 15 commits
-
-
Deepak Mishra authored
This patch removed following unused member variables from struct _adapter IsrContent, xmitThread, evtThread, recvThread Signed-off-by:
Deepak Mishra <linux.dkm@gmail.com> Signed-off-by:
-
Deepak Mishra authored
This patch renames CamelCase cmdThread to cmd_thread in struct _adapter in drv_types.h and in os_intfs.c This was reported by checkpatch.pl Signed-off-by:
-
Deepak Mishra authored
In function oid_rt_pro_write_register_hdl, Adapter->ImrContent is assigned with RegRWStruct->value but Adapter->ImrContent is never used anywhere else. So those lines has no impact and are removed removed. As that was the only place where ImrContent was used, so the member variable is removed from the structure _adapter Signed-off-by:
-
Deepak Mishra authored
This patch renames CamelCase EepromAddressSizefrom to eeprom_address_size in struct _adapter and in related files drv_types.h, rtl871x_eeprom.c, usb_intf.c This was reported by checkpatch.pl Signed-off-by:
-
Hariprasad Kelam authored
This patch fixes below issues reported by checkpatch CHECK: spaces preferred around that '-' (ctx:VxV) + skb_copy_bits(pfile->pkt, pfile->buf_len-pfile->pkt_len, rmem, len); CHECK: spaces preferred around that '*' (ctx:VxV) +#define WMM_XMIT_THRESHOLD (NR_XMITFRAME*2/5) ^ CHECK: spaces preferred around that '/' (ctx:VxV) +#define WMM_XMIT_THRESHOLD (NR_XMITFRAME*2/5) ^ CHECK: spaces preferred around that '/' (ctx:VxV) + if (pxmitpriv->free_xmitframe_cnt > (NR_XMITFRAME/4)) { ^ Signed-off-by:Hariprasad Kelam <hariprasad.kelam@gmail.com> Signed-off-by:
-
Hariprasad Kelam authored
this patch fixes below issue reported by checkpatch CHECK: Using comparison to true is error prone + if (res == true) Signed-off-by:
-
Hariprasad Kelam authored
This patch fixes below issue reported by checkpatch CHECK: Comparison to NULL could be written "!pxmitbuf->pallocated_buf" + if (pxmitbuf->pallocated_buf == NULL) Signed-off-by:
-
Hariprasad Kelam authored
In halbtc8723b2ant_TdmaDurationAdjust function,below piece of code is repeated many times. halbtc8723b2ant_PsTdma(pBtCoexist, NORMAL_EXEC, true, val); pCoexDm->psTdmaDuAdjType = val; So replace the same with "HAL_BTC8723B2ANT_DMA_DURATION_ADJUST" MACRO. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Simon Sandström authored
Debug prints that are used only to inform about function entry or exit can be removed as ftrace can be used to get this information. Signed-off-by:
-
Naoto Kobayashi authored
Since whitespace should not appear between asterisk and variable name in a declaration statement, remove it and fix checkpatch.pl error "foo * bar" should be "foo *bar". Signed-off-by:
Naoto Kobayashi <naoto.kobayashi4c@gmail.com> Signed-off-by:
-
YueHaibing authored
Fix gcc build error while CONFIG_REGMAP_MMIO is not set drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function `controller_probe': arcx-anybus.c: undefined reference to `__devm_regmap_init_mmio_clk' Select REGMAP_MMIO to fix it. Reported-by:
Sven Van Asbroeck <TheSven73@gmail.com> Signed-off-by:
-
- 09 Jun, 2019 15 commits
-
-
Harold André authored
Fixed a coding style issue. Signed-off-by:
Harold André <harold.andre@gmx.fr> Signed-off-by:
-
Hao Xu authored
add space after , for #define outb_p(d,a) writeq(d,(void *)a) Signed-off-by:
Hao Xu <haoxu.linuxkernel@gmail.com> Signed-off-by:
-
Hao Xu authored
modify void* to void * for #define inb_p(a) readq((void*)a) and #define outb_p(d,a) writeq(d,(void*)a) Signed-off-by:
-
Hariprasad Kelam authored
DBG_BUGON is introduced and it could only crash when EROFS_FS_DEBUG (EROFS developping feature) is on. replace BUG_ON with DBG_BUGON. Signed-off-by:
Gao Xiang <gaoxiang25@huawei.com> Signed-off-by:
-
Hariprasad Kelam authored
fix below warnings reported by coccicheck drivers/staging/erofs/unzip_vle.c:332:11-18: WARNING: Comparison to bool Signed-off-by:
-
Colin Ian King authored
In the default event case switchdev_work is being leaked because nothing is queued for work. Fix this by kfree'ing switchdev_work before returning NOTIFY_DONE. Addresses-Coverity: ("Resource leak") Fixes: 44baaa43 ("staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver") Signed-off-by:Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Nishka Dasgupta authored
Remove function rtw_free_network_nolock, as all it does is call _rtw_free_network_nolock, and rename _rtw_free_network_nolock to rtw_free_network_nolock. Keep the new rtw_free_network_nolock a static function and remove the old version from the header file. Signed-off-by:
-
Nishka Dasgupta authored
Remove leading 'p' from the names of the following pointer variables: - padapter - precvbuf - pintfhdl - pregistrypriv - precvpriv. Issue found with Coccinelle. Signed-off-by: -
Nishka Dasgupta authored
Remove leading 'p' from the names of the following pointer variables: - pintfhdl - pintf_hdl (renamed to intfhdl in keeping with the convention in other functions) - poption - pops - pintfpriv. Issue found with Coccinelle. Signed-off-by:
-
Nishka Dasgupta authored
Remove leading p from the names of the following pointer variables: - padapter - pxmitpriv - pnetdev - pxmitframe. Issue found with Coccinelle. Signed-off-by:
-
Nishka Dasgupta authored
Remove leading p from the following pointer variable names: - padapter - pmlmepriv - precv_frame - precvpriv - pfree_recv_queue - pattrib. Issue found with Coccinelle Signed-off-by:
-
Nishka Dasgupta authored
Remove the leading p from the following pointer variable names: - padapter - pusb_intf - ppmappedfw - praw - pfwpriv - pdvobj - pregpriv - pmappedfw (not in the same scope as ppmappedfw) - ptmpchar - ppayload - ptx_desc Issue found with Coccinelle. Signed-off-by:
-
Shobhit Kukreti authored
coccicheck reported Unneeded variable ret at rtl8723bs/core/rtw_ap.c:1400. Function "rtw_acl_remove_sta" always returns 0. Modified return type of the function to void. Signed-off-by:
Shobhit Kukreti <shobhitkukreti@gmail.com> Reviewed-by:
Bastien Nocera <hadess@hadess.net> Signed-off-by:
-
Shobhit Kukreti authored
Cleaned up the code to remove the error "(foo*)" should be "(foo *)" reported by checkpatch from the file rtl8723bs/os_dep/ioctl_linux.c Signed-off-by:
-
Maxime Desroches authored
Remove braces in a single line if statement in the vchiq_core.c file Signed-off-by:
Maxime Desroches <desroches.maxime@gmail.com> Signed-off-by:
-
- 06 Jun, 2019 4 commits
-
-
Geordan Neukum authored
The kpc_spi driver unnecessarily casts from a (u64 __iomem *) to a (void *) when invoking readq and writeq which both take a (void __iomem *) arg. There is no need for this cast, and it actually harms us by discarding the sparse cookie, __iomem. Make the driver stop performing this casting operation. Signed-off-by:
Geordan Neukum <gneukum1@gmail.com> Signed-off-by:
-
Geordan Neukum authored
The kpc_spi driver stashes off an unsigned long representation of the i/o mapping returned by devm_ioremap_nocache(). This is unnecessary, as the only use of the unsigned long repr is to eventually be re-cast to an (u64 __iomem *). Instead of casting the (void __iomem *) to an (unsigned long) then a (u64 __iomem *), just remove this intermediate step. As this intermediary is no longer used, also remove it from its structure. Signed-off-by:
-
Geordan Neukum authored
The structure kp_spi_controller_state, defined in the kpc2000_spi driver, contains a member named chip_select which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by:
-
Geordan Neukum authored
The structure kp_spi_controller_state, defined in the kpc2000_spi driver, contains a member named word_len which is never used after initialization. Therefore, it should be removed for simplicity's sake. Signed-off-by:
-
