- 10 Oct, 2013 7 commits
-
-
Marcel Holtmann authored
The function declaration goes over 80 characters, so break it down. Signed-off-by:
Marcel Holtmann <marcel@holtmann.org> Signed-off-by:
Johan Hedberg <johan.hedberg@intel.com>
-
Johan Hedberg authored
When the HCI_SETUP flag is set the controller has not yet been announced over mgmt and therefore doesn't exist from that perspective. If we nevertheless get a mgmt command for it we should respond with the appropriate INVALID_INDEX error. Signed-off-by:
-
Johan Hedberg authored
The l2cap_recv_frame function is expected to take ownership and eventually free the skb passed to it. We need to ensure that the conn->rx_skb pointer is no longer reachable when calling l2cap_recv_frame so that no other function, such as l2cap_conn_del, may think that it can free conn->rx_skb. An actual situation when this can happen is when smp_sig_channel (called from l2cap_recv_frame) fails and l2cap_conn_del gets called as a consequence. The l2cap_conn_del function would then try to free conn->rx_skb, but as the same skb was just passed to smp_sig_channel and freed we get a double-free. Signed-off-by:
-
Marcel Holtmann authored
The support for Bluetooth High Speed can only be enabled on controllers where also Secure Simple Pairing has been enabled. Trying to enable high speed when SSP is disabled will result into an error. Disabling SSP will at the same time disable high speed as well. It is required to enforce this dependency on SSP since high speed support is only defined for authenticated, unauthenticated and debug link keys. These link key types require SSP. Signed-off-by:
-
Marcel Holtmann authored
The variable val in the set_ssp() function of the management interface is not needed. Just use cp->val directly since its input values have already been validated. Signed-off-by:
-
Andre Guedes authored
This patch does some code refactoring in hci_connect_le() by moving the exception code into if statements and letting the main flow in first level of function scope. It also adds extra comments to improve the code readability. Signed-off-by:
Andre Guedes <andre.guedes@openbossa.org> Signed-off-by:
-
Andre Guedes authored
This patch introduces a new helper, which uses the HCI request framework, for creating LE connectons. All the handling is now done by this function so we can remove the hci_cs_le_create_conn() event handler. This patch also removes the old hci_le_create_connection() since it is not used anymore. Signed-off-by:
-
- 08 Oct, 2013 1 commit
-
-
Johan Hedberg authored
We only (re)enable advertising when LE is disconnected. Trying to enable advertising using mgmt_set_advertising while connected should simply change the flag but not do anything else (until the connection gets dropped). This patch fixes this by making an LE connection lookup to determine whether there are any connected devices or not. Signed-off-by:
-
- 07 Oct, 2013 17 commits
-
-
Johannes Berg authored
Sparse points out three places where variables are shadowed, rename two of the variables and remove the duplicate third. Signed-off-by:
Johannes Berg <johannes.berg@intel.com> Signed-off-by:
-
Marcel Holtmann authored
When initializing an AMP controller, read its current flow control mode so that the correct value is used. The AMP controller defaults to block based flow control and this extra command is just to double check. Signed-off-by:
-
Marcel Holtmann authored
When initializing an AMP controller, read its current known location data so that it can be analyzed later on. Signed-off-by:
-
Marcel Holtmann authored
The commands for reading supported features and commands are both supported by AMP controllers. Issue them during controller init phase so their values are known. Signed-off-by:
-
Marcel Holtmann authored
Within the AMP discover response, list powered down AMP controllers as powered down. No point in trying to make them look any different. Signed-off-by:
-
Marcel Holtmann authored
The management interface only operates on BR/EDR controllers. The check for the power down notification is a bit intermixed with the check if controller auto power off is active. Since there are more than just BR/EDR controllers supported, make this check explicit since the auto power off check also applies to AMP controllers and it has to happen in this exact order. Otherwise the bit will not be cleared. Signed-off-by:
-
Marcel Holtmann authored
Even AMP controllers should be powered off after the setup phase. It is not a good idea to keep AMP controllers powered on all the time if they are not in use. Power on of the AMP controller can either be done manually via command line commands or directly via A2MP. Especially since there is an indication in A2MP for powered down controllers that can be activated. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_discovering() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_remote_name() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_device_found() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_device_disconnected() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_device_connected() function is not used and so just change it to return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_connect_failed() function is not used so change it to just return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_disconnect_failed() function is not used so change it to just return void. Signed-off-by:
-
Marcel Holtmann authored
The return value of mgmt_set_powered_failed() function is never used and so make the function just return void. Signed-off-by:
-
Marcel Holtmann authored
The return value from mgmt_index_added() and mgmt_index_removed() functions is never used. So do not pretend that returning an error would actually be handled and just make both functions return void. Signed-off-by:
-
Marcel Holtmann authored
In case the current value of pairable is already configured, do not send a new settings event indicating that something has changed while in reality everything is the same. Signed-off-by:
-
- 06 Oct, 2013 15 commits
-
-
Marcel Holtmann authored
The helper function mgmt_valid_hdev() is more obfuscating the code then it makes it easier to read. So intead of this helper, use the direct check for BR/EDR device type. Signed-off-by:
-
Marcel Holtmann authored
The mgmt_new_settings() function was only needed to handle the error case when re-enabling advertising failed. Since that is now handled internally inside the management core, this function is not needed anymore. So just remove it. Signed-off-by:
-
Marcel Holtmann authored
When the all LE connections have been disconneted, then it is up to the host to re-enable advertising at that point. To ensure that the correct advertising parameters are used, force the usage of the common helper to enable advertising. The change just moves the manual enabling of advertising from the event handler into the management core so that the helper can be actually shared. Signed-off-by:
-
Marcel Holtmann authored
The LE advertising parameters can only be modified when advertising is disabled. So before enabling it, make sure the controller has all the right parameters. Right now all default values are used and thus this does no change any existing behavior. One minor exception is that in case of single mode LE-only controllers without a public address, now the random address is used for advertising. Signed-off-by:
-
Marcel Holtmann authored
Add constants for ADV_IND, ADV_DIRECT_IND, ADV_SCAN_IND and ADV_NONCONN_IND advertising types. Signed-off-by:
-
Marcel Holtmann authored
The tasks of enabling and disabling advertising are required in many cases. So refactor the actual HCI operations into two common helpers to make the code simpler. Signed-off-by:
-
Marcel Holtmann authored
This is not a functional change, just change the code to make it easy to understand that advertising gets disabled before LE support will be turned off. Signed-off-by:
-
Marcel Holtmann authored
Add the basic HCI structure for building the LE advertising parameters command. Signed-off-by:
-
Marcel Holtmann authored
For single mode LE-only controllers, it is possible that they come without a public address. If a public address is not available, then use the random address for connection establishment and scanning. Signed-off-by:
-
Marcel Holtmann authored
When counting the number for AMP controllers, a positive check is used. To be consistent, use the same check when actually adding the data for the AMP contollers. Signed-off-by:
-
Marcel Holtmann authored
The BR/EDR and LE setup procedures apply only to BR/EDR device types and so check for that explicitly. Checking that it is not an AMP controller is dangerous in case there will be ever a third device type. Signed-off-by:
-
Marcel Holtmann authored
In case of a single mode LE-only controller it is possible that no public address is used. These type of controllers require a random address to be configured. Without a configured static random address, such a controller is not functional. So reject powering on the controller in this case until it gets configured with a random address. The controller setup stage is still run since it is the only way to determinate if a public address is available or not. So it is similar on how RFKILL gets handled during initial setup of the controller. Signed-off-by:
-
Marcel Holtmann authored
Within the AMP discover response, all controllers that are not the primary BR/EDR controller are valid. Signed-off-by:
-
Marcel Holtmann authored
The check if a L2CAP connection is AMP capable was a little bit complicated. This changes the code to make it simpler and more readable. Signed-off-by:
-
Marcel Holtmann authored
The hci_amp_capable() function has only a single user inside the L2CAP core. Instead of exporting the function, place it next to its user. Signed-off-by:
-
