- 07 Apr, 2020 1 commit
-
-
Sam Ravnborg authored
Document the callbacks: drm_connector_helper_funcs.prepare_writeback_job drm_connector_helper_funcs.cleanup_writeback_job The documentation was pulled from the changelong introducing the callbacks, originally written by Laurent. Adding the missing documentation fixes the following warnings: drm_modeset_helper_vtables.h:1052: warning: Function parameter or member 'prepare_writeback_job' not described in 'drm_connector_helper_funcs' drm_modeset_helper_vtables.h:1052: warning: Function parameter or member 'cleanup_writeback_job' not described in 'drm_connector_helper_funcs' v2: - Fix formatting (Daniel) - Drop changelog text and add reference (Daniel) - Improve grammar. and use "operation" (Laurent) Signed-off-by:Sam Ravnborg <sam@ravnborg.org> Reviewed-by:
Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by:
Liviu Dudau <liviu.dudau@arm.com> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Cc: Maxime Ripard <mripard@kernel.org> Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: David Airlie <airlied@linux.ie> Link: https://patchwork.freedesktop.org/patch/msgid/20200406194746.26433-3-sam@ravnborg.org
-
- 06 Apr, 2020 3 commits
-
-
Lyude Paul authored
It looks like that when we introduced the ability to handle multiple down requests at once, we accidentally started dropping NAK replies - causing sideband messages which got NAK'd to seemingly timeout and cause all sorts of weirdness. So, fix this by making sure we don't return from drm_dp_mst_handle_down_rep() early, but instead treat NAKs like any other message. Signed-off-by:
Lyude Paul <lyude@redhat.com> Fixes: fbc821c4 ("drm/mst: Support simultaneous down replies") Cc: Wayne Lin <Wayne.Lin@amd.com> Cc: Wayne Lin <waynelin@amd.com> Cc: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20200403200325.885628-1-lyude@redhat.comReviewed-by:
Sean Paul <sean@poorly.run>
-
Lyude Paul authored
While we don't need this function to store an mstb anywhere for UP requests since we process them asynchronously, we do need to make sure that we don't try to write to **mstb for UP requests otherwise we'll cause a NULL pointer deref: RIP: 0010:drm_dp_get_one_sb_msg+0x4b/0x460 [drm_kms_helper] Call Trace: ? vprintk_emit+0x16a/0x230 ? drm_dp_mst_hpd_irq+0x133/0x1010 [drm_kms_helper] drm_dp_mst_hpd_irq+0x133/0x1010 [drm_kms_helper] ? __drm_dbg+0x87/0x90 [drm] ? intel_dp_hpd_pulse+0x24b/0x400 [i915] intel_dp_hpd_pulse+0x24b/0x400 [i915] i915_digport_work_func+0xd6/0x160 [i915] process_one_work+0x1a9/0x370 worker_thread+0x4d/0x3a0 kthread+0xf9/0x130 ? process_one_work+0x370/0x370 ? kthread_park+0x90/0x90 ret_from_fork+0x35/0x40 So, fix this. Signed-off-by: -
Markus Elfring authored
The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function. This issue was detected by using the Coccinelle software. Signed-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
Maxime Ripard <maxime@cerno.tech> Link: https://patchwork.freedesktop.org/patch/msgid/5a6cf5a7-3f27-5425-4d6a-550a17bc51e3@web.de
-
- 05 Apr, 2020 2 commits
-
-
Sam Ravnborg authored
Add missing documentation to fix following warning: panel.c:303: warning: Function parameter or member 'bridge' not described in 'drm_panel_bridge_connector' Signed-off-by:
-
Sam Ravnborg authored
Fix following warning: gpu_scheduler.h:103: warning: Function parameter or member 'priority' not described in 'drm_sched_entity' Signed-off-by:
-
- 03 Apr, 2020 12 commits
-
-
Lyude Paul authored
Now that we've removed the last user of this callback, get rid of it and drm_dp_destroy_connector(). Signed-off-by:
Alex Deucher <alexdeucher@gmail.com>
-
Lyude Paul authored
You can already trace the creation and destruction of connectors using DRM, and we definitely don't need to be printing info messages on connector hotplugs as well. So, get rid of these. Signed-off-by:
-
Lyude Paul authored
Pankaj Bharadiya started cleaning up the MST connector callbacks a while ago, as I pointed out that they are the same across every driver and don't serve much purpose. There was one callback that was left over though from amdgpu, that we delayed removing due to not being completely sure as to whether or not it was needed. So, I've read through said callback and can confirm it's not at all needed. Pretty much all of the work that is done in dm_dp_destroy_mst_connector() can be done in dm_dp_mst_connector_destroy(). Additionally, I've removed some bits that didn't actually do anything: * Removed DRM_INFO message we were printing, this shouldn't be info level and there's more appropriate drm debugging flags that should be used instead * Removed amdgpu_dm_update_freesync_caps() - reading into this function, it doesn't actually do anything important and I'm not sure why it was ever being called here * Stop clearing aconnector->dc_sink - this also doesn't do anything * Stop clearing link settings in dc_link - this also doesn't do anything * Also, use shorter variable Signed-off-by:
-
Lyude Paul authored
Doesn't do anything, noticed this while cleaning up some unrelated stuff. Signed-off-by:
-
Ville Syrjälä authored
The currently listed dotclock disagrees with the currently listed vrefresh rate. Change the dotclock to match the vrefresh. Someone tell me which (if either) of the dotclock or vreresh is correct? Cc: Heiko Stuebner <heiko.stuebner@theobroma-systems.com> Cc: Sam Ravnborg <sam@ravnborg.org> Signed-off-by:
Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200302203452.17977-6-ville.syrjala@linux.intel.comTested-by:
Heiko Stuebner <heiko.stuebner@theobroma-systems.com> Acked-by:
-
Daniel Vetter authored
It's empty! After more than 20 years of OS abstraction layer for pci devices, it's kinda gone now. Signed-off-by:
Daniel Vetter <daniel.vetter@intel.com> Signed-off-by:
-
Daniel Vetter authored
All other users have been removed, yay! Signed-off-by:
-
Gurchetan Singh authored
It always returns zero. Signed-off-by:
Gurchetan Singh <gurchetansingh@chromium.org> Link: http://patchwork.freedesktop.org/patch/msgid/20200401223039.2860-4-gurchetansingh@chromium.orgSigned-off-by:
Gerd Hoffmann <kraxel@redhat.com>
-
Gurchetan Singh authored
For 3D buffers, virtio_gpu_gem_object_open notifies. We can have the same behavior for dumb buffer. v2: virtio_gpu_gem_object_open always notifies v3: avoid boolean variable Signed-off-by:
Chia-I Wu <olvaffe@gmail.com> Link: http://patchwork.freedesktop.org/patch/msgid/20200401223039.2860-3-gurchetansingh@chromium.orgSigned-off-by:
-
Gurchetan Singh authored
The first 3D ioctl will take care of notification. Signed-off-by:
-
Gurchetan Singh authored
- Static-ify virtio_gpu_gem_create - Delete unused prototypes - Point to current implementation files Signed-off-by:
-
Tian Tao authored
because the hardware limitation,The initial color depth must set to 32bpp and must set the FB Offset of the display hardware to 128Byte alignment, which is used to solve the display problem at 800x600 and 1440x900 resolution under 16bpp. Signed-off-by:
Tian Tao <tiantao6@hisilicon.com> Signed-off-by:
Gong junjie <gongjunjie2@huawei.com> Acked-by:
Xinliang Liu <xinliang.liu@linaro.org> Signed-off-by:
-
- 02 Apr, 2020 21 commits
-
-
Thomas Zimmermann authored
The zte driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by:
-
Thomas Zimmermann authored
The vkms driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The virtgpu driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The vc4 driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
Eric Anholt <eric@anholt.net> Link: https://patchwork.freedesktop.org/patch/msgid/20200305155950.2705-19-tzimmermann@suse.de
-
Thomas Zimmermann authored
The tilcdc driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
Jyri Sarha <jsarha@ti.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200305155950.2705-18-tzimmermann@suse.de
-
Thomas Zimmermann authored
The tidss driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The tegra driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The ingenic driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The shmobile driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The rockchip driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The rcar-du driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The mediatek driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by:
CK Hu <ck.hu@mediatek.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200305155950.2705-11-tzimmermann@suse.de
-
Thomas Zimmermann authored
The ingenic driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The imx driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The tda998x driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The kirin driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The gma500 driver uses empty implementations for some of its encoders. Replace the code with the generic simple encoder. As a side effect, the patch also removes an indirection in the encoder setup for Medfield. Signed-off-by:
-
Thomas Zimmermann authored
The fsl-dcu driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The exynos driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by:
-
Thomas Zimmermann authored
The atmel-hlcdc driver uses an empty implementation for its encoder. Replace the code with the generic simple encoder. Signed-off-by:
-
Laurent Pinchart authored
The example code showing how to use the managed resource API calls kfree() on the wrong pointer. Fix it. Signed-off-by:
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by:
-
- 01 Apr, 2020 1 commit
-
-
Andrzej Pietrasiewicz authored
Some drivers (komeda, malidp) don't set anything in cpp. If that is the case the right value can be inferred from the format. Then the "bpp" member can be eliminated from struct drm_afbc_framebuffer. Signed-off-by:
Andrzej Pietrasiewicz <andrzej.p@collabora.com> Acked-by:
-
