- 28 Jan, 2015 16 commits
-
-
H Hartley Sweeten authored
Clarify the (*attach) a bit by introducing a helper function to handle the setup of the analog output 'range_table'. Some of the boards supported by this driver do not have programmable ranges. The analog output subdevice can use optional range information provided by the user during the attach of the driver. Currently this range data is allocated and stored in the private data. Use the subdevice private data member instead and allocate the memory with comedi_alloc_spriv(). The comedi core will automatically free this memory when the driver is detached. If the allocation fails set the 'range_table' to 'range_unknown' instead of failing the driver attach. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
Clarify the (*attach) a bit by introducing a helper function to handle the setup of the analog input 'range_table'. Some of the boards supported by this driver do not have programmable ranges. The analog input subdevice can use optional range information provided by the user during the attach of the driver. Currently this range data is allocated and stored in the private data. Use the subdevice private data member instead and allocate the memory with comedi_alloc_spriv(). The comedi core will automatically free this memory when the driver is detached. If the allocation fails set the 'range_table' to 'range_unknown' instead of failing the driver attach. Signed-off-by:
-
H Hartley Sweeten authored
This function is only called by das16_cancel(). Absorb it to clarify code. Signed-off-by:
-
H Hartley Sweeten authored
The das16_ai_disable() function disables interrupts and the pacer clock. This function is called by the subdevice (*cancel) operation. The comedi core will not call a subdevice (*insn_read) operation while an async command is running due to the s->busy check in parse_insn(). Since all async commands are terminated by a (*cancel), the das16_ai_disable() is not necessary in das16_ai_insn_read(). Remove it. Signed-off-by:
-
H Hartley Sweeten authored
This function is only called by das16_cmd_exec(). Absorb it to clarify code. Signed-off-by:
-
Vaishali Thakkar authored
This patch introduces the use of function put_unaligned_le16. This is done using Coccinelle and semantic patch used is as follows: @A@ typedef u16, __le16, uint16_t; {u16,__le16,uint16_t} e16; identifier tmp; expression ptr; expression y,e; type T; type T; @@ - tmp = cpu_to_le16(y); <+... when != tmp ( - memcpy(ptr, (T)&tmp, \(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(uint16_t)\|sizeof(e16)\)); + put_unaligned_le16(y,ptr); | - memcpy(ptr, (T)&tmp, ...); + put_unaligned_le16(y,ptr); ) ...+> ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by:
Vaishali Thakkar <vthakkar1994@gmail.com> Signed-off-by:
-
Lorenzo Stoakes authored
This patch fixes warnings raised by checkpatch.pl relating to heavily indented lines in r8192U_dm.c by refactoring code to achieve the same outcome indented by one less tab. Signed-off-by:
Lorenzo Stoakes <lstoakes@gmail.com> Signed-off-by:
-
Lorenzo Stoakes authored
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by:
-
Lorenzo Stoakes authored
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c, removes inconsistent whitespace, and additionally fixes some vertical alignment issues. Signed-off-by:
-
Lorenzo Stoakes authored
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c, and cleans up existing ANSI C comments. Signed-off-by:
-
Kumar Amit Mehta authored
In rtw_check_bcn_info(), check the return value of kzalloc() before dereferencing it, to avoid NULL pointer dereference. Signed-off-by:
Kumar Amit Mehta <gmate.amit@gmail.com> Signed-off-by:
-
Heba Aamer authored
This patch removes an unneeded call to printk. Signed-off-by:
Heba Aamer <heba93aamer@gmail.com> Signed-off-by:
-
Zachary Warren authored
Avoids the following warnings from sparse: visorchannel_funcs.c:457:9: warning: context imbalance in 'visorchannel_signalremove' - different lock contexts for basic block visorchannel_funcs.c:512:9: warning: context imbalance in 'visorchannel_signalinsert' - different lock contexts for basic These warnings are false positives. Sparse can't track conditional contexts. The change puts the lock/unlock into the same context by splitting the insert/remove functions each into a wrapper function that does locking if necessary and an inner function that does the insert/remove operation. Signed-off-by:
Zachary Warren <conflatulence@gmail.com> Acked-by:
Benjamin Romer <benjamin.romer@unisys.com> Signed-off-by:
-
Kumar Amit Mehta authored
In mdc_kuc_write(), OBD_ALLOC(lh, len) may leave 'lh' to NULL as kmalloc may fail to allocate memory. This fix adds a check to avoid, dereferencing a NULL pointer. Signed-off-by:
-
Kumar Amit Mehta authored
OBD_ALLOC_PTR(uuid) invokes kmalloc, which may return NULL. This fix adds a check before dereferencing such pointer. Signed-off-by:
-
Rickard Strandqvist authored
Wrong type in printf format string, requires 'unsigned int' but the argument type is 'int' This was found using a static code analysis program called cppcheck Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by:
-
- 25 Jan, 2015 24 commits
-
-
Sudip Mukherjee authored
checkpatch cleanup: alignment should match open parenthesis Signed-off-by:
Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:
-
Sudip Mukherjee authored
checkpatch cleanup: blank lines are not necessary before closing brace and after opening brace. Signed-off-by:
-
Sudip Mukherjee authored
checkpatch cleanup: space is not necessary after cast Signed-off-by:
-
Sudip Mukherjee authored
checkpatch cleanup to add missing blank line after declaration Signed-off-by:
-
Sudip Mukherjee authored
add myself and Teddy Wang as the Maintainer of the SM7XX FRAME BUFFER DRIVER. Signed-off-by:
-
Sudip Mukherjee authored
update the email addresses in the TODO file, also update the final destination of this driver. Signed-off-by:
-
Sudip Mukherjee authored
This reverts commit "dc93c852" Signed-off-by:
-
John Stultz authored
The functionality provided by the Android alarm-dev driver should now be present in the timerfd interface (thanks to Greg Hackmann and Todd Poynor). As of Lollipop, AOSP can make use of the timerfd if alarm-dev is not present (though a fixup for setting the rtc time if rtc0 isn't the backing for _ALARM clockids has been applied post-Lollipop). Thus, we should be able to remove alarm-dev from staging. Cc: Greg Hackmann <ghackmann@google.com> Cc: Elliott Hughes <enh@google.com> Cc: Todd Poynor <toddpoynor@google.com> Cc: Android Kernel Team <kernel-team@android.com> Signed-off-by:
John Stultz <john.stultz@linaro.org> Acked-by:
Mark Salyzyn <salyzyn@google.com> Signed-off-by:
-
Daeseok Youn authored
cppcheck warning: (warnning) Logical disjunction always evaluates to true Reported-by:
David Binderman <dcb314@hotmail.com> Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Krzysztof Adamski authored
This fixes sparse warnings like: warning: symbol XXX was not declared. Should it be static? by declaring all local functions static. Signed-off-by:Krzysztof Adamski <k@japko.eu> Signed-off-by:
-
Andrew Milkovich authored
This patch fixes the following checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parentheses Outer parentheses were added to macro definitions. Signed-off-by:
Andrew Milkovich <amilkovich@gmail.com> Signed-off-by:
-
Krzysztof Adamski authored
This patch fixes coding style of PCI device table declaration. Signed-off-by:
-
Nicholas Mc Guire authored
This is only an API consolidation and should make things more readable Converting milliseconds to jiffies by val * HZ / 1000 is technically not wrong but msecs_to_jiffies(val) is the cleaner solution and handles corner cases correctly. Signed-off-by:
Nicholas Mc Guire <der.herr@hofr.at> Signed-off-by:
-
Asaf Vertz authored
Fixed the following warnings (reported by sparse): drivers/staging/wlan-ng/hfa384x_usb.c:3828:36: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3229:16: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3430:18: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3349:51: warning: restricted __le16 degrades to integer drivers/staging/wlan-ng/hfa384x_usb.c:3357:37: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3358:37: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3393:36: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3102:28: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3004:28: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:1308:37: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:2713:25: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/hfa384x_usb.c:2713:25: expected unsigned short [unsigned] [usertype] type drivers/staging/wlan-ng/hfa384x_usb.c:2713:25: got restricted __le16 [usertype] <noident> Signed-off-by:
Asaf Vertz <asaf.vertz@tandemg.com> Signed-off-by:
-
Sudip Mukherjee authored
mp_query_drv_var() was only being used by oid_rt_pro_query_dr_variable_hdl() but after commit <f4f5a59f> mp_query_drv_var() became unused. so it is safe to remove it. Signed-off-by:
-
Peter Poklop authored
This patch fixes the checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by:
Peter Poklop <peter.poklop@gmail.com> Signed-off-by:
-
Rickard Strandqvist authored
Remove the function r8712_os_read_port() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by:
-
Rickard Strandqvist authored
Removes some functions that are not used anywhere: rtw_set_ch_cmd23a() rtw_cmd_clr_isr23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by:
-
Rickard Strandqvist authored
Removes some functions that are not used anywhere: rtw_hw_resume23a() rtw_hw_suspend23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by:
-
Benjamin Romer authored
Fix CamelCase variable name: Features_addr => features_addr Update references to use the new name. Signed-off-by:
-
Benjamin Romer authored
Fix CamelCase local variable name: pChannelHeader => channel_header Update references to use the new name. Signed-off-by:
-
Benjamin Romer authored
Fix CamelCase names: virthba_ISR => virthba_isr pChannelHeader => channel_header Update all references to the modified names. Signed-off-by:
-
Ken Depro authored
This patch fixes CamelCase function names in virthba.c, reported by the checkpatch script: doDiskAddRemove --> do_disk_add_remove SendDiskAddRemove --> send_disk_add_remove Signed-off-by:
Ken Depro <kenneth.depro@unisys.com> Signed-off-by:
-
Ken Depro authored
This patch fixes the remaining CamelCase global variables in virthba.c reported by the checkpatch script: MaxBuffLen --> max_buff_len VirtHbasOpen --> virthbas_open Signed-off-by:
-
