1. 27 Jul, 2021 1 commit
    • Peter Ujfalusi's avatar
      ASoC: topology: Select SND_DYNAMIC_MINORS · 2635c226
      Peter Ujfalusi authored
      The indexes of the devices are described within the topology file, it is a
      possibility that the topology encodes invalid indexes when DYNAMIC_MINORS
      is not enabled in kernel:
      
       #define SNDRV_MINOR_COMPRESS		2	/* 2 - 3 */
       #define SNDRV_MINOR_HWDEP		4	/* 4 - 7 */
       #define SNDRV_MINOR_RAWMIDI		8	/* 8 - 15 */
       #define SNDRV_MINOR_PCM_PLAYBACK	16	/* 16 - 23 */
       #define SNDRV_MINOR_PCM_CAPTURE	24	/* 24 - 31 */
      
      If the topology assigns an index greater than 7 for PLAYBACK/CAPTURE PCM
      then there will be minor number collision.
      
      As an example:
      card0 creates a capture PCM with index 10 -> minor = 34
      card1 creates compress device with index 0 -> minor = 34
      
      Card1 will fail to instantiate because the minor for the compress stream is
      already taken.
      
      To avoid seemingly mysterious issues with card creation, select the
      DYNAMIC_MINORS when the topology is enabled.
      
      The other option would be to try to do out of bound index checks in case of
      DYNAMIC_MINOR is not enabled and do not even attempt to create the device
      with failing the topology load.
      Signed-off-by: default avatarPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
      Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
      Link: https://lore.kernel.org/r/20210726182142.179604-1-pierre-louis.bossart@linux.intel.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      2635c226
  2. 26 Jul, 2021 2 commits
  3. 22 Jul, 2021 5 commits
  4. 19 Jul, 2021 2 commits
  5. 16 Jul, 2021 4 commits
  6. 15 Jul, 2021 1 commit
  7. 14 Jul, 2021 2 commits
  8. 12 Jul, 2021 2 commits
    • Maxim Schwalm's avatar
      ASoC: rt5631: Fix regcache sync errors on resume · c71f78a6
      Maxim Schwalm authored
      The ALC5631 does not like multi-write accesses, avoid them. This fixes:
      
      rt5631 4-001a: Unable to sync registers 0x3a-0x3c. -121
      
      errors on resume from suspend (and all registers after the registers in
      the error not being synced).
      
      Inspired by commit 2d30e949 ("ASoC: rt5651: Fix regcache sync errors
      on resume") from Hans de Geode, which fixed the same errors on ALC5651.
      Signed-off-by: default avatarMaxim Schwalm <maxim.schwalm@gmail.com>
      Link: https://lore.kernel.org/r/20210712005011.28536-1-digetx@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
      c71f78a6
    • Mark Brown's avatar
      Merge series "arm64: tegra: Enable audio IOMMU support on Tegra194" from... · 11169c6e
      Mark Brown authored
      Merge series "arm64: tegra: Enable audio IOMMU support on Tegra194" from Thierry Reding <thierry.reding@gmail.com>
      Thierry Reding <treding@nvidia.com>:
      
      From: Thierry Reding <treding@nvidia.com>
      
      This small series addresses a minor issue with how IOMMU support is
      wired up on various Tegra generations. Currently the virtual "card"
      device is used to allocate DMA memory for, but since that device does
      not actually exist, the path to memory cannot be correctly described.
      
      To address this, this series moves to using the ADMAIF as the DMA device
      for audio. This is a real device that can have a proper DMA mask set and
      with which a stream ID can be associated with in the SMMU. The memory
      accesses technically originate from the ADMA controller (that the ADMAIF
      uses), but DMA channel are dynamically allocated at runtime while DMA
      memory is allocated at driver load time, drivers won't have access to
      the ADMA device yet.
      
      Further patches will be required to correct this issue on Tegra186 and
      Tegra210, but I wanted to get feedback on this approach first.
      
      Changes in v2:
      - add backwards-compatibility fallback
      
      Thierry
      
      Thierry Reding (2):
        ASoC: tegra: Use ADMAIF component for DMA allocations
        arm64: tegra: Enable audio IOMMU support on Tegra194
      
       arch/arm64/boot/dts/nvidia/tegra194.dtsi |  4 ++++
       sound/soc/tegra/tegra_pcm.c              | 30 ++++++++++++++----------
       2 files changed, 22 insertions(+), 12 deletions(-)
      
      --
      2.32.0
      11169c6e
  9. 11 Jul, 2021 3 commits
  10. 01 Jul, 2021 1 commit
  11. 30 Jun, 2021 1 commit
  12. 28 Jun, 2021 5 commits
  13. 24 Jun, 2021 1 commit
  14. 23 Jun, 2021 10 commits