1. 28 Oct, 2012 20 commits
    • Mauro Carvalho Chehab's avatar
      [media] m2m-deinterlace: remove unused vars · 2869a318
      Mauro Carvalho Chehab authored
      drivers/media/platform/m2m-deinterlace.c:229:15: warning: variable 'd_size' set but not used [-Wunused-but-set-variable]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      2869a318
    • Mauro Carvalho Chehab's avatar
      [media] meye: fix a warning · 83fa235b
      Mauro Carvalho Chehab authored
      drivers/media/pci/meye/meye.c:1948:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      83fa235b
    • Mauro Carvalho Chehab's avatar
      [media] saa7134,saa7164: warning: comparison of unsigned fixes · 3eeba4a7
      Mauro Carvalho Chehab authored
      drivers/media/pci/saa7134/saa7134-core.c:947:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/saa7164/saa7164-core.c:413:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/pci/saa7164/saa7164-core.c:489:3: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/pci/saa7134/saa7134-video.c:2514:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      3eeba4a7
    • Mauro Carvalho Chehab's avatar
      [media] ngene: better comment unused code to avoid warnings · 2827a440
      Mauro Carvalho Chehab authored
      get rid of a few warnings about empty body:
      drivers/media/pci/ngene/ngene-core.c:756:3: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
      drivers/media/pci/ngene/ngene-cards.c:429:5: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
      Those are due to some commented code.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      2827a440
    • Mauro Carvalho Chehab's avatar
      [media] soc_camera/ov2640: Don't use a temp var for an unused value · ba400892
      Mauro Carvalho Chehab authored
      drivers/media/i2c/soc_camera/ov2640.c:899:32: warning: variable 'win' set but not used [-Wunused-but-set-variable]
      
      Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      ba400892
    • Mauro Carvalho Chehab's avatar
      [media] dvb-frontends: get rid of some "always false" warnings · 830e4b55
      Mauro Carvalho Chehab authored
      On gcc, enums are generally unsigned, except if a negative value
      is declared. Due to that, warnings may happen there:
      drivers/media/dvb-frontends/cx22700.c:142:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/cx22700.c:155:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/cx24123.c:341:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/l64781.c:183:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/l64781.c:187:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/mt312.c:552:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      drivers/media/dvb-frontends/mt312.c:560:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      As other compilers might be using signed values, the better is to
      keep the checks there, casting the value to avoid the warning.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      830e4b55
    • Mauro Carvalho Chehab's avatar
      [media] drxk: get rid of some unused vars · 5a70972e
      Mauro Carvalho Chehab authored
      drivers/media/dvb-frontends/drxk_hard.c:68:13: warning: 'IsA1WithPatchCode' defined but not used [-Wunused-function]
      drivers/media/dvb-frontends/drxk_hard.c:73:13: warning: 'IsA1WithRomCode' defined but not used [-Wunused-function]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      5a70972e
    • Mauro Carvalho Chehab's avatar
      [media] dmxdev: fix a comparition of unsigned expression warning · 31becf09
      Mauro Carvalho Chehab authored
      drivers/media/dvb-core/dmxdev.c: In function 'dvb_dmxdev_pes_filter_set':
      drivers/media/dvb-core/dmxdev.c:880:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      31becf09
    • Mauro Carvalho Chehab's avatar
      [media] cx88: get rid of a warning at dprintk() macro · db613710
      Mauro Carvalho Chehab authored
      drivers/media/pci/cx88/cx88-mpeg.c: In function 'cx8802_mpeg_irq':
      drivers/media/pci/cx88/cx88-mpeg.c:419:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-mpeg.c: In function 'cx8802_irq':
      drivers/media/pci/cx88/cx88-mpeg.c:453:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-alsa.c: In function 'snd_cx88_create':
      drivers/media/pci/cx88/cx88-alsa.c:818:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-alsa.c:837:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-alsa.c: In function 'cx88_audio_initdev':
      drivers/media/pci/cx88/cx88-alsa.c:912:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_mbox_func':
      drivers/media/pci/cx88/cx88-blackbird.c:327:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:333:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:360:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_find_mailbox':
      drivers/media/pci/cx88/cx88-blackbird.c:421:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_load_firmware':
      drivers/media/pci/cx88/cx88-blackbird.c:444:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:451:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:453:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:459:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:466:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:487:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:492:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:503:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c: In function 'blackbird_initialize_codec':
      drivers/media/pci/cx88/cx88-blackbird.c:560:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:566:4: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      drivers/media/pci/cx88/cx88-blackbird.c:569:3: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      db613710
    • Mauro Carvalho Chehab's avatar
      [media] cx88: reorder inline to prevent a gcc warning · 34206439
      Mauro Carvalho Chehab authored
      drivers/media/pci/cx88/cx88.h:97:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88.h:103:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:649:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:654:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:659:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:664:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:684:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      drivers/media/pci/cx88/cx88-core.c:695:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      34206439
    • Mauro Carvalho Chehab's avatar
      [media] dvb_frontend: Don't declare values twice at a table · e6ea0b91
      Mauro Carvalho Chehab authored
      drivers/media/dvb-core/dvb_frontend.c:1032:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1032:2: warning: (near initialization for 'dtv_cmds[36]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1033:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1033:2: warning: (near initialization for 'dtv_cmds[37]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1034:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1034:2: warning: (near initialization for 'dtv_cmds[38]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1035:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1035:2: warning: (near initialization for 'dtv_cmds[39]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1036:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1036:2: warning: (near initialization for 'dtv_cmds[40]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1037:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1037:2: warning: (near initialization for 'dtv_cmds[60]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1045:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1045:2: warning: (near initialization for 'dtv_cmds[46]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1051:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1051:2: warning: (near initialization for 'dtv_cmds[52]') [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1060:2: warning: initialized field overwritten [-Woverride-init]
      drivers/media/dvb-core/dvb_frontend.c:1060:2: warning: (near initialization for 'dtv_cmds[61]') [-Woverride-init]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      e6ea0b91
    • Mauro Carvalho Chehab's avatar
      [media] go7007-v4l2: warning fix: index is unsigned, so it will never be below 0 · 902e4575
      Mauro Carvalho Chehab authored
      drivers/staging/media/go7007/go7007-v4l2.c: In function 'vidioc_qbuf':
      drivers/staging/media/go7007/go7007-v4l2.c:815:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      902e4575
    • Mauro Carvalho Chehab's avatar
      [media] dt3155v4l: vb2_queue_init() can now fail. Check is required · 067d8513
      Mauro Carvalho Chehab authored
      drivers/staging/media/dt3155v4l/dt3155v4l.c: In function 'dt3155_open':
      drivers/staging/media/dt3155v4l/dt3155v4l.c:399:17: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      067d8513
    • Mauro Carvalho Chehab's avatar
      [media] gspca: warning fix: index is unsigned, so it will never be below 0 · 3a70c3fb
      Mauro Carvalho Chehab authored
      drivers/media/usb/gspca/gspca.c: In function 'vidioc_querybuf':
      drivers/media/usb/gspca/gspca.c:1590:6: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      
      Cc: Hans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      3a70c3fb
    • Mauro Carvalho Chehab's avatar
      [media] jeilinj: fix return of the response code · 9825f376
      Mauro Carvalho Chehab authored
      drivers/media/usb/gspca/jeilinj.c: In function 'jlj_read1':
      drivers/media/usb/gspca/jeilinj.c:117:66: warning: parameter 'response' set but not used [-Wunused-but-set-parameter]
      The code still doesn't make much sense, as response is never tested
      there.
      
      Cc: Hans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      9825f376
    • Mauro Carvalho Chehab's avatar
      [media] gscpa: get rid of warning: suggest braces around empty body · ede4c3a5
      Mauro Carvalho Chehab authored
      There are hundreds of messages like this one, when GSPCA debug is
      disabled, when compiled with W=1:
      drivers/media/usb/gspca/spca500.c:725:46: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
      Get rid of it, especially as it might actually cause troubles on
      some places.
      
      Cc: Hans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      ede4c3a5
    • Mauro Carvalho Chehab's avatar
      [media] dib9000: get rid of warning: no previous prototype · 2e8c1e56
      Mauro Carvalho Chehab authored
      drivers/media/dvb-frontends/dib9000.h:100:5: warning: no previous prototype for 'dib9000_remove_slave_frontend' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      2e8c1e56
    • Mauro Carvalho Chehab's avatar
      [media] pwc-if: must check vb2_queue_init() success · eda94710
      Mauro Carvalho Chehab authored
      drivers/media/usb/pwc/pwc-if.c: In function 'usb_pwc_probe':
      drivers/media/usb/pwc/pwc-if.c:1003:16: warning: ignoring return value of 'vb2_queue_init', declared with attribute warn_unused_result [-Wunused-result]
      In the past, it used to have a logic there at queue init that would
      BUG() on errors. This logic got removed. Drivers are now required
      to explicitly handle the queue initialization errors, or very bad
      things may happen.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      eda94710
    • Mauro Carvalho Chehab's avatar
      [media] pwc-if: get rid of warning: no previous prototype · 0dc6eb9f
      Mauro Carvalho Chehab authored
      drivers/media/usb/pwc/pwc-if.c:158:23: warning: no previous prototype for 'pwc_get_next_fill_buf' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      0dc6eb9f
    • Mauro Carvalho Chehab's avatar
      [media] pvrusb2: get rid of warning: no previous prototype · f4a51222
      Mauro Carvalho Chehab authored
      drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:199:5: warning: no previous prototype for 'pvr2_s_std' [-Wmissing-prototypes]
      drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:368:5: warning: no previous prototype for 'pvr2_s_frequency' [-Wmissing-prototypes]
      Acked-by: default avatarMike Isely <isely@pobox.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      f4a51222
  2. 27 Oct, 2012 20 commits
    • Mauro Carvalho Chehab's avatar
      [media] vp702x: get rid of warning: no previous prototype · d9e81a5c
      Mauro Carvalho Chehab authored
      drivers/media/usb/dvb-usb/vp702x.c:70:5: warning: no previous prototype for 'vp702x_usb_out_op_unlocked' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb/vp702x.c:89:5: warning: no previous prototype for 'vp702x_usb_out_op' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      d9e81a5c
    • Mauro Carvalho Chehab's avatar
      [media] lmedm04: get rid of warning: no previous prototype · 1885fd2d
      Mauro Carvalho Chehab authored
      drivers/media/usb/dvb-usb-v2/lmedm04.c:802:13: warning: no previous prototype for 'lme_firmware_switch' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      1885fd2d
    • Mauro Carvalho Chehab's avatar
      [media] dvb-usb-v2: get rid of warning: no previous prototype · 691a5502
      Mauro Carvalho Chehab authored
      drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:227:5: warning: no previous prototype for 'dvb_usbv2_adapter_stream_init' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:239:5: warning: no previous prototype for 'dvb_usbv2_adapter_stream_exit' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:372:5: warning: no previous prototype for 'dvb_usbv2_adapter_dvb_init' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:444:5: warning: no previous prototype for 'dvb_usbv2_adapter_dvb_exit' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:460:5: warning: no previous prototype for 'dvb_usbv2_device_power_ctrl' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:557:5: warning: no previous prototype for 'dvb_usbv2_adapter_frontend_init' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/dvb_usb_core.c:626:5: warning: no previous prototype for 'dvb_usbv2_adapter_frontend_exit' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/usb_urb.c:115:5: warning: no previous prototype for 'usb_urb_free_urbs' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/usb_urb.c:208:5: warning: no previous prototype for 'usb_free_stream_buffers' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb-v2/usb_urb.c:226:5: warning: no previous prototype for 'usb_alloc_stream_buffers' [-Wmissing-prototypes]
      
      Cc: Antti Palosaari <crope@iki.fi>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      691a5502
    • Mauro Carvalho Chehab's avatar
      [media] az6027: get rid of warning: no previous prototype · 64592d0c
      Mauro Carvalho Chehab authored
      drivers/media/usb/dvb-usb/az6027.c:1054:5: warning: no previous prototype for 'az6027_identify_state' [-Wmissing-prototypes]
      drivers/media/usb/dvb-usb/az6027.c:301:5: warning: no previous prototype for 'az6027_usb_in_op' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      64592d0c
    • Mauro Carvalho Chehab's avatar
      [media] cx231xx-avcore: get rid of a sophisticated do-nothing code · fb1546e0
      Mauro Carvalho Chehab authored
      drivers/media/usb/cx231xx/cx231xx-avcore.c: In function 'cx231xx_capture_start':
      drivers/media/usb/cx231xx/cx231xx-avcore.c:2637:3: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      fb1546e0
    • Mauro Carvalho Chehab's avatar
      [media] cx231xx: get rid of warning: no previous prototype · d4c06133
      Mauro Carvalho Chehab authored
      drivers/media/usb/cx231xx/cx231xx-avcore.c:1071:5: warning: no previous prototype for 'stopAudioFirmware' [-Wmissing-prototypes]
      drivers/media/usb/cx231xx/cx231xx-avcore.c:1076:5: warning: no previous prototype for 'restartAudioFirmware' [-Wmissing-prototypes]
      drivers/media/usb/cx231xx/cx231xx-cards.c:689:6: warning: no previous prototype for 'cx231xx_reset_out' [-Wmissing-prototypes]
      drivers/media/usb/cx231xx/cx231xx-cards.c:697:6: warning: no previous prototype for 'cx231xx_enable_OSC' [-Wmissing-prototypes]
      drivers/media/usb/cx231xx/cx231xx-cards.c:701:6: warning: no previous prototype for 'cx231xx_sleep_s5h1432' [-Wmissing-prototypes]
      drivers/media/usb/cx231xx/cx231xx-i2c.c:75:5: warning: no previous prototype for 'cx231xx_i2c_send_bytes' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      d4c06133
    • Mauro Carvalho Chehab's avatar
      [media] au0828: get rid of warning: no previous prototype · a094ca46
      Mauro Carvalho Chehab authored
      drivers/media/usb/au0828/au0828-cards.c:28:6: warning: no previous prototype for 'hvr950q_cs5340_audio' [-Wmissing-prototypes]
      drivers/media/usb/au0828/au0828-video.c:161:6: warning: no previous prototype for 'au0828_uninit_isoc' [-Wmissing-prototypes]
      drivers/media/usb/au0828/au0828-video.c:200:5: warning: no previous prototype for 'au0828_init_isoc' [-Wmissing-prototypes]
      drivers/media/usb/au0828/au0828-video.c:786:5: warning: no previous prototype for 'au0828_analog_stream_enable' [-Wmissing-prototypes]
      drivers/media/usb/au0828/au0828-video.c:813:6: warning: no previous prototype for 'au0828_analog_stream_reset' [-Wmissing-prototypes]
      drivers/media/usb/au0828/au0828-video.c:916:6: warning: no previous prototype for 'au0828_vid_buffer_timeout' [-Wmissing-prototypes]
      drivers/media/usb/au0828/au0828-video.c:940:6: warning: no previous prototype for 'au0828_vbi_buffer_timeout' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      a094ca46
    • Mauro Carvalho Chehab's avatar
      [media] max2165: get rid of warning: no previous prototype · 5e04f920
      Mauro Carvalho Chehab authored
      drivers/media/tuners/max2165.c:164:5: warning: no previous prototype for 'fixpt_div32' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      5e04f920
    • Mauro Carvalho Chehab's avatar
      [media] nuvoton-cir: carrier detect support is broken - remove it · 230dc94a
      Mauro Carvalho Chehab authored
      The carrier detect return value is never used on nuvoton driver:
      drivers/media/rc/nuvoton-cir.c: In function 'nvt_process_rx_ir_data':
      drivers/media/rc/nuvoton-cir.c:623:6: warning: variable 'carrier' set but not used [-Wunused-but-set-variable]
      Also, this would be called only if a boolean variable is enabled,
      but there's no condition that enables it inside the driver. So,
      comment the carrier detection code, as it might be useful later,
      and remove the unused glue code.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      230dc94a
    • Mauro Carvalho Chehab's avatar
      [media] nuvoton-cir: get rid of warning: no previous prototype · 8e1803f4
      Mauro Carvalho Chehab authored
      drivers/media/rc/nuvoton-cir.c:1223:5: warning: no previous prototype for 'nvt_init' [-Wmissing-prototypes]
      drivers/media/rc/nuvoton-cir.c:1228:6: warning: no previous prototype for 'nvt_exit' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      8e1803f4
    • Mauro Carvalho Chehab's avatar
      [media] ite-cir.c: get rid of warning: no previous prototype · 3d4bf09c
      Mauro Carvalho Chehab authored
      drivers/media/rc/ite-cir.c:1711:5: warning: no previous prototype for 'ite_init' [-Wmissing-prototypes]
      drivers/media/rc/ite-cir.c:1716:6: warning: no previous prototype for 'ite_exit' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      3d4bf09c
    • Mauro Carvalho Chehab's avatar
      [media] ene_cir: get rid of warning: no previous prototype · e03cd645
      Mauro Carvalho Chehab authored
      drivers/media/rc/ene_ir.c:332:6: warning: no previous prototype for 'ene_rx_sense_carrier' [-Wmissing-prototypes]
      
      Cc: Maxim Levitsky <maximlevitsky@gmail.com>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      e03cd645
    • Mauro Carvalho Chehab's avatar
      [media] radio-sf16fmi: get rid of warning: no previous prototype · a5133b17
      Mauro Carvalho Chehab authored
      drivers/media/radio/radio-sf16fmi.c:67:6: warning: no previous prototype for 'fmi_set_pins' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      a5133b17
    • Mauro Carvalho Chehab's avatar
      [media] radio-isa: get rid of warning: no previous prototype · 4b644dcc
      Mauro Carvalho Chehab authored
      drivers/media/radio/radio-isa.c:194:24: warning: no previous prototype for 'radio_isa_alloc' [-Wmissing-prototypes]
      drivers/media/radio/radio-isa.c:210:5: warning: no previous prototype for 'radio_isa_common_probe' [-Wmissing-prototypes]
      drivers/media/radio/radio-isa.c:290:5: warning: no previous prototype for 'radio_isa_common_remove' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      4b644dcc
    • Mauro Carvalho Chehab's avatar
      [media] radio-aimslab.c: get rid of warning: no previous prototype · f6d15e09
      Mauro Carvalho Chehab authored
      drivers/media/radio/radio-aimslab.c:85:6: warning: no previous prototype for 'rtrack_set_pins' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      f6d15e09
    • Mauro Carvalho Chehab's avatar
      [media] saa7164: get rid of warning: no previous prototype · 5faf7db8
      Mauro Carvalho Chehab authored
      drivers/media/pci/saa7164/saa7164-api.c:1489:5: warning: no previous prototype for 'saa7164_api_modify_gpio' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-api.c:168:5: warning: no previous prototype for 'saa7164_api_set_gop_size' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-api.c:622:5: warning: no previous prototype for 'saa7164_api_set_dif' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-api.c:825:5: warning: no previous prototype for 'saa7164_api_configure_port_vbi' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-api.c:861:5: warning: no previous prototype for 'saa7164_api_configure_port_mpeg2ts' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-api.c:895:5: warning: no previous prototype for 'saa7164_api_configure_port_mpeg2ps' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-api.c:928:5: warning: no previous prototype for 'saa7164_api_dump_subdevs' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-bus.c:109:6: warning: no previous prototype for 'saa7164_bus_dumpmsg' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-bus.c:84:6: warning: no previous prototype for 'saa7164_bus_verify' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-cmd.c:135:5: warning: no previous prototype for 'saa7164_cmd_dequeue' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-cmd.c:189:5: warning: no previous prototype for 'saa7164_cmd_set' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-cmd.c:262:5: warning: no previous prototype for 'saa7164_cmd_wait' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-cmd.c:26:5: warning: no previous prototype for 'saa7164_cmd_alloc_seqno' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-cmd.c:45:6: warning: no previous prototype for 'saa7164_cmd_free_seqno' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-cmd.c:57:6: warning: no previous prototype for 'saa7164_cmd_timeout_seqno' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-cmd.c:67:5: warning: no previous prototype for 'saa7164_cmd_timeout_get' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-encoder.c:1104:29: warning: no previous prototype for 'saa7164_enc_next_buf' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-encoder.c:1290:5: warning: no previous prototype for 'saa7164_g_chip_ident' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-encoder.c:1300:5: warning: no previous prototype for 'saa7164_g_register' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-encoder.c:1313:5: warning: no previous prototype for 'saa7164_s_register' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-fw.c:40:5: warning: no previous prototype for 'saa7164_dl_wait_ack' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-fw.c:56:5: warning: no previous prototype for 'saa7164_dl_wait_clr' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-fw.c:74:5: warning: no previous prototype for 'saa7164_downloadimage' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-vbi.c:1050:29: warning: no previous prototype for 'saa7164_vbi_next_buf' [-Wmissing-prototypes]
      drivers/media/pci/saa7164/saa7164-vbi.c:987:5: warning: no previous prototype for 'saa7164_vbi_fmt' [-Wmissing-prototypes]
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      5faf7db8
    • Mauro Carvalho Chehab's avatar
      [media] mantis: get rid of warning: no previous prototype · 6860f9ca
      Mauro Carvalho Chehab authored
      drivers/media/pci/mantis/mantis_input.c:107:5: warning: no previous prototype for 'mantis_input_init' [-Wmissing-prototypes]
      drivers/media/pci/mantis/mantis_input.c:153:5: warning: no previous prototype for 'mantis_exit' [-Wmissing-prototypes]
      drivers/media/pci/mantis/mantis_uart.c:64:5: warning: no previous prototype for 'mantis_uart_read' [-Wmissing-prototypes]
      drivers/media/pci/mantis/mantis_vp1033.c:118:5: warning: no previous prototype for 'lgtdqcs001f_set_symbol_rate' [-Wmissing-prototypes]
      drivers/media/pci/mantis/mantis_vp1033.c:86:5: warning: no previous prototype for 'lgtdqcs001f_tuner_set' [-Wmissing-prototypes]
      
      Note: there is already a mantis_exit at the mantis driver. So,
      this should be renamed to mantis_input_exit.
      
      The mantis_input code is currently unused, as it doesn't implement the RC API
      right.
      
      Patches for it are sent for discussions, but were never
      accepted. So, while this is not fixed, the entire code inside
      mantis_input can simply be commented.
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      6860f9ca
    • Mauro Carvalho Chehab's avatar
      [media] ivtv-ioctl.c: remove an useless check · d6eb0b99
      Mauro Carvalho Chehab authored
      drivers/media/pci/ivtv/ivtv-ioctl.c: In function 'ivtv_s_input':
      drivers/media/pci/ivtv/ivtv-ioctl.c:996:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
      
      Cc: Andy Walls <awalls@md.metrocast.net>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      d6eb0b99
    • Mauro Carvalho Chehab's avatar
      [media] ivtv: get rid of warning: no previous prototype · 2aebbf67
      Mauro Carvalho Chehab authored
      drivers/media/pci/ivtv/ivtv-alsa-main.c:208:5: warning: no previous prototype for 'ivtv_alsa_load' [-Wmissing-prototypes]
      drivers/media/pci/ivtv/ivtv-alsa-pcm.c:325:5: warning: no previous prototype for 'snd_ivtv_pcm_create' [-Wmissing-prototypes]
      drivers/media/pci/ivtv/ivtv-alsa-pcm.c:72:6: warning: no previous prototype for 'ivtv_alsa_announce_pcm_data' [-Wmissing-prototypes]
      drivers/media/pci/ivtv/ivtv-firmware.c:279:5: warning: no previous prototype for 'ivtv_firmware_restart' [-Wmissing-prototypes]
      drivers/media/pci/ivtv/ivtv-ioctl.c:1171:5: warning: no previous prototype for 'ivtv_s_std' [-Wmissing-prototypes]
      
      Cc: Andy Walls <awalls@md.metrocast.net>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      2aebbf67
    • Mauro Carvalho Chehab's avatar