- 13 Oct, 2010 5 commits
-
-
Nicolas Palix authored
spatch now returns -1 when a virtual rule (given with -D on the command line) is not defined in the semantic patch. Using this spatch feature, coccicheck is now tries several modes by default, in the order: patch, report, context, org Signed-off-by:
Nicolas Palix <npalix.work@gmail.com> Signed-off-by:
Julia Lawall <julia@diku.dk> Signed-off-by:
Michal Marek <mmarek@suse.cz>
-
Nicolas Palix authored
Use new comment format to separate proposed commit message and information about generated false positives Signed-off-by:
-
Nicolas Palix authored
Improve user information with a new kind of comment about semantic patch output. Fix spelling. Signed-off-by:
-
Nicolas Palix authored
- Add information about use of the C={1,2} make flag - Add a description of the new chain mode mechanism - Add a link to the wiki Signed-off-by: -
Nicolas Palix authored
Update my email address Signed-off-by:
-
- 05 Oct, 2010 1 commit
-
-
matt mooney authored
A few modifications done for consistency, such as adding the shell prompt for command line examples and trailing slash for directories. Also corrects the module include header and fixes a few grammar issues that I introduced. Signed-off-by:
matt mooney <mfm@muteddisk.com> Signed-off-by:
-
- 29 Sep, 2010 2 commits
-
-
matt mooney authored
A follow-up to my edit of the first 4 sections. Shift sections down by one due to the deletion of section 3; grammar corrections along with some rewording; margin width cleanup; and change EXTRA_CFLAGS -> ccflags-y. Signed-off-by:
-
matt mooney authored
Omit needless words and sentences; reorganize and tighten sentence structure; swap sections 2.2 and 2.3 for a more logical flow; remove section 3, therefore shifting 4->3; add to explanations; and add section on building multiple modules. Signed-off-by:
-
- 31 Aug, 2010 18 commits
-
-
Nicolas Palix authored
Find confusingly indented code in or after an if. An if branch should be indented. The code following an if should not be indented. Sometimes, code after an if that is indented is actually intended to be part of the if branch. This has a high rate of false positives, because Coccinelle's column calculation does not distinguish between spaces and tabs, so code that is not visually aligned may be considered to be in the same column. Signed-off-by:
Nicolas Palix <npalix@diku.dk> Signed-off-by:
-
Nicolas Palix authored
Find duplicate field initializations. This has a high rate of false positives due to #ifdefs, which Coccinelle is not aware of in a structure initialization. Signed-off-by:
-
Nicolas Palix authored
alloc contains various semantic patches related to the allocation APIs Signed-off-by:
-
Nicolas Palix authored
Signed-off-by:
-
Nicolas Palix authored
Signed-off-by:
-
Nicolas Palix authored
Use kmemdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Signed-off-by:
-
Nicolas Palix authored
Use kmemdup rather than duplicating its implementation Signed-off-by:
-
Nicolas Palix authored
Use kstrdup rather than duplicating its implementation Signed-off-by:
-
Nicolas Palix authored
Find a use after free. Values of variables may imply that some execution paths are not possible, resulting in false positives. Another source of false positives are macros such as SCTP_DBG_OBJCNT_DEC that do not actually evaluate their argument Signed-off-by:
-
Nicolas Palix authored
list_for_each_entry uses its first argument to get from one element of the list to the next, so it is usually not a good idea to reassign it. The first rule finds such a reassignment and the second rule checks that there is a path from the reassignment back to the top of the loop. Signed-off-by:
-
Nicolas Palix authored
Many iterators have the property that the first argument is always bound to a real list element, never NULL. False positives arise for some iterators that do not have this property, or in cases when the loop cursor is reassigned. The latter should only happen when the matched code is on the way to a loop exit (break, goto, or return). Signed-off-by:
-
Nicolas Palix authored
for_each_node iterators only exit normally when the loop cursor is NULL, so there is no point to call of_node_put on the final value. Signed-off-by:
-
Nicolas Palix authored
Find missing unlocks. This semantic match considers the specific case where the unlock is missing from an if branch, and there is a lock before the if and an unlock after the if. False positives are due to cases where the if branch represents a case where the function is supposed to exit with the lock held, or where there is some preceding function call that releases the lock. Signed-off-by:
-
Nicolas Palix authored
Find double locks. False positives may occur when some paths cannot occur at execution, due to the values of variables, and when there is an intervening function call that releases the lock. Signed-off-by:
-
Nicolas Palix authored
Find functions that refer to GFP_KERNEL but are called with locks held. The proposed change of converting the GFP_KERNEL is not necessarily the correct one. It may be desired to unlock the lock, or to not call the function under the lock in the first place. Signed-off-by:
-
Nicolas Palix authored
deref_null.cocci is moved to the 'null' directory which contains other null related rules. Signed-off-by:
-
Nicolas Palix authored
This semantic patch looks for kmalloc etc that are not followed by a NULL check. It only gives a report in the case where there is some error handling code later in the function, which may be helpful in determining what the error handling code for the call to kmalloc etc should be. Signed-off-by:
-
Nicolas Palix authored
The various basic memory allocation functions don't return ERR_PTR Signed-off-by:
-
- 02 Jul, 2010 1 commit
-
-
Martin Ettl authored
during a check of the current git head of the linux kernel with the static code analysis tool cppcheck (http://sourceforge.net/apps/mediawiki/cppcheck/index.php?title=Main_Page) the tool discovered a resource leak in linux-2.6/scripts/dtc/fstree.c. Please refer the attached patch, that fixes the issue. Fixes https://bugzilla.kernel.org/show_bug.cgi?id=15363Signed-off-by:
Martin Ettl <ettl.martin@gmx.de> Cc: David Gibson <david@gibson.dropbear.id.au> Signed-off-by:
-
- 29 Jun, 2010 2 commits
-
-
Kulikov Vasiliy authored
10.04 is Lucid, not Karmic. Signed-off-by:
Kulikov Vasiliy <segooon@gmail.com> Acked-by:
-
Michal Marek authored
The kbuild tree was moved to git.kernel.org so that people can find it more easily. Signed-off-by:
-
- 28 Jun, 2010 1 commit
-
-
Nicolas Palix authored
This patch makes it possible to use the Coccinelle checker with the C variable of the build system. To check only newly edited code, the following command may be used: 'make C={1,2} CHECK="scripts/coccicheck"' This runs every semantic patch in scripts/coccinelle by default. The COCCI variable may additionally be used to only apply a single semantic patch. Signed-off-by:
-
- 11 Jun, 2010 8 commits
-
-
Michal Marek authored
-
Nicolas Palix authored
Add a Coccinelle file to identify the dereferences of NULL variables This semantic patch identifies when a variable is known to be NULL after a test, but it is still dereferenced later. Signed-off-by:
-
Nicolas Palix authored
Add a Coccinelle file to use the ERR_CAST function Before the release 2.6.25, one had to use ERR_PTR(PTR_ERR(...)) to convert the pointer type of an error. Since then, the function ERR_CAST has been available for that purpose. Signed-off-by:
-
Nicolas Palix authored
This semantic patch replaces explicit computations of resource size by a call to resource_size. Signed-off-by:
-
Nicolas Palix authored
This semantic patch replaces a pair of calls to kmalloc and memset by a single call to kzalloc. It only looks for simple cases to avoid false positives. Signed-off-by:
-
Nicolas Palix authored
The purpose of this semantic patch is to remove useless casts, as mentioned in the Linux documentation. See Chapter 14 in Documentation/CodingStyle for more information. Signed-off-by:
-
Nicolas Palix authored
The purpose of this file is to document how to use Coccinelle and its spatch tool to check the Linux kernel. It gives information on where and how to retrieve Coccinelle, and how to use it with the Coccinelle scripts integrated in the Linux kernel. Signed-off-by:
-
Nicolas Palix authored
A 'coccicheck' target is added. It can be called with four different modes. Each one generates a different kind of output, i.e. context, patch, org, report, according to the corresponding mode to be activated. The new target calls the 'coccicheck' front-end in the 'scripts' directory with the MODE argument. Every SmPL file in the subdirectories of 'scripts/coccinelle' is then given to the front-end and applied to the entire source tree. The four modes behave as follows: 'report' generates a list in the following format: file:line:column-column: message 'patch' proposes a fix, when possible. 'context' highlights lines of interest and their context in a diff-like style. Lines of interest are indicated with '-'. 'org' generates a report in the Org mode format of Emacs. Signed-off-by:
Sam Ravnborg <sam@ravnborg.org> Acked-by:
Joerg Roedel <joerg.roedel@amd.com> Signed-off-by:
-
- 04 Jun, 2010 1 commit
-
-
Rabin Vincent authored
Remove bashisms to make scripts/decodecode work with other shells. Signed-off-by:
Rabin Vincent <rabin@rab.in> Reviewed-by:
WANG Cong <xiyou.wangcong@gmail.com> Signed-off-by:
-
- 03 Jun, 2010 1 commit
-
-
Michal Marek authored
os user <gnusercn@gmail.com> writes: From the last comment, arch makefile will override vmlinux. It seems vmlinux will not be checked by `make'. But from my test, although `all:' will be re-defined in arch Makefile (ARM arch), vmlinux will still be checked and the commands associated will be executed. Should we use another word instead of "overridden"? Reported-by:
os user <gnusercn@gmail.com> Signed-off-by:
-
