- 24 Sep, 2014 40 commits
-
-
Dan Carpenter authored
This is untrusted user data from vmci_host_do_send_datagram() so the VMCI_DG_SIZE() macro can have an integer overflow. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Federico Vaga authored
In some condition we receive the break interrupt but nothing is putted in the Rx FIFO and the correspondend bit in the status register is not set. Thus, no-one clear the interrupt and the handler will be called forever. This patch clear the break interrupt as soon as it occurs. Then, if the break character '\0' is putted in the fifo we will manage it. We can also unmask the Break interrupt but its bit in ISR is still set on break. So I think is better to keep the registers clean. Signed-off-by:
Federico Vaga <federico.vaga@cern.ch> Acked-by:
Samuel Iglesias Gonsalvez <siglesias@igalia.com> Signed-off-by:
-
Frank Haverkamp authored
When the GenWQE hardware queue was busy, the driver returned simply -EBUSY. This caused polling by applications which increased the load on the already busy system. This change implements the possiblity to sleep on a waitqueue instead when the DDCB queue is busy. The requestor is woken up when there is free space on the queue again. The old way to get -EBUSY is still available if the device is openend with O_NONBLOCKING. The default is now blocking behavior. Signed-off-by:
Frank Haverkamp <haver@linux.vnet.ibm.com> Signed-off-by:
-
Eberhard S. Amann authored
This patch fixes a problem we found during debug on PPC64 when reading HSI status and Retc. Signed-off-by:
Eberhard S. Amann <esa@linux.vnet.ibm.com> Signed-off-by:
-
Frank Haverkamp authored
The checkpatch.pl script got improved. I ran it on the latest GenWQE sources and fixed what it complained about. Signed-off-by:
-
Frank Haverkamp authored
Forgetting to check this, can lead to problems on systems which do not support SRIOV. Signed-off-by:
-
Frank Haverkamp authored
Follow up patch to the one from Sebastian Ott. There is no need to change the return code once it fails. And Sebastians version is tested now and works nicely on our test-system. Signed-off-by:
-
Frank Haverkamp authored
Updated email address of co-author. Signed-off-by:
Michael Jung <mijung@gmx.net> Signed-off-by:
-
Frank Haverkamp authored
A special sysfs entry to display the driver version is not needed. We left the driver version and adjusted it to the naming a lot of other drivers use. The information can be retrieved by using modinfo genwqe_card. modinfo genwqe_card will provide the same information. Signed-off-by:
-
Frank Haverkamp authored
Currently the driver is using the pci_get_totalvfs() return code directly in a loop. To avoid problems with potentially negative returns in case of errors, we are adding some more sanity checking code. Signed-off-by:
-
Lee Jones authored
Calling strncpy with a maximum size argument of 32 bytes on destination array kim_gdata->dev_name of size 32 bytes might leave the destination string unterminated. Signed-off-by:
Lee Jones <lee.jones@linaro.org> Signed-off-by:
-
Lee Jones authored
Coverity reported: This less-than-zero comparison of an unsigned value is never true. In answer to that, we only ever decrement if protos_registered is positive. We can subsequently remove the paranoid checking during unregister. Signed-off-by:
-
Matwey V. Kornilov authored
We definitely know that only x86 (32-bit) architecture is affected by the issue, so implement a stub instead of the actual check for other architectures. We also know that motherboard LPT chipset is affected, so the port is either come from parport_pc_init (when `io' module param is used) or parport_pc_find_isa_ports (when default LPT ports are probbed: 0x378, 0x278, 0x3bc). In both cases the port considered as 'legacy' and `dev' member of struct parport is NULL. See also comments for `struct parport' in parport.h Signed-off-by:
Matwey V. Kornilov <matwey@sai.msu.ru> Signed-off-by:
-
Matwey V. Kornilov authored
Put the code to check present of the Intel bug from parport_EPP_supported into new intel_bug_present function. The later also return ECR register to the state it has before function call. Signed-off-by:
-
Federico Vaga authored
Signed-off-by:
-
Federico Vaga authored
There was not any kind of protection against carrier driver removal. In this way, device driver can 'get' the carrier driver when it is using it. Signed-off-by:
-
Federico Vaga authored
Signed-off-by:
-
Rasmus Villemoes authored
Signed-off-by:
Rasmus Villemoes <linux@rasmusvillemoes.dk> Acked-by:
-
Eli Billauer authored
Signed-off-by:
Eli Billauer <eli.billauer@gmail.com> Signed-off-by:
-
Michal Simek authored
There is no need to init .owner field. Based on the patch from Peter Griffin <peter.griffin@linaro.org> "mmc: remove .owner field for drivers using module_platform_driver" This patch removes the superflous .owner field for drivers which use the module_platform_driver API, as this is overriden in platform_driver_register anyway." Signed-off-by:
Michal Simek <michal.simek@xilinx.com> Signed-off-by:
-
Himangi Saraogi authored
The various devm_ functions allocate memory that is released when a driver detaches. This patch uses these functions for data that is allocated in the probe function of a platform device and is only freed in the remove function. Also, the unnecessary labels are removed and linux/device.h is added to make sure the devm_*() routine declarations are unambiguously available. The initial call to platform_get_resource is moved down to the introduced call to devm_ioremap_resource that uses its result. Signed-off-by:
Himangi Saraogi <himangi774@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
-
Takashi Iwai authored
Signed-off-by:
Takashi Iwai <tiwai@suse.de> Tested-by:
Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com> Signed-off-by:
-
Himangi Saraogi authored
This patch introduces the use of devm_kzalloc and does away with the kfrees in the probe and remove functions. Also, a label and the err variable are removed. The header device.h is included to make the devm_ function explicitly available and slab.h is done away with as it is no longer needed. Signed-off-by:
Jean Delvare <jdelvare@suse.de> Signed-off-by:
-
Alexander Usyskin authored
function 'strncpy' will fill whole buffer 'id.name' of fixed size (32) with string value and will not leave place for NULL-terminator. Possible buffer boundaries violation in following string operations. Replace strncpy with strlcpy. Cc: stable@vger.kernel.org # 3.10+ Signed-off-by:
Alexander Usyskin <alexander.usyskin@intel.com> Signed-off-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Tomas Winkler authored
There is no need for dynamic allocation for connect_data. We can use variable on the stack and make code less error prone and simple Signed-off-by:
-
Tomas Winkler authored
Handle ioctls in a switch statement so we can add more commands easily Signed-off-by:
-
Tomas Winkler authored
extract supported hbm features and commands from the hbm version Signed-off-by:
-
Tomas Winkler authored
Add mei_hbm_cl_find_by_cmd handler to retrieve the destination client Signed-off-by:
-
Alexander Usyskin authored
We cannot handle user interrupt in context of hbm start so we only wait for time out which is reasonably short. 1. Add kdoc 2. Rename state to better reflect its function 3. Simplify wait condition and rename wait_recvd_msg to wait_hbm_start Signed-off-by:
-
Tomas Winkler authored
Both responses have same flow only the client status update is different. We introduce handler mei_hbm_cl_res() that handles both responses Also we use per client wait queue (cl->wait) rather then global dev->wait_recvd_msg Signed-off-by:
-
Tomas Winkler authored
Rename mei_cl_irq_close to mei_cl_irq_disconnect and MEI_FOP_CLOSE to MEI_FOP_DISCONNECT Remove unused MEI_FOP_OPEN Signed-off-by:
-
Tomas Winkler authored
HBM uses global list of status values from which the values of particular commands are derived Signed-off-by:
-
Tomas Winkler authored
When handling dynamic clients there might be a race scenario in which two me clients with the same me address would be linked in the me clients list, therefore we need to search by both uuid and me address. Signed-off-by:
-
Tomas Winkler authored
To support dynamic addition/remove we add wrappers for removal of me clients Signed-off-by:
-
Tomas Winkler authored
To support dynamic addition/remove of clients it is more convenient to use list instead of static array Signed-off-by:
-
Tomas Winkler authored
For support of dynamic addition and removal of me clients it is more convenient to use a list instead of static array as is use now. As the first step of the transition to the new data structure we change the lookup function so it returns me client address instead of an index. Signed-off-by:
-
Tomas Winkler authored
Reduce few code lines by using wrappers for sending simple hbm client messages Signed-off-by:
-
Tomas Winkler authored
Use consistently me_addr name in hbm protocol structures to represent in firmware client address Signed-off-by:
-
Alexander Usyskin authored
Amthif has its own queues therefore it is redundant to check the client type when processing the queues Signed-off-by:
-
Alexander Usyskin authored
Replace open coded loop with an existing service function: mei_io_list_flush Signed-off-by:
-
