- 14 Feb, 2014 40 commits
-
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input pipe full, scanning, amd end-of-conversion status. The status to check it passed as the 'context' to comedi_timeout(). Use comedi_timeout() to wait for the analog output end-of-conversion. This also fixes a possible bug where invalid data is returned for the analog input read if the conversion did not complete, The analog output has a similar possible bug where the cached readback value is incorrect if the conversion times out. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
The wait_for() macro in this driver is a bit nasty. It effects control flow which according to the CodingStyle is a _very_ bad idea. The mux_busy() and ad_done() macros are also bad since they rely on a local variable having a specific name. Remove these macros and use comedi_timeout() to wait for the analog input mux busy completion and end-of-conversion. Both of these are detected by reading the same register and testing different bits. Pass the bits to test as the 'context' to the callback function. The dt282x_ai_cmd() function also checks for the mux busy completion. The 'insn' is not available here but passing NULL is safe because nothing uses it. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. This prevents a deadlock condition that could occur by providing a timeout in case the end-of-conversion does not happen. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversions. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversion. Use break to exit the loop when a timeout occurs during the analog input read so that common code can be used to disable the device. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Also, remove some unnecessary comments. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. This also fixes a possible bug where invalid data is returned if the conversion did not complete. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Change the errno returned when the conversion overflows from -ETIME to -EOVERFLOW. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversions. This prevents a deadlock condition that could occur by providing a timeout in case the end-of-conversion does not happen. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Remove the unnecessary comments. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Change the errno returned for an overrun from -EIO to -EOVERFLOW. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog output end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input and output end-of- conversions. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog output end-of-conversion. Signed-off-by:
-
H Hartley Sweeten authored
Use comedi_timeout() to wait for the analog input end-of-conversion. Since this is the sample skeleton driver, add comments about how the callback function works with comedi_timeout(). Signed-off-by:
-
H Hartley Sweeten authored
Introduce a comedi core helper function to handle the boilerplate needed by the drivers to busy- wait for a condition to occur. Typically this condition is the analog input/output end-of-conversion used with the comedi (*insn_read) and (*insn_write) operations. To use this function, the drivers just need to provide a callback that checks for the desired condition. The callback should return 0 if the condition is met or -EBUSY if it is still waiting. Any other errno will be returned to the caller. If the timeout occurs before the condition is met -ETIMEDOUT will be returned. The parameters to the callback function are the comedi_device, comedi_subdevice, and comedi_insn pointers that were passed to the (*insn_read) or (*insn_write) as well as an unsigned long, driver specific, 'context' that can be used to pass any other information that might be needed in the callback. This 'context' could be anything such as the register offset to read the status or the bits needed to check the status. The comedi_timeout() function itself does not use any of these parameters. This will help remove all the crazy "wait this many loops" used by some of the drivers. It also creates a common errno for comedi to detect when a timeout occurs. ADC/DAC conversion times are typically pretty fast, usually around 100K samples/sec (10 usec). A conservative timeout of 1 second is used in comedi_timeout(). Signed-off-by:
-
