- 29 Nov, 2011 26 commits
-
-
Andreas Ruprecht authored
The code in sca3000_store_measurement_mode() uses the variable val to do bitwise operations with an int mask and or-s it into st->rx[0] which is an entry in a u8 array (see sca3000.h). This means up to now values larger than a u8 were silently ignored and just the lower 8 bits counted into the value that was written into st->rx[0]. This code will return -ERANGE if the value in buf was too large to fit into a u8. Signed-off-by:
Andreas Ruprecht <rupran@einserver.de> Signed-off-by:
Greg Kroah-Hartman <gregkh@suse.de>
-
Andreas Ruprecht authored
In lis3102dq_write_frequency() we used a long variable to store the value parsed from the char* buffer buf, as there only was a strict_strtol() function to parse values. Now we have got kstrto* which allows us to convert to the right data type in most cases. In this particular function we want to write a frequency value, and it doesn't make sense to allow negative values here (as Dan Carpenter pointed out in a previous email). This means we can now parse the value into an unsigned long and get an error for invalid (e.g. negative) values. Signed-off-by:
-
Andreas Ruprecht authored
In the adis16220_write_16bit() function we used a long value to store parsed data from the char* buffer buf. The called function to actually write the data, adis16220_spi_write_reg_16(), takes a u16 value as a parameter, so up to now a value larger than u16 was silently ignored as it was only truncated when passing the parameter. Now this function will only accept values fitting into a u16. Additionally the parsing function was changed to overcome the now obsolete strict_strtol() function. Signed-off-by:
-
Kevin McKinney authored
This patch reorders the semaphore locking. It makes better sense to first evaluate fw_download_sema semaphore then NVMRdmWrmLocl semaphore. The fw_download_sema is suppose to be acquired in the START ioctl. If this is not true, then it does not make sense to continue. Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Signed-off-by:
-
Kevin McKinney authored
This is a cleanup patch. I've shuffled the code around to move the error handling closer to the calls. I've removed some indent levels. I've replaced break statements with direct returns. Signed-off-by:
-
Kevin McKinney authored
This patch evaluates/calls the down_trylock locking function directly, instead of storing the results in a variable and evaluating the variable. These changes were made in: IOCTL_BCM_BUFFER_DOWNLOAD_STOP and IOCTL_BCM_BUFFER_DOWNLOAD_START. Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Implement the LTTng probe callbacks. One notable file here is lttng-events.h, which is the core implementation of the LTTng TRACE_EVENT macros for generation of probes and tracepoint decription from the TRACE_EVENT declarations. Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Add the "lttng" virtual file to debugfs and procfs. All operations are performed through ioctls (LTTng ioctl range is already reserved upstream) on this virtual file and on anonymous file descriptors returned by these ioctls. Each file descriptor is associated with a tracer "object" (session, channel, stream, event, context). Signed-off-by:
-
Mathieu Desnoyers authored
This calibration feature is fairly limited for now, but provides an example of how this can be performed. Signed-off-by:
-
Mathieu Desnoyers authored
Events can be augmented with context information. This is dynamically configurable from the command line. Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Each lttng buffer configuration (discard mode, overwrite mode, mmap support, splice support, per-cpu buffers, global buffer for metadata) is a lib ring buffer client. Signed-off-by:
-
Mathieu Desnoyers authored
x86-32 and x86-64 system call instrumentation, along with the lttng-syscalls-generate-headers.sh script that generates the headers from the system call list. See README for details. Signed-off-by:
-
Mathieu Desnoyers authored
Modifications to the in-kernel TRACE_EVENT are needed to generate the compact event descriptions and the probe code LTTng generates. These changes could apply to upstream TRACE_EVENT, but requires changing the in-kernel API. Signed-off-by:
-
Mathieu Desnoyers authored
Implement wrappers for compatibility with older kernel versions and kernels with had the libringbuffer (old) patchset applied. Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
Mathieu Desnoyers authored
Signed-off-by:
-
- 27 Nov, 2011 14 commits
-
-
Tomas Winkler authored
1. No need to check if a list is empty before list_for_each_ looping as this is already checked by loop stopping conditional. The side effect is reduced indentation depth from: if (!list_empty) list_for_each() to: list_for_each() 2. drop cb_ prefix from cl_pos, cl_next variables used in list_for_each loops. The code is more compact and readable Signed-off-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Tomas Winkler authored
status was never writen Signed-off-by:
-
Tomas Winkler authored
We can remove BUG_ON in mei_irq_thread_read_client_message() as the testing for response buffer size overflow has already graceful handling in place. Signed-off-by:
-
Aaro Koskinen authored
Eliminate the only remaining checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks #7463: FILE: staging/xgifb/vb_setmode.c:7463: + if (ModeNo & 0x80) { + ModeNo = ModeNo & 0x7F; + } total: 0 errors, 1 warnings, 0 checks, 7554 lines checked Signed-off-by:Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by:
-
Aaro Koskinen authored
Eliminate unnecessary nesting levels by rearranging code and conditions. The resulting code should be still identical. Signed-off-by:
-
Aaro Koskinen authored
Eliminate unnecessary nesting levels by rearranging code and conditions. The resulting code should be still identical. Signed-off-by:
-
Aaro Koskinen authored
Delete empty if statement blocks. The patch eliminates following checkpatch.pl warnings: WARNING: suspect code indent for conditional statements (8, 8) Signed-off-by:
-
Aaro Koskinen authored
XGI_VBLongWait() is NOP, so just delete it. Signed-off-by:
-
Aaro Koskinen authored
Delete commented-out code. Signed-off-by:
-
Aaro Koskinen authored
Inline a trivial function. Signed-off-by:
-
Aaro Koskinen authored
Eliminate unneeded function and struct field. The same information is available in HwDeviceExtension->jChipType. Signed-off-by:
-
Aaro Koskinen authored
Make internal functions static. Signed-off-by:
-
Aaro Koskinen authored
XGI_GetLVDSOEMTableIndex() can be made static. Move the function, so that forward declaration is not needed. Signed-off-by:
-
Aaro Koskinen authored
XGI_XG21SetPanelDelay() can be made static. Move the function, so that forward declaration is not needed. Signed-off-by:
-
