- 08 Dec, 2017 2 commits
-
-
Bart Van Assche authored
If scsi_eh_scmd_add() is called concurrently with scsi_host_queue_ready() while shost->host_blocked > 0 then it can happen that neither function wakes up the SCSI error handler. Fix this by making every function that decreases the host_busy counter wake up the error handler if necessary and by protecting the host_failed checks with the SCSI host lock. Reported-by:
Pavel Tikhomirov <ptikhomirov@virtuozzo.com> References: https://marc.info/?l=linux-kernel&m=150461610630736 Fixes: commit 74665016 ("scsi: convert host_busy to atomic_t") Signed-off-by:
Bart Van Assche <bart.vanassche@wdc.com> Reviewed-by:
Stuart Hayes <stuart.w.hayes@gmail.com> Cc: Konstantin Khorenko <khorenko@virtuozzo.com> Cc: Stuart Hayes <stuart.w.hayes@gmail.com> Cc: Pavel Tikhomirov <ptikhomirov@virtuozzo.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Hannes Reinecke <hare@suse.com> Cc: Johannes Thumshirn <jthumshirn@suse.de> Cc: <stable@vger.kernel.org> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
-
Paul E. McKenney authored
Use of init_rcu_head() and destroy_rcu_head() from modules results in the following build-time error with CONFIG_DEBUG_OBJECTS_RCU_HEAD=y: ERROR: "init_rcu_head" [drivers/scsi/scsi_mod.ko] undefined! ERROR: "destroy_rcu_head" [drivers/scsi/scsi_mod.ko] undefined! This commit therefore adds EXPORT_SYMBOL_GPL() for each to allow them to be used by GPL-licensed kernel modules. Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:
-
- 07 Dec, 2017 18 commits
-
-
Ching Huang authored
Fix report command result error when CHECK_CONDITION. Signed-off-by:
Ching Huang <ching2048@areca.com.tw> Signed-off-by:
-
Ching Huang authored
Update driver version to v1.40.00.04-20171130 Signed-off-by:
-
Ching Huang authored
Add module parameter msix_enable so user has the option of disabling MSI-X interrupts if there is a platform problem. Signed-off-by:
-
Ching Huang authored
Add module parameter msi_enable so user has the option of disabling MSI interrupts if there is a platform problem. Signed-off-by:
-
Ching Huang authored
Fix grammar. Signed-off-by:
-
Ching Huang authored
Adjust tabs and whitespace. Signed-off-by:
-
Ching Huang authored
Spin off duplicate code of timer init for message isr BH in arcmsr_probe and arcmsr_resume as a function arcmsr_init_get_devmap_timer. Signed-off-by:
-
Ching Huang authored
Fix clear doorbell queue on ACB_ADAPTER_TYPE_B controller. Signed-off-by:
-
Ching Huang authored
Add a function arcmsr_set_iop_datetime and driver option set_date_time to set date and time to firmware. Signed-off-by:
-
Ching Huang authored
Add ACB_F_MSG_GET_CONFIG to acb->acb_flags for for message interrupt checking before schedule work for get device map. Signed-off-by:
-
Ching Huang authored
Add driver option cmd_per_lun to set host->cmd_per_lun value by user. Signed-off-by:
-
Ching Huang authored
Replace constant ARCMSR_MAX_OUTSTANDING_CMD by variable acb->maxOutstanding that was determined by user. Signed-off-by:
-
Ching Huang authored
Add driver option host_can_queue to set host->can_queue value by user. It's value expands up to 1024. Signed-off-by:
-
Ching Huang authored
Replace constant ARCMSR_MAX_FREECCB_NUM by variable acb->maxFreeCCB that was received from firmware. Signed-off-by:
-
Ching Huang authored
Update ARCMSR_MAX_OUTSTANDING_CMD and ARCMSR_MAX_FREECCB_NUM to 1024. Signed-off-by:
-
Ching Huang authored
Add code for ACB_ADAPTER_TYPE_E to support new adapter ARC-1884. Signed-off-by:
-
Ching Huang authored
Simplify arcmsr_iop_init function. Signed-off-by:
-
Ching Huang authored
Redefine ACB_ADAPTER_TYPE_A, _B, _C, _D and subsequent changes. Signed-off-by:
-
- 05 Dec, 2017 20 commits
-
-
Bryant G. Ly authored
Where applicable, changes pr_debug, pr_info, pr_err, etc. calls to the dev_* versions. This adds the DRC index of the device to the corresponding trace statement. Signed-off-by:
Bryant G. Ly <bryantly@linux.vnet.ibm.com> Signed-off-by:
Brad Warrum <bwarrum@us.ibm.com> Signed-off-by:
-
Colin Ian King authored
Remove one extraneous level of indentation on an assignment statement. Signed-off-by:
Colin Ian King <colin.king@canonical.com> Acked-by:
Brian King <brking@linux.vnet.ibm.com> Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistake in error message text. Signed-off-by:
-
Colin Ian King authored
Trivial fix to spelling mistake in error message text. Signed-off-by:
-
Michał Mirosław authored
KERN_CONT is now required for continued printks(). Add it. Signed-off-by:
Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by:
-
kwmad.kim@samsung.com authored
These would be used in the future in some specific drivers. Signed-off-by:
Kiwoong Kim <kwmad.kim@samsung.com> Signed-off-by:
-
Suganath Prabu S authored
No Functional change just cleanup. Removed variable requeue_event and made function as void. Signed-off-by:
Suganath Prabu S <suganath-prabu.subramani@broadcom.com> Signed-off-by:
-
Romain Perier authored
The PCI pool API is deprecated. This commit replaces the PCI pool old API by the appropriate function with the DMA pool API. Signed-off-by:
Romain Perier <romain.perier@gmail.com> Signed-off-by:
-
Vasyl Gomonovych authored
Remove the duplicate copies of this simple function and use an open-coded version. drivers/scsi/fnic/fnic_debugfs.c:122:11-31: WARNING opportunity for simple_open, see also structure on line 223 Generated by: coccinelle/api/simple_open.cocci Signed-off-by:
Vasyl Gomonovych <gomonovych@gmail.com> Signed-off-by:
-
Li Dongyang authored
We are testing if there is a match with the ses device in a loop by calling ses_match_to_enclosure(), which will issue scsi receive diagnostics commands to the ses device for every device on the same host. On one of our boxes with 840 disks, it takes a long time to load the driver: [root@g1b-oss06 ~]# time modprobe ses real 40m48.247s user 0m0.001s sys 0m0.196s With the patch: [root@g1b-oss06 ~]# time modprobe ses real 0m17.915s user 0m0.008s sys 0m0.053s Note that we still need to refresh page 10 when we see a new disk to create the link. Signed-off-by:
Li Dongyang <dongyang.li@anu.edu.au> Tested-by:
Jason Ozolins <jason.ozolins@hpe.com> Signed-off-by:
-
Colin Ian King authored
Don't populate the read-only array card_types on the stack but instead make it static and constify it. Makes the object code smaller by over 110 bytes: Before: text data bss dec hex filename 25625 5752 0 31377 7a91 drivers/scsi/wd719x.o After: text data bss dec hex filename 25447 5816 0 31263 7a1f drivers/scsi/wd719x.o (gcc version 7.2.0 x86_64) Signed-off-by:
-
Arnd Bergmann authored
There is no need to go through an intermediate timespec to convert to ktime_t when we just want a simple multiplication. This gets rid of one of the few users of jiffies_to_timespec, which I hope to remove as part of the y2038 cleanup. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Reviewed-by:
Johannes Thumshirn <jthumshirn@suse.de> Acked-by:
Douglas Gilbert <dgilbert@interlog.com> Signed-off-by:
-
Dan Carpenter authored
device->scsi3addr[] is an array, not a pointer, so it can't be NULL. I've removed the check. [mkp: fixed typo] Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Acked-by:
Don Brace <don.brace@microsemi.com> Signed-off-by:
-
James Smart authored
Update the driver version to 11.4.0.5 Signed-off-by:
Dick Kennedy <dick.kennedy@broadcom.com> Signed-off-by:
James Smart <james.smart@broadcom.com> Reviewed-by:
Hannes Reinecke <hare@suse.com> Signed-off-by:
-
James Smart authored
The logic for sg_seg_cnt is a bit convoluted. This patch tries to clean up a couple of areas, especially around the +2 and +1 logic. This patch: - Cleans up the lpfc_sg_seg_cnt attribute to specify a real minimum rather than making the minimum be whatever the default is. - Removes the hardcoding of +2 (for the number of elements we use in a sgl for cmd iu and rsp iu) and +1 (an additional entry to compensate for nvme's reduction of io size based on a possible partial page) logic in sg list initialization. In the case where the +1 logic is referenced in host and target io checks, use the values set in the transport template as that value was properly set. There can certainly be more done in this area and it will be addressed in combined host/target driver effort. Signed-off-by:
-
James Smart authored
During driver unload, the driver may crash due to NULL pointers. The NULL pointers were due to the driver not protecting itself sufficiently during some of the teardown paths. Additionally, the driver was not waiting for and cleanup up nvme io resources. As such, the driver wasn't making the callbacks to the transport, stalling the transports association teardown. This patch waits for io clean up before tearding down and adds checks for possible NULL pointers. Cc: <stable@vger.kernel.org> # 4.12+ Signed-off-by:
-
James Smart authored
When the driver is unloading, the nvme transport could be in the process of submitting new requests, will send abort requests to terminate associations, or may make LS-related requests. The driver's abort and request entry points currently is ignorant of the unloading state and is starting the requests even though the infrastructure to complete them continues to teardown. Change the entry points for new requests to check whether unloading and if so, reject the requests. Abort routines check unloading, and if so, noop the request. An abort is noop'd as the teardown paths are already aborting/terminating the io outstanding at the time the teardown initiated. Signed-off-by:
-
James Smart authored
The driver's interaction with the host nvme transport has been incorrect for a while. The driver did not wait for the unregister callbacks (waited only 5 jiffies). Thus the driver may remove objects that may be referenced by subsequent abort commands from the transport, and the actual unregister callback was effectively a noop. This was especially problematic if the driver was unloaded. The driver now waits for the unregister callbacks, as it should, before continuing with teardown. Signed-off-by:
-
James Smart authored
The driver currently registers any remote port that has NVME support. It should only be registering target ports. Register only target ports. Signed-off-by:
-
James Smart authored
During RSCN storms, the driver does not rediscover some targets. The driver marks some RSCN as to be handled after the ones it's working on. The driver missed processing some deferred RSCN. Move where the driver checks for deferred RSCNs and initiate deferred RSCN handling if the flag was set. Also revise nport state within the RSCN confirm routine. Add some state data to a possible debug print to aid future debugging. Signed-off-by:
-
