1. 27 May, 2016 32 commits
  2. 26 May, 2016 4 commits
  3. 24 May, 2016 1 commit
    • Eli Sennesh's avatar
      greybus: update UniPro Set Interface Power Mode operation to match spec · 00606367
      Eli Sennesh authored
      Bring the gb_svc_intf_set_power_mode() up-to-date with the current Greybus
      specification.  This largely involves adding more members to the structure
      sent across the wire.  Also change the camera code to use the new
      operation properly, with default values passed for the new necessary
      arguments.  The correctness of these default values is confirmed via testing
      and by asking Rob Johnson.
      
      Testing Done: Took a picture with a camera module, received error code
      when passing deliberately incorrect values for new parameters, got proper
      -EIO and Greybus result code printed when operation stopped halfway
      through.
      
      Associated Firmware Changes: 6810-6812 on Gerrit for SW-1239, 6870 and
      5612-5613 on Gerrit for SW-2945
      Signed-off-by: default avatarEli Sennesh <esennesh@leaflabs.com>
      Reviewed-by: default avatarAlex Elder <elder@linaro.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
      00606367
  4. 23 May, 2016 2 commits
    • Bryan O'Donoghue's avatar
      greybus: Fix unbalanced irq_enable() backtrace · d7be800f
      Bryan O'Donoghue authored
      Tip-of-tree is exhibiting a backtrace when loading-up the set of greybus
      kernel modules due to calling arche_platform_wd_irq_en() directly after a
      call to devm_request_threaded_irq().
      
      At the point we call arch_platform_wd_irq_en() the relevant IRQ will
      already be enabled. What we want to do in this situation is configure the
      GPIO line as an input. This patch fixes the backtrace by supplanting
      arche_platform_wd_irq_en() with
      gpio_direction_input(arche_pdata->wake_detect_gpio) in
      arche_platform_probe().
      
      WARNING: at msm-ara-3.10/kernel/irq/manage.c:457 __enable_irq+0x74/0xc0()
      Unbalanced enable for IRQ 687
      Modules linked in: gb_arche(O+) gb_camera(O) gb_es2(O) gb_vibrator(O)
      gb_raw(O) gb_power_supply(O) gb_loopback(O) gb_light(O) gb_hid(O)
      greybus(O)
      CPU: 0 PID: 415 Comm: insmod Tainted: G        W  O 3.10.78-g2a4dec8 #65
      Call trace:
      [<ffffffc000206adc>] dump_backtrace+0x0/0x248
      [<ffffffc000206d34>] show_stack+0x10/0x1c
      [<ffffffc000c6c698>] dump_stack+0x1c/0x28
      [<ffffffc00021c95c>] warn_slowpath_common+0x74/0x9c
      [<ffffffc00021c9d0>] warn_slowpath_fmt+0x4c/0x58
      [<ffffffc000269d7c>] __enable_irq+0x70/0xc0
      [<ffffffc000269e34>] enable_irq+0x68/0x7c
      [<ffffffbffc0609b4>] arche_platform_probe+0x3b4/0x4f4 [gb_arche]
      [<ffffffc0005ace30>] platform_drv_probe+0x14/0x20
      [<ffffffc0005ab980>] driver_probe_device+0x160/0x374
      [<ffffffc0005abc40>] __driver_attach+0x60/0x90
      [<ffffffc0005aa768>] bus_for_each_dev+0x74/0x94
      [<ffffffc0005ab2c4>] driver_attach+0x1c/0x28
      [<ffffffc0005aae74>] bus_add_driver+0x124/0x248
      [<ffffffc0005ac270>] driver_register+0x94/0x110
      [<ffffffc0005ad3c4>] platform_driver_register+0x58/0x64
      [<ffffffbffc065020>] $x+0x20/0x58 [gb_arche]
      [<ffffffc0002007dc>] do_one_initcall+0xb0/0x14c
      [<ffffffc00028252c>] load_module+0x19d0/0x1b18
      [<ffffffc00028278c>] SyS_init_module+0x118/0x130
      Signed-off-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
      Reviewed-by: default avatarVaibhav Hiremath <vaibhav.hiermath@linaro.org>
      Tested-by: default avatarRui Miguel Silva <rui.silva@linaro.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
      d7be800f
    • Vaibhav Agarwal's avatar
      greybus: audio: Fix memory leak · 37f07c0c
      Vaibhav Agarwal authored
      Topology data pointer was mistakenly set to NULL before freeing it. Fix
      this.
      
      Fixes: 64a86d9ba850 ("audio: Add module specific driver")
      Signed-off-by: default avatarVaibhav Agarwal <vaibhav.agarwal@linaro.org>
      Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
      Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
      37f07c0c
  5. 21 May, 2016 1 commit