- 29 Apr, 2018 5 commits
-
-
Kirill Marinushkin authored
In the current implementation, vchi_instance is inited during the first call of bcm2835_audio_open_connection(), and is never freed. It causes a memory leak when the module `snd_bcm2835` is removed. Here is how this commit fixes it: * the VCHI context (including vchi_instance) is created once in the platform's devres * the VCHI context is allocated and connected once during module_init() * all created bcm2835_chips have a pointer to this VCHI context * bcm2835_audio_open_connection() can access the VCHI context through the associated bcm2835_chip * the VCHI context is disconnected and freed once during module_exit() After this commit is applied, I don't see other issues with the module's init/exit, so I also remove the associated TODO task. Steps to reproduce the memory leak before this commit: ~~~~ root@raspberrypi:/home/pi# aplay test0.wav Playing WAVE 'test0.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Ster ^CAborted by signal Interrupt... root@raspberrypi:/home/pi# rmmod snd_bcm2835 root@raspberrypi:/home/pi# modprobe snd_bcm2835 root@raspberrypi:/home/pi# aplay test0.wav Playing WAVE 'test0.wav' : Signed 16 bit Little Endian, Rate 44100 Hz, Ster ^CAborted by signal Interrupt... root@raspberrypi:/home/pi# echo scan > /sys/kernel/debug/kmemleak root@raspberrypi:/home/pi# cat /sys/kernel/debug/kmemleak unreferenced object 0xb6794c00 (size 128): comm "aplay", pid 406, jiffies 36870 (age 116.650s) hex dump (first 32 bytes): 08 a5 82 81 01 00 00 00 08 4c 79 b6 08 4c 79 b6 .........Ly..Ly. 00 00 00 00 00 00 00 00 ad 4e ad de ff ff ff ff .........N...... backtrace: [<802af5e0>] kmem_cache_alloc_trace+0x294/0x3d0 [<806ce620>] vchiq_initialise+0x98/0x1b0 [<806d0b34>] vchi_initialise+0x24/0x34 [<7f1311ec>] 0x7f1311ec [<7f1303bc>] 0x7f1303bc [<7f130590>] 0x7f130590 [<7f111fd8>] snd_pcm_open_substream+0x68/0xc4 [snd_pcm] [<7f112108>] snd_pcm_open+0xd4/0x248 [snd_pcm] [<7f112334>] snd_pcm_playback_open+0x4c/0x6c [snd_pcm] [<7f0e250c>] snd_open+0xa8/0x14c [snd] [<802ce590>] chrdev_open+0xac/0x188 [<802c57b4>] do_dentry_open+0x10c/0x314 [<802c6ba8>] vfs_open+0x5c/0x88 [<802d9a68>] path_openat+0x368/0x944 [<802dacd4>] do_filp_open+0x70/0xc4 [<802c6f70>] do_sys_open+0x110/0x1d4 ~~~~ Signed-off-by:Kirill Marinushkin <k.marinushkin@gmail.com> Cc: Eric Anholt <eric@anholt.net> Cc: Stefan Wahren <stefan.wahren@i2se.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: Ray Jui <rjui@broadcom.com> Cc: Scott Branden <sbranden@broadcom.com> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: linux-rpi-kernel@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: devel@driverdev.osuosl.org Cc: linux-kernel@vger.kernel.org Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Dan Carpenter authored
First of all devm_memremap() function returns an error pointer, it doesn't return NULL. And second we need to set the error code on these paths. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Yangbo Lu authored
This patch is to support phc_index of ethtool_ts_info. Also make the rtc drvier depend on FSL_DPAA2_ETH because this driver is only useful when PTP programs are getting hardware time stamps on the PTP Ethernet packets using the SO_TIMESTAMPING API. Signed-off-by:
Yangbo Lu <yangbo.lu@nxp.com> Signed-off-by:
-
Yangbo Lu authored
Since hardware timestmaping has been supported in driver, this patch is to add the get_ts_info interface for ethtool to show timestamping capability. Signed-off-by:
-
Ioana Radulescu authored
Hardware timestamping is supported both on Rx and Tx paths. On Rx, timestamping is enabled for all frames. On Tx, we only instruct the hardware to timestamp the frames marked accordingly by the stack. Signed-off-by:
Ioana Radulescu <ruxandra.radulescu@nxp.com> Signed-off-by:
-
- 26 Apr, 2018 35 commits
-
-
Ajay Singh authored
Reorder the functions in linux_wlan.c file to avoid having explicit declaration of static functions. Forward declaration is avoided with the help of reordering the function. Signed-off-by:
Ajay Singh <ajay.kathat@microchip.com> Signed-off-by:
-
Ajay Singh authored
Defined function as static which are used only in single file. And also removed their declaration from header file. Below function are changed to static wilc_wlan_initialize() wilc_wlan_deinitialize() wilc_wlan_get_firmware() Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove unnecessary inner block {\* *\} in handle_remain_on_chan(). Signed-off-by: -
Ajay Singh authored
Rename P2P_LISTEN_STATE variable to avoid using uppercase for variable name to follow linux coding style. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove the unused enum. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove unused element from 'wilc_priv' structure. Below elements are removed in 'wilc_priv' structure: struct WILC_WFI_packet *ppool; struct WILC_WFI_packet *rx_queue; /* List of incoming packets */ int rx_int_enabled; int tx_packetlen; u8 *tx_packetdata; struct napi_struct napi; Signed-off-by:
-
Ajay Singh authored
Rename wilc1000_wlan_init() & wilc1000_wlan_deinit() function to avoid unecessary 'wilc1000' prefix in function to be inline with other function naming convension. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to follow name as per linux coding style. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to have struct name as per linux coding style. Signed-off-by:
-
Ajay Singh authored
Rename the mac status macro to follow the same naming style. Also move them to keep together. Renamed like below >From ------------------------> To WILC_MAC_STATUS_INIT -> MAC_STATUS_INIT MAC_CONNECTED --------> MAC_STATUS_CONNECTED MAC_DISCONNECTED -----> MAC_STATUS_DISCONNECTED Signed-off-by:
-
Ajay Singh authored
Remove below #define which are not used in code: WILC_MAC_STATUS_READY WILC_MAC_STATUS_CONNECT Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove unused #define. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove the unused typedef and also removed the unecessary comment about that typedef. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove the unused variable. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to simplify the if conditions logic in spi_data_write(). Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove the unnecessary {/**/} block in wilc_parse_network_info(). Signed-off-by: -
Ajay Singh authored
Cleanup patch to remove the unused variables in wilc_parse_network_info(). The value is assinged to these local variables but assinged value is not used in that function. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove the 'cmd' variable in wilc_spi.c. Instead of using cmd now passing the command directly. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to remove the unnecessary use of '==' check used in if conditions. Signed-off-by:
-
Ajay Singh authored
Cleanup patch to align the #define used in wilc_spi.c file by adding the tabs. Signed-off-by:
-
Sergio Paracuellos authored
This commit refactors ks_wlan_translate_scan function with the following changes: - reorder local variables - use ether_addr_copy to copy ethernet addresses - change style in 'current_ev' variable assignments - make use of some ternaries avoiding if-else code - use preferred style for comments - extract common code into a new ks_wlan_add_leader_event function After this changes readability has been improved. Signed-off-by:Sergio Paracuellos <sergio.paracuellos@gmail.com> Signed-off-by:
-
Sergio Paracuellos authored
This commit removes a blank line which is included between declarations and it has not sense at all. Signed-off-by:
-
Sergio Paracuellos authored
Use ether_addr_copy to copy ethernet addresses instead of using custom memcpy for that. Signed-off-by:
-
Sergio Paracuellos authored
The if-else code in ks_wlan_get_power function is not needed at all and can be achieved with a simple boolean assignation. Signed-off-by:
-
Sergio Paracuellos authored
Change if logic to handle invalid case for operation_mode at first avoiding an 'else' path. Signed-off-by:
-
Sergio Paracuellos authored
Use ether_addr_copy to copy ethernet addresses instead of a custom memcpy. This improves readability. Signed-off-by:
-
Sergio Paracuellos authored
Make use of ether_addr_copy instead of memcpy for copying ethernet address data in ks_wlan_set_wap function and avoid an 'else' just changing if logic to check invalid values first. Signed-off-by:
-
Sergio Paracuellos authored
To avoid a long line align values in static array frequency_list array. Signed-off-by:
-
Sergio Paracuellos authored
Instead of manually memcpy ethernet addresses use ether_addr_copy function for this purpose. Signed-off-by:
-
Sergio Paracuellos authored
This commit cleans a bit ks_wlan_set_pmksa function removing nonsense comments as well as make use of ether_addr_* family functions written to not do manually things that were being here. Minor single if brackets has been removed also. Signed-off-by:
-
Sergio Paracuellos authored
This commit refactors ks_wlan_set_cts_mode function to handle invalid values first and then assign the good one changing a bit logic to use a ternary operator. Signed-off-by:
-
Sergio Paracuellos authored
Change if logic to handle invalid values first and just assign at the end the valid one if it is the case. Signed-off-by:
-
Sergio Paracuellos authored
This commit change logic to simplify conditional paths in ks_wlan_set_power_mgmt function. It handles invalid's first and just finally assign a valid value. Signed-off-by:
-
Sergio Paracuellos authored
This commit changes logic to handle invalid values first and just assign valid ones afterwards. Signed-off-by:
-
Sergio Paracuellos authored
Change if condition to handle invalid value first and avoid nonsense else's path improving readability. Signed-off-by:
-
